2014-10-31 10:41:07 +00:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2015 Vincent Petry <pvince81@owncloud.com>
|
|
|
|
*
|
|
|
|
* This file is licensed under the Affero General Public License version 3
|
|
|
|
* or later.
|
|
|
|
*
|
|
|
|
* See the COPYING-README file.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
describe('OCA.External.Settings tests', function() {
|
|
|
|
var clock;
|
|
|
|
var select2Stub;
|
|
|
|
var select2ApplicableUsers;
|
|
|
|
|
|
|
|
beforeEach(function() {
|
|
|
|
clock = sinon.useFakeTimers();
|
|
|
|
select2Stub = sinon.stub($.fn, 'select2', function(args) {
|
|
|
|
if (args === 'val') {
|
|
|
|
return select2ApplicableUsers;
|
|
|
|
}
|
|
|
|
return {
|
|
|
|
on: function() {}
|
|
|
|
};
|
|
|
|
});
|
|
|
|
|
|
|
|
// view still requires an existing DOM table
|
|
|
|
$('#testArea').append(
|
|
|
|
'<table id="externalStorage" data-admin="true">' +
|
|
|
|
'<thead></thead>' +
|
|
|
|
'<tbody>' +
|
|
|
|
'<tr id="addMountPoint" data-id="">' +
|
|
|
|
'<td class="status"></td>' +
|
|
|
|
'<td class="mountPoint"><input type="text" name="mountPoint"/></td>' +
|
|
|
|
'<td class="backend">' +
|
|
|
|
'<select class="selectBackend">' +
|
|
|
|
'<option disable selected>Add storage</option>' +
|
|
|
|
'<option value="\\OC\\TestBackend">Test Backend</option>' +
|
|
|
|
'<option value="\\OC\\AnotherTestBackend">Another Test Backend</option>' +
|
|
|
|
'</select>' +
|
|
|
|
'</td>' +
|
Authentication mechanisms for external storage backends
A backend can now specify generic authentication schemes that it
supports, instead of specifying the parameters for its authentication
method directly. This allows multiple authentication mechanisms to be
implemented for a single scheme, providing altered functionality.
This commit introduces the backend framework for this feature, and so at
this point the UI will be broken as the frontend does not specify the
required information.
Terminology:
- authentication scheme
Parameter interface for the authentication method. A backend
supporting the 'password' scheme accepts two parameters, 'user' and
'password'.
- authentication mechanism
Specific mechanism implementing a scheme. Basic mechanisms may
forward configuration options directly to the backend, more advanced
ones may lookup parameters or retrieve them from the session
New dropdown selector for external storage configurations to select the
authentication mechanism to be used.
Authentication mechanisms can have visibilities, just like backends.
The API was extended too to make it easier to add/remove visibilities.
In addition, the concept of 'allowed visibility' has been introduced, so
a backend/auth mechanism can force a maximum visibility level (e.g.
Local storage type) that cannot be overridden by configuration in the
web UI.
An authentication mechanism is a fully instantiated implementation. This
allows an implementation to have dependencies injected into it, e.g. an
\OCP\IDB for database operations.
When a StorageConfig is being prepared for mounting, the authentication
mechanism implementation has manipulateStorage() called,
which inserts the relevant authentication method options into the
storage ready for mounting.
2015-08-12 09:54:03 +00:00
|
|
|
'<td class="authentication"></td>' +
|
2014-10-31 10:41:07 +00:00
|
|
|
'<td class="configuration"></td>' +
|
|
|
|
'<td class="applicable">' +
|
|
|
|
'<input type="hidden" class="applicableUsers">' +
|
|
|
|
'</td>' +
|
2015-03-16 13:07:53 +00:00
|
|
|
'<td class="mountOptionsToggle"><input type="hidden" class="mountOptions"/><img class="svg action"/></td>' +
|
2014-10-31 10:41:07 +00:00
|
|
|
'<td><img alt="Delete" title="Delete" class="svg action"/></td>' +
|
|
|
|
'</tr>' +
|
|
|
|
'</tbody>' +
|
|
|
|
'</table>'
|
|
|
|
);
|
|
|
|
// these are usually appended into the data attribute
|
|
|
|
// within the DOM by the server template
|
|
|
|
$('#externalStorage .selectBackend:first').data('configurations', {
|
|
|
|
'\\OC\\TestBackend': {
|
|
|
|
'backend': 'Test Backend Name',
|
|
|
|
'configuration': {
|
|
|
|
'field1': 'Display Name 1',
|
|
|
|
'field2': '&Display Name 2'
|
2015-03-16 14:07:38 +00:00
|
|
|
},
|
Authentication mechanisms for external storage backends
A backend can now specify generic authentication schemes that it
supports, instead of specifying the parameters for its authentication
method directly. This allows multiple authentication mechanisms to be
implemented for a single scheme, providing altered functionality.
This commit introduces the backend framework for this feature, and so at
this point the UI will be broken as the frontend does not specify the
required information.
Terminology:
- authentication scheme
Parameter interface for the authentication method. A backend
supporting the 'password' scheme accepts two parameters, 'user' and
'password'.
- authentication mechanism
Specific mechanism implementing a scheme. Basic mechanisms may
forward configuration options directly to the backend, more advanced
ones may lookup parameters or retrieve them from the session
New dropdown selector for external storage configurations to select the
authentication mechanism to be used.
Authentication mechanisms can have visibilities, just like backends.
The API was extended too to make it easier to add/remove visibilities.
In addition, the concept of 'allowed visibility' has been introduced, so
a backend/auth mechanism can force a maximum visibility level (e.g.
Local storage type) that cannot be overridden by configuration in the
web UI.
An authentication mechanism is a fully instantiated implementation. This
allows an implementation to have dependencies injected into it, e.g. an
\OCP\IDB for database operations.
When a StorageConfig is being prepared for mounting, the authentication
mechanism implementation has manipulateStorage() called,
which inserts the relevant authentication method options into the
storage ready for mounting.
2015-08-12 09:54:03 +00:00
|
|
|
'authSchemes': {
|
|
|
|
'builtin': true,
|
|
|
|
},
|
2015-03-16 14:07:38 +00:00
|
|
|
'priority': 11
|
2014-10-31 10:41:07 +00:00
|
|
|
},
|
|
|
|
'\\OC\\AnotherTestBackend': {
|
|
|
|
'backend': 'Another Test Backend Name',
|
|
|
|
'configuration': {
|
|
|
|
'field1': 'Display Name 1',
|
|
|
|
'field2': '&Display Name 2'
|
2015-03-16 14:07:38 +00:00
|
|
|
},
|
Authentication mechanisms for external storage backends
A backend can now specify generic authentication schemes that it
supports, instead of specifying the parameters for its authentication
method directly. This allows multiple authentication mechanisms to be
implemented for a single scheme, providing altered functionality.
This commit introduces the backend framework for this feature, and so at
this point the UI will be broken as the frontend does not specify the
required information.
Terminology:
- authentication scheme
Parameter interface for the authentication method. A backend
supporting the 'password' scheme accepts two parameters, 'user' and
'password'.
- authentication mechanism
Specific mechanism implementing a scheme. Basic mechanisms may
forward configuration options directly to the backend, more advanced
ones may lookup parameters or retrieve them from the session
New dropdown selector for external storage configurations to select the
authentication mechanism to be used.
Authentication mechanisms can have visibilities, just like backends.
The API was extended too to make it easier to add/remove visibilities.
In addition, the concept of 'allowed visibility' has been introduced, so
a backend/auth mechanism can force a maximum visibility level (e.g.
Local storage type) that cannot be overridden by configuration in the
web UI.
An authentication mechanism is a fully instantiated implementation. This
allows an implementation to have dependencies injected into it, e.g. an
\OCP\IDB for database operations.
When a StorageConfig is being prepared for mounting, the authentication
mechanism implementation has manipulateStorage() called,
which inserts the relevant authentication method options into the
storage ready for mounting.
2015-08-12 09:54:03 +00:00
|
|
|
'authSchemes': {
|
|
|
|
'builtin': true,
|
|
|
|
},
|
2015-03-16 14:07:38 +00:00
|
|
|
'priority': 12
|
2014-10-31 10:41:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
);
|
Authentication mechanisms for external storage backends
A backend can now specify generic authentication schemes that it
supports, instead of specifying the parameters for its authentication
method directly. This allows multiple authentication mechanisms to be
implemented for a single scheme, providing altered functionality.
This commit introduces the backend framework for this feature, and so at
this point the UI will be broken as the frontend does not specify the
required information.
Terminology:
- authentication scheme
Parameter interface for the authentication method. A backend
supporting the 'password' scheme accepts two parameters, 'user' and
'password'.
- authentication mechanism
Specific mechanism implementing a scheme. Basic mechanisms may
forward configuration options directly to the backend, more advanced
ones may lookup parameters or retrieve them from the session
New dropdown selector for external storage configurations to select the
authentication mechanism to be used.
Authentication mechanisms can have visibilities, just like backends.
The API was extended too to make it easier to add/remove visibilities.
In addition, the concept of 'allowed visibility' has been introduced, so
a backend/auth mechanism can force a maximum visibility level (e.g.
Local storage type) that cannot be overridden by configuration in the
web UI.
An authentication mechanism is a fully instantiated implementation. This
allows an implementation to have dependencies injected into it, e.g. an
\OCP\IDB for database operations.
When a StorageConfig is being prepared for mounting, the authentication
mechanism implementation has manipulateStorage() called,
which inserts the relevant authentication method options into the
storage ready for mounting.
2015-08-12 09:54:03 +00:00
|
|
|
|
|
|
|
$('#externalStorage #addMountPoint .authentication:first').data('mechanisms', {
|
|
|
|
'mechanism1': {
|
|
|
|
'name': 'Mechanism 1',
|
|
|
|
'configuration': {
|
|
|
|
},
|
|
|
|
'scheme': 'builtin',
|
|
|
|
},
|
|
|
|
});
|
|
|
|
|
2014-10-31 10:41:07 +00:00
|
|
|
});
|
|
|
|
afterEach(function() {
|
|
|
|
select2Stub.restore();
|
|
|
|
clock.restore();
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('storage configuration', function() {
|
|
|
|
var view;
|
|
|
|
|
|
|
|
function selectBackend(backendName) {
|
Authentication mechanisms for external storage backends
A backend can now specify generic authentication schemes that it
supports, instead of specifying the parameters for its authentication
method directly. This allows multiple authentication mechanisms to be
implemented for a single scheme, providing altered functionality.
This commit introduces the backend framework for this feature, and so at
this point the UI will be broken as the frontend does not specify the
required information.
Terminology:
- authentication scheme
Parameter interface for the authentication method. A backend
supporting the 'password' scheme accepts two parameters, 'user' and
'password'.
- authentication mechanism
Specific mechanism implementing a scheme. Basic mechanisms may
forward configuration options directly to the backend, more advanced
ones may lookup parameters or retrieve them from the session
New dropdown selector for external storage configurations to select the
authentication mechanism to be used.
Authentication mechanisms can have visibilities, just like backends.
The API was extended too to make it easier to add/remove visibilities.
In addition, the concept of 'allowed visibility' has been introduced, so
a backend/auth mechanism can force a maximum visibility level (e.g.
Local storage type) that cannot be overridden by configuration in the
web UI.
An authentication mechanism is a fully instantiated implementation. This
allows an implementation to have dependencies injected into it, e.g. an
\OCP\IDB for database operations.
When a StorageConfig is being prepared for mounting, the authentication
mechanism implementation has manipulateStorage() called,
which inserts the relevant authentication method options into the
storage ready for mounting.
2015-08-12 09:54:03 +00:00
|
|
|
view.$el.find('.selectBackend:first').val(backendName).trigger('change');
|
2014-10-31 10:41:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
beforeEach(function() {
|
|
|
|
var $el = $('#externalStorage');
|
2015-04-02 16:17:28 +00:00
|
|
|
view = new OCA.External.Settings.MountConfigListView($el, {encryptionEnabled: false});
|
2014-10-31 10:41:07 +00:00
|
|
|
});
|
|
|
|
afterEach(function() {
|
|
|
|
view = null;
|
|
|
|
});
|
|
|
|
describe('selecting backend', function() {
|
|
|
|
it('populates the row and creates a new empty one', function() {
|
|
|
|
var $firstRow = view.$el.find('tr:first');
|
|
|
|
selectBackend('\\OC\\TestBackend');
|
|
|
|
expect($firstRow.find('.backend').text()).toEqual('Test Backend');
|
|
|
|
expect($firstRow.find('.selectBackend').length).toEqual(0);
|
|
|
|
|
|
|
|
// TODO: check "remove" button visibility
|
|
|
|
|
|
|
|
// the suggested mount point name
|
|
|
|
expect($firstRow.find('[name=mountPoint]').val()).toEqual('TestBackend');
|
|
|
|
|
|
|
|
// TODO: check that the options have been created
|
|
|
|
|
|
|
|
// TODO: check select2 call on the ".applicableUsers" element
|
|
|
|
|
|
|
|
var $emptyRow = $firstRow.next('tr');
|
|
|
|
expect($emptyRow.length).toEqual(1);
|
|
|
|
expect($emptyRow.find('.selectBackend').length).toEqual(1);
|
|
|
|
expect($emptyRow.find('.applicable select').length).toEqual(0);
|
|
|
|
|
|
|
|
// TODO: check "remove" button visibility
|
|
|
|
});
|
|
|
|
// TODO: test with personal mounts (no applicable fields)
|
|
|
|
// TODO: test suggested mount point logic
|
|
|
|
});
|
|
|
|
describe('saving storages', function() {
|
2015-03-16 13:07:53 +00:00
|
|
|
var $tr;
|
2014-10-31 10:41:07 +00:00
|
|
|
|
2015-03-16 13:07:53 +00:00
|
|
|
beforeEach(function() {
|
|
|
|
$tr = view.$el.find('tr:first');
|
|
|
|
selectBackend('\\OC\\TestBackend');
|
|
|
|
});
|
|
|
|
it('saves storage after editing config', function() {
|
2014-10-31 10:41:07 +00:00
|
|
|
var $field1 = $tr.find('input[data-parameter=field1]');
|
|
|
|
expect($field1.length).toEqual(1);
|
|
|
|
$field1.val('test');
|
|
|
|
$field1.trigger(new $.Event('keyup', {keyCode: 97}));
|
|
|
|
|
2015-03-16 13:07:53 +00:00
|
|
|
var $mountOptionsField = $tr.find('input.mountOptions');
|
|
|
|
expect($mountOptionsField.length).toEqual(1);
|
|
|
|
$mountOptionsField.val(JSON.stringify({previews:true}));
|
|
|
|
|
2014-10-31 10:41:07 +00:00
|
|
|
clock.tick(4000);
|
|
|
|
|
|
|
|
expect(fakeServer.requests.length).toEqual(1);
|
|
|
|
var request = fakeServer.requests[0];
|
|
|
|
expect(request.url).toEqual(OC.webroot + '/index.php/apps/files_external/globalstorages');
|
2015-03-16 13:07:53 +00:00
|
|
|
expect(JSON.parse(request.requestBody)).toEqual({
|
Authentication mechanisms for external storage backends
A backend can now specify generic authentication schemes that it
supports, instead of specifying the parameters for its authentication
method directly. This allows multiple authentication mechanisms to be
implemented for a single scheme, providing altered functionality.
This commit introduces the backend framework for this feature, and so at
this point the UI will be broken as the frontend does not specify the
required information.
Terminology:
- authentication scheme
Parameter interface for the authentication method. A backend
supporting the 'password' scheme accepts two parameters, 'user' and
'password'.
- authentication mechanism
Specific mechanism implementing a scheme. Basic mechanisms may
forward configuration options directly to the backend, more advanced
ones may lookup parameters or retrieve them from the session
New dropdown selector for external storage configurations to select the
authentication mechanism to be used.
Authentication mechanisms can have visibilities, just like backends.
The API was extended too to make it easier to add/remove visibilities.
In addition, the concept of 'allowed visibility' has been introduced, so
a backend/auth mechanism can force a maximum visibility level (e.g.
Local storage type) that cannot be overridden by configuration in the
web UI.
An authentication mechanism is a fully instantiated implementation. This
allows an implementation to have dependencies injected into it, e.g. an
\OCP\IDB for database operations.
When a StorageConfig is being prepared for mounting, the authentication
mechanism implementation has manipulateStorage() called,
which inserts the relevant authentication method options into the
storage ready for mounting.
2015-08-12 09:54:03 +00:00
|
|
|
backend: '\\OC\\TestBackend',
|
|
|
|
authMechanism: 'mechanism1',
|
2015-03-16 13:07:53 +00:00
|
|
|
backendOptions: {
|
|
|
|
'field1': 'test',
|
|
|
|
'field2': ''
|
|
|
|
},
|
2015-03-16 14:07:38 +00:00
|
|
|
mountPoint: 'TestBackend',
|
2015-03-16 13:07:53 +00:00
|
|
|
priority: 11,
|
|
|
|
applicableUsers: [],
|
|
|
|
applicableGroups: [],
|
|
|
|
mountOptions: {
|
|
|
|
'previews': true
|
|
|
|
}
|
2014-10-31 10:41:07 +00:00
|
|
|
});
|
|
|
|
|
|
|
|
// TODO: respond and check data-id
|
|
|
|
});
|
2015-03-16 13:07:53 +00:00
|
|
|
it('saves storage after closing mount options dropdown', function() {
|
|
|
|
$tr.find('.mountOptionsToggle img').click();
|
|
|
|
$tr.find('[name=previews]').trigger(new $.Event('keyup', {keyCode: 97}));
|
|
|
|
$tr.find('input[data-parameter=field1]').val('test');
|
|
|
|
|
|
|
|
// does not save inside the dropdown
|
|
|
|
expect(fakeServer.requests.length).toEqual(0);
|
|
|
|
|
|
|
|
$('body').mouseup();
|
|
|
|
|
|
|
|
// but after closing the dropdown
|
|
|
|
expect(fakeServer.requests.length).toEqual(1);
|
|
|
|
});
|
2014-10-31 10:41:07 +00:00
|
|
|
// TODO: tests with "applicableUsers" and "applicableGroups"
|
|
|
|
// TODO: test with non-optional config parameters
|
|
|
|
// TODO: test with missing mount point value
|
|
|
|
// TODO: test with personal mounts (no applicable fields)
|
|
|
|
// TODO: test save triggers: paste, keyup, checkbox
|
|
|
|
// TODO: test "custom" field with addScript
|
|
|
|
// TODO: status indicator
|
|
|
|
});
|
|
|
|
describe('update storage', function() {
|
|
|
|
// TODO
|
|
|
|
});
|
|
|
|
describe('delete storage', function() {
|
|
|
|
// TODO
|
|
|
|
});
|
|
|
|
describe('recheck storages', function() {
|
|
|
|
// TODO
|
|
|
|
});
|
2015-03-16 13:07:53 +00:00
|
|
|
describe('mount options dropdown', function() {
|
|
|
|
var $tr;
|
|
|
|
var $td;
|
|
|
|
|
|
|
|
beforeEach(function() {
|
|
|
|
$tr = view.$el.find('tr:first');
|
|
|
|
$td = $tr.find('.mountOptionsToggle');
|
|
|
|
selectBackend('\\OC\\TestBackend');
|
|
|
|
});
|
|
|
|
|
|
|
|
it('shows dropdown when clicking on toggle button, hides when clicking outside', function() {
|
|
|
|
$td.find('img').click();
|
|
|
|
|
|
|
|
expect($td.find('.dropdown').length).toEqual(1);
|
|
|
|
|
|
|
|
$('body').mouseup();
|
|
|
|
|
|
|
|
expect($td.find('.dropdown').length).toEqual(0);
|
|
|
|
});
|
|
|
|
|
2015-04-02 16:31:26 +00:00
|
|
|
it('doesnt show the encryption option when encryption is disabled', function () {
|
|
|
|
view._encryptionEnabled = false;
|
|
|
|
$td.find('img').click();
|
|
|
|
|
|
|
|
expect($td.find('.dropdown [name=encrypt]:visible').length).toEqual(0);
|
|
|
|
|
|
|
|
$('body').mouseup();
|
|
|
|
|
|
|
|
expect($td.find('.dropdown').length).toEqual(0);
|
|
|
|
});
|
|
|
|
|
2015-03-16 13:07:53 +00:00
|
|
|
it('reads config from mountOptions field', function() {
|
|
|
|
$tr.find('input.mountOptions').val(JSON.stringify({previews:false}));
|
|
|
|
|
|
|
|
$td.find('img').click();
|
|
|
|
expect($td.find('.dropdown [name=previews]').prop('checked')).toEqual(false);
|
|
|
|
$('body').mouseup();
|
|
|
|
|
|
|
|
$tr.find('input.mountOptions').val(JSON.stringify({previews:true}));
|
|
|
|
$td.find('img').click();
|
|
|
|
expect($td.find('.dropdown [name=previews]').prop('checked')).toEqual(true);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('writes config into mountOptions field', function() {
|
|
|
|
$td.find('img').click();
|
|
|
|
// defaults to true
|
|
|
|
var $field = $td.find('.dropdown [name=previews]');
|
|
|
|
expect($field.prop('checked')).toEqual(true);
|
|
|
|
$td.find('.dropdown [name=filesystem_check_changes]').val(2);
|
|
|
|
$('body').mouseup();
|
|
|
|
|
|
|
|
expect(JSON.parse($tr.find('input.mountOptions').val())).toEqual({
|
2015-04-02 16:17:28 +00:00
|
|
|
encrypt: true,
|
2015-03-16 13:07:53 +00:00
|
|
|
previews: true,
|
|
|
|
filesystem_check_changes: 2
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
2014-10-31 10:41:07 +00:00
|
|
|
});
|
|
|
|
describe('applicable user list', function() {
|
|
|
|
// TODO: test select2 retrieval logic
|
|
|
|
});
|
|
|
|
describe('allow user mounts section', function() {
|
|
|
|
// TODO: test allowUserMounting section
|
|
|
|
});
|
|
|
|
});
|