2014-10-15 09:58:44 +00:00
|
|
|
<?php
|
|
|
|
/**
|
2016-07-21 14:49:16 +00:00
|
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
|
|
*
|
2017-11-06 14:56:42 +00:00
|
|
|
* @author Bjoern Schiessle <bjoern@schiessle.org>
|
2016-05-26 17:56:05 +00:00
|
|
|
* @author Lukas Reschke <lukas@statuscode.ch>
|
2015-03-26 10:44:34 +00:00
|
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
2016-07-21 14:49:16 +00:00
|
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
2015-03-26 10:44:34 +00:00
|
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
|
|
*
|
|
|
|
* @license AGPL-3.0
|
|
|
|
*
|
|
|
|
* This code is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
|
|
* as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU Affero General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
2014-10-15 09:58:44 +00:00
|
|
|
*
|
|
|
|
*/
|
2015-02-26 10:37:37 +00:00
|
|
|
|
2014-10-15 09:58:44 +00:00
|
|
|
namespace OCA\Files_Sharing\Middleware;
|
2016-10-24 11:25:59 +00:00
|
|
|
use OCA\Files_Sharing\Controller\ExternalSharesController;
|
|
|
|
use OCA\Files_Sharing\Controller\ShareController;
|
|
|
|
use OCP\App\IAppManager;
|
|
|
|
use OCP\AppFramework\Controller;
|
2015-09-30 11:32:20 +00:00
|
|
|
use OCP\AppFramework\Http\NotFoundResponse;
|
|
|
|
use OCP\Files\NotFoundException;
|
2015-10-02 07:57:33 +00:00
|
|
|
use OCP\AppFramework\Utility\IControllerMethodReflector;
|
|
|
|
use OCA\Files_Sharing\Exceptions\S2SException;
|
|
|
|
use OCP\AppFramework\Http\JSONResponse;
|
2016-10-24 11:25:59 +00:00
|
|
|
use OCP\IConfig;
|
2017-01-04 12:33:45 +00:00
|
|
|
use OCP\IRequest;
|
|
|
|
use OCP\Share\IManager;
|
|
|
|
use OCP\Share\IShare;
|
2014-10-15 09:58:44 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @package OCA\Files_Sharing\Middleware\SharingCheckMiddleware
|
|
|
|
*/
|
2015-01-14 12:56:49 +00:00
|
|
|
class SharingCheckMiddlewareTest extends \Test\TestCase {
|
2014-10-15 09:58:44 +00:00
|
|
|
|
2016-10-24 11:25:59 +00:00
|
|
|
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */
|
2015-01-14 12:56:49 +00:00
|
|
|
private $config;
|
2016-10-24 11:25:59 +00:00
|
|
|
/** @var IAppManager|\PHPUnit_Framework_MockObject_MockObject */
|
2015-01-14 12:56:49 +00:00
|
|
|
private $appManager;
|
2014-10-15 09:58:44 +00:00
|
|
|
/** @var SharingCheckMiddleware */
|
|
|
|
private $sharingCheckMiddleware;
|
2016-10-24 11:25:59 +00:00
|
|
|
/** @var Controller|\PHPUnit_Framework_MockObject_MockObject */
|
2015-09-30 11:32:20 +00:00
|
|
|
private $controllerMock;
|
2016-10-24 11:25:59 +00:00
|
|
|
/** @var IControllerMethodReflector|\PHPUnit_Framework_MockObject_MockObject */
|
2015-10-02 07:57:33 +00:00
|
|
|
private $reflector;
|
2017-01-04 12:33:45 +00:00
|
|
|
/** @var IManager | \PHPUnit_Framework_MockObject_MockObject */
|
|
|
|
private $shareManager;
|
|
|
|
/** @var IRequest | \PHPUnit_Framework_MockObject_MockObject */
|
|
|
|
private $request;
|
2014-10-15 09:58:44 +00:00
|
|
|
|
|
|
|
protected function setUp() {
|
2016-10-24 11:25:59 +00:00
|
|
|
parent::setUp();
|
|
|
|
|
|
|
|
$this->config = $this->createMock(IConfig::class);
|
|
|
|
$this->appManager = $this->createMock(IAppManager::class);
|
|
|
|
$this->controllerMock = $this->createMock(Controller::class);
|
|
|
|
$this->reflector = $this->createMock(IControllerMethodReflector::class);
|
2017-01-04 12:33:45 +00:00
|
|
|
$this->shareManager = $this->createMock(IManager::class);
|
|
|
|
$this->request = $this->createMock(IRequest::class);
|
2014-10-15 09:58:44 +00:00
|
|
|
|
2015-10-02 07:57:33 +00:00
|
|
|
$this->sharingCheckMiddleware = new SharingCheckMiddleware(
|
|
|
|
'files_sharing',
|
|
|
|
$this->config,
|
|
|
|
$this->appManager,
|
2017-01-04 12:33:45 +00:00
|
|
|
$this->reflector,
|
|
|
|
$this->shareManager,
|
|
|
|
$this->request);
|
2014-10-15 09:58:44 +00:00
|
|
|
}
|
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
public function testIsSharingEnabledWithAppEnabled() {
|
2015-01-14 12:56:49 +00:00
|
|
|
$this->appManager
|
2014-10-15 09:58:44 +00:00
|
|
|
->expects($this->once())
|
2015-01-14 12:56:49 +00:00
|
|
|
->method('isEnabledForUser')
|
2014-10-15 09:58:44 +00:00
|
|
|
->with('files_sharing')
|
|
|
|
->will($this->returnValue(true));
|
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
$this->assertTrue(self::invokePrivate($this->sharingCheckMiddleware, 'isSharingEnabled'));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testIsSharingEnabledWithAppDisabled() {
|
|
|
|
$this->appManager
|
|
|
|
->expects($this->once())
|
|
|
|
->method('isEnabledForUser')
|
|
|
|
->with('files_sharing')
|
|
|
|
->will($this->returnValue(false));
|
|
|
|
|
|
|
|
$this->assertFalse(self::invokePrivate($this->sharingCheckMiddleware, 'isSharingEnabled'));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testIsLinkSharingEnabledWithEverythinEnabled() {
|
2015-01-14 12:56:49 +00:00
|
|
|
$this->config
|
2015-09-22 12:47:04 +00:00
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'shareapi_enabled', 'yes')
|
|
|
|
->will($this->returnValue('yes'));
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
2015-01-14 12:56:49 +00:00
|
|
|
->method('getAppValue')
|
2014-10-15 09:58:44 +00:00
|
|
|
->with('core', 'shareapi_allow_links', 'yes')
|
|
|
|
->will($this->returnValue('yes'));
|
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
$this->assertTrue(self::invokePrivate($this->sharingCheckMiddleware, 'isLinkSharingEnabled'));
|
2014-10-15 09:58:44 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
public function testIsLinkSharingEnabledWithLinkSharingDisabled() {
|
2015-01-14 12:56:49 +00:00
|
|
|
$this->config
|
2015-09-22 12:47:04 +00:00
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'shareapi_enabled', 'yes')
|
|
|
|
->will($this->returnValue('yes'));
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
2015-01-14 12:56:49 +00:00
|
|
|
->method('getAppValue')
|
2014-10-15 09:58:44 +00:00
|
|
|
->with('core', 'shareapi_allow_links', 'yes')
|
|
|
|
->will($this->returnValue('no'));
|
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
$this->assertFalse(self::invokePrivate($this->sharingCheckMiddleware, 'isLinkSharingEnabled'));
|
2014-10-15 09:58:44 +00:00
|
|
|
}
|
2015-09-22 12:47:04 +00:00
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
public function testIsLinkSharingEnabledWithSharingAPIDisabled() {
|
2015-09-22 12:47:04 +00:00
|
|
|
$this->config
|
|
|
|
->expects($this->once())
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'shareapi_enabled', 'yes')
|
|
|
|
->will($this->returnValue('no'));
|
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
$this->assertFalse(self::invokePrivate($this->sharingCheckMiddleware, 'isLinkSharingEnabled'));
|
2015-09-22 12:47:04 +00:00
|
|
|
}
|
|
|
|
|
2015-10-02 07:57:33 +00:00
|
|
|
public function externalSharesChecksDataProvider() {
|
|
|
|
|
|
|
|
$data = [];
|
|
|
|
|
|
|
|
foreach ([false, true] as $annIn) {
|
|
|
|
foreach ([false, true] as $annOut) {
|
|
|
|
foreach ([false, true] as $confIn) {
|
|
|
|
foreach ([false, true] as $confOut) {
|
|
|
|
|
|
|
|
$res = true;
|
|
|
|
if (!$annIn && !$confIn) {
|
|
|
|
$res = false;
|
|
|
|
} elseif (!$annOut && !$confOut) {
|
|
|
|
$res = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
$d = [
|
|
|
|
[
|
|
|
|
['NoIncomingFederatedSharingRequired', $annIn],
|
|
|
|
['NoOutgoingFederatedSharingRequired', $annOut],
|
|
|
|
],
|
|
|
|
[
|
|
|
|
['files_sharing', 'incoming_server2server_share_enabled', 'yes', $confIn ? 'yes' : 'no'],
|
|
|
|
['files_sharing', 'outgoing_server2server_share_enabled', 'yes', $confOut ? 'yes' : 'no'],
|
|
|
|
],
|
|
|
|
$res
|
|
|
|
];
|
|
|
|
|
|
|
|
$data[] = $d;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $data;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider externalSharesChecksDataProvider
|
|
|
|
*/
|
|
|
|
public function testExternalSharesChecks($annotations, $config, $expectedResult) {
|
|
|
|
$this->reflector
|
|
|
|
->expects($this->atLeastOnce())
|
|
|
|
->method('hasAnnotation')
|
|
|
|
->will($this->returnValueMap($annotations));
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->method('getAppValue')
|
|
|
|
->will($this->returnValueMap($config));
|
|
|
|
|
|
|
|
$this->assertEquals($expectedResult, self::invokePrivate($this->sharingCheckMiddleware, 'externalSharesChecks'));
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider externalSharesChecksDataProvider
|
|
|
|
*/
|
|
|
|
public function testBeforeControllerWithExternalShareControllerWithSharingEnabled($annotations, $config, $noException) {
|
|
|
|
$this->appManager
|
|
|
|
->expects($this->once())
|
|
|
|
->method('isEnabledForUser')
|
|
|
|
->with('files_sharing')
|
|
|
|
->will($this->returnValue(true));
|
|
|
|
|
|
|
|
$this->reflector
|
|
|
|
->expects($this->atLeastOnce())
|
|
|
|
->method('hasAnnotation')
|
|
|
|
->will($this->returnValueMap($annotations));
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->method('getAppValue')
|
|
|
|
->will($this->returnValueMap($config));
|
|
|
|
|
2016-10-24 11:25:59 +00:00
|
|
|
$controller = $this->createMock(ExternalSharesController::class);
|
2015-10-02 07:57:33 +00:00
|
|
|
|
|
|
|
$exceptionThrown = false;
|
|
|
|
|
|
|
|
try {
|
|
|
|
$this->sharingCheckMiddleware->beforeController($controller, 'myMethod');
|
2016-10-24 11:25:59 +00:00
|
|
|
} catch (S2SException $exception) {
|
2015-10-02 07:57:33 +00:00
|
|
|
$exceptionThrown = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->assertNotEquals($noException, $exceptionThrown);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testBeforeControllerWithShareControllerWithSharingEnabled() {
|
2017-01-04 12:33:45 +00:00
|
|
|
|
|
|
|
$share = $this->createMock(IShare::class);
|
|
|
|
|
2015-09-30 11:32:20 +00:00
|
|
|
$this->appManager
|
|
|
|
->expects($this->once())
|
|
|
|
->method('isEnabledForUser')
|
|
|
|
->with('files_sharing')
|
|
|
|
->will($this->returnValue(true));
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'shareapi_enabled', 'yes')
|
|
|
|
->will($this->returnValue('yes'));
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'shareapi_allow_links', 'yes')
|
|
|
|
->will($this->returnValue('yes'));
|
|
|
|
|
2017-01-04 12:33:45 +00:00
|
|
|
$this->request->expects($this->once())->method('getParam')->with('token')
|
|
|
|
->willReturn('token');
|
|
|
|
$this->shareManager->expects($this->once())->method('getShareByToken')
|
|
|
|
->with('token')->willReturn($share);
|
|
|
|
|
|
|
|
$share->expects($this->once())->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_LINK);
|
|
|
|
|
2016-10-24 11:25:59 +00:00
|
|
|
$controller = $this->createMock(ShareController::class);
|
2015-09-30 19:35:52 +00:00
|
|
|
|
|
|
|
$this->sharingCheckMiddleware->beforeController($controller, 'myMethod');
|
2015-09-30 11:32:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @expectedException \OCP\Files\NotFoundException
|
2015-10-02 07:57:33 +00:00
|
|
|
* @expectedExceptionMessage Link sharing is disabled
|
2015-09-30 11:32:20 +00:00
|
|
|
*/
|
2015-10-02 07:57:33 +00:00
|
|
|
public function testBeforeControllerWithShareControllerWithSharingEnabledAPIDisabled() {
|
2017-01-04 12:33:45 +00:00
|
|
|
|
|
|
|
$share = $this->createMock(IShare::class);
|
|
|
|
|
2015-09-30 11:32:20 +00:00
|
|
|
$this->appManager
|
|
|
|
->expects($this->once())
|
|
|
|
->method('isEnabledForUser')
|
|
|
|
->with('files_sharing')
|
2015-10-02 07:57:33 +00:00
|
|
|
->will($this->returnValue(true));
|
2015-09-30 11:32:20 +00:00
|
|
|
|
2016-10-24 11:25:59 +00:00
|
|
|
$controller = $this->createMock(ShareController::class);
|
2015-09-30 19:35:52 +00:00
|
|
|
|
2017-01-04 12:33:45 +00:00
|
|
|
$this->request->expects($this->once())->method('getParam')->with('token')
|
|
|
|
->willReturn('token');
|
|
|
|
$this->shareManager->expects($this->once())->method('getShareByToken')
|
|
|
|
->with('token')->willReturn($share);
|
|
|
|
|
|
|
|
$share->expects($this->once())->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_LINK);
|
|
|
|
|
|
|
|
|
2015-09-30 19:35:52 +00:00
|
|
|
$this->sharingCheckMiddleware->beforeController($controller, 'myMethod');
|
2015-09-30 11:32:20 +00:00
|
|
|
}
|
|
|
|
|
2015-10-02 07:57:33 +00:00
|
|
|
/**
|
|
|
|
* @expectedException \OCP\Files\NotFoundException
|
|
|
|
* @expectedExceptionMessage Sharing is disabled.
|
|
|
|
*/
|
|
|
|
public function testBeforeControllerWithSharingDisabled() {
|
|
|
|
$this->appManager
|
|
|
|
->expects($this->once())
|
|
|
|
->method('isEnabledForUser')
|
|
|
|
->with('files_sharing')
|
|
|
|
->will($this->returnValue(false));
|
|
|
|
|
|
|
|
$this->sharingCheckMiddleware->beforeController($this->controllerMock, 'myMethod');
|
|
|
|
}
|
|
|
|
|
2015-09-30 11:32:20 +00:00
|
|
|
/**
|
|
|
|
* @expectedException \Exception
|
|
|
|
* @expectedExceptionMessage My Exception message
|
|
|
|
*/
|
|
|
|
public function testAfterExceptionWithRegularException() {
|
|
|
|
$this->sharingCheckMiddleware->afterException($this->controllerMock, 'myMethod', new \Exception('My Exception message'));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testAfterExceptionWithNotFoundException() {
|
|
|
|
$this->assertEquals(new NotFoundResponse(), $this->sharingCheckMiddleware->afterException($this->controllerMock, 'myMethod', new NotFoundException('My Exception message')));
|
|
|
|
}
|
|
|
|
|
2015-10-02 07:57:33 +00:00
|
|
|
public function testAfterExceptionWithS2SException() {
|
|
|
|
$this->assertEquals(new JSONResponse('My Exception message', 405), $this->sharingCheckMiddleware->afterException($this->controllerMock, 'myMethod', new S2SException('My Exception message')));
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-10-15 09:58:44 +00:00
|
|
|
}
|