2013-08-02 09:46:47 +00:00
|
|
|
<?php
|
|
|
|
/**
|
|
|
|
* Copyright (c) 2013 Christopher Schäpers <christopher@schaepers.it>
|
2013-03-02 16:17:11 +00:00
|
|
|
* Copyright (c) 2013 Bart Visscher <bartv@thisnet.nl>
|
2013-08-02 09:46:47 +00:00
|
|
|
* This file is licensed under the Affero General Public License version 3 or
|
|
|
|
* later.
|
|
|
|
* See the COPYING-README file.
|
|
|
|
*/
|
|
|
|
|
2016-05-19 07:27:21 +00:00
|
|
|
namespace Test;
|
2017-01-12 09:49:22 +00:00
|
|
|
use OCP\IConfig;
|
2015-09-02 16:56:17 +00:00
|
|
|
|
2015-11-03 00:52:41 +00:00
|
|
|
/**
|
2016-05-20 13:38:20 +00:00
|
|
|
* Class AppConfigTest
|
2015-11-03 00:52:41 +00:00
|
|
|
*
|
|
|
|
* @group DB
|
|
|
|
*
|
2016-05-19 07:27:21 +00:00
|
|
|
* @package Test
|
2015-11-03 00:52:41 +00:00
|
|
|
*/
|
2016-05-20 13:38:20 +00:00
|
|
|
class AppConfigTest extends TestCase {
|
2015-05-11 10:22:23 +00:00
|
|
|
/** @var \OCP\IAppConfig */
|
|
|
|
protected $appConfig;
|
2014-11-10 21:59:50 +00:00
|
|
|
|
2015-05-11 10:22:23 +00:00
|
|
|
/** @var \OCP\IDBConnection */
|
|
|
|
protected $connection;
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
protected $originalConfig;
|
|
|
|
|
2015-05-11 10:22:23 +00:00
|
|
|
public function setUp() {
|
|
|
|
parent::setUp();
|
|
|
|
|
|
|
|
$this->connection = \OC::$server->getDatabaseConnection();
|
2015-09-02 16:56:17 +00:00
|
|
|
$sql = $this->connection->getQueryBuilder();
|
|
|
|
$sql->select('*')
|
|
|
|
->from('appconfig');
|
|
|
|
$result = $sql->execute();
|
|
|
|
$this->originalConfig = $result->fetchAll();
|
|
|
|
$result->closeCursor();
|
|
|
|
|
|
|
|
$sql = $this->connection->getQueryBuilder();
|
|
|
|
$sql->delete('appconfig');
|
|
|
|
$sql->execute();
|
|
|
|
|
2016-10-20 13:11:01 +00:00
|
|
|
$this->overwriteService('AppConfig', new \OC\AppConfig($this->connection));
|
2015-09-02 16:56:17 +00:00
|
|
|
|
|
|
|
$sql = $this->connection->getQueryBuilder();
|
|
|
|
$sql->insert('appconfig')
|
|
|
|
->values([
|
|
|
|
'appid' => $sql->createParameter('appid'),
|
|
|
|
'configkey' => $sql->createParameter('configkey'),
|
|
|
|
'configvalue' => $sql->createParameter('configvalue'),
|
|
|
|
]);
|
|
|
|
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'testapp',
|
|
|
|
'configkey' => 'enabled',
|
|
|
|
'configvalue' => 'true',
|
|
|
|
])->execute();
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'testapp',
|
|
|
|
'configkey' => 'installed_version',
|
|
|
|
'configvalue' => '1.2.3',
|
|
|
|
])->execute();
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'testapp',
|
|
|
|
'configkey' => 'depends_on',
|
|
|
|
'configvalue' => 'someapp',
|
|
|
|
])->execute();
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'testapp',
|
|
|
|
'configkey' => 'deletethis',
|
|
|
|
'configvalue' => 'deletethis',
|
|
|
|
])->execute();
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'testapp',
|
|
|
|
'configkey' => 'key',
|
|
|
|
'configvalue' => 'value',
|
|
|
|
])->execute();
|
|
|
|
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'someapp',
|
|
|
|
'configkey' => 'key',
|
|
|
|
'configvalue' => 'value',
|
|
|
|
])->execute();
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'someapp',
|
|
|
|
'configkey' => 'otherkey',
|
|
|
|
'configvalue' => 'othervalue',
|
|
|
|
])->execute();
|
|
|
|
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => '123456',
|
|
|
|
'configkey' => 'key',
|
|
|
|
'configvalue' => 'value',
|
|
|
|
])->execute();
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => '123456',
|
|
|
|
'configkey' => 'enabled',
|
|
|
|
'configvalue' => 'false',
|
|
|
|
])->execute();
|
|
|
|
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'anotherapp',
|
|
|
|
'configkey' => 'key',
|
|
|
|
'configvalue' => 'value',
|
|
|
|
])->execute();
|
|
|
|
$sql->setParameters([
|
|
|
|
'appid' => 'anotherapp',
|
|
|
|
'configkey' => 'enabled',
|
|
|
|
'configvalue' => 'false',
|
|
|
|
])->execute();
|
2013-08-02 09:46:47 +00:00
|
|
|
}
|
|
|
|
|
2015-05-11 10:22:23 +00:00
|
|
|
public function tearDown() {
|
2015-09-02 16:56:17 +00:00
|
|
|
$sql = $this->connection->getQueryBuilder();
|
|
|
|
$sql->delete('appconfig');
|
|
|
|
$sql->execute();
|
|
|
|
|
|
|
|
$sql = $this->connection->getQueryBuilder();
|
|
|
|
$sql->insert('appconfig')
|
|
|
|
->values([
|
|
|
|
'appid' => $sql->createParameter('appid'),
|
|
|
|
'configkey' => $sql->createParameter('configkey'),
|
|
|
|
'configvalue' => $sql->createParameter('configvalue'),
|
|
|
|
]);
|
|
|
|
|
|
|
|
foreach ($this->originalConfig as $configs) {
|
|
|
|
$sql->setParameter('appid', $configs['appid'])
|
|
|
|
->setParameter('configkey', $configs['configkey'])
|
|
|
|
->setParameter('configvalue', $configs['configvalue']);
|
|
|
|
$sql->execute();
|
|
|
|
}
|
2014-11-10 21:59:50 +00:00
|
|
|
|
2016-10-20 13:11:01 +00:00
|
|
|
$this->restoreService('AppConfig');
|
2015-05-11 10:22:23 +00:00
|
|
|
parent::tearDown();
|
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testGetApps() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
2015-05-11 10:22:23 +00:00
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$this->assertEquals([
|
|
|
|
'anotherapp',
|
|
|
|
'someapp',
|
|
|
|
'testapp',
|
|
|
|
'123456',
|
|
|
|
], $config->getApps());
|
2013-08-02 09:46:47 +00:00
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testGetKeys() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
|
|
|
|
$keys = $config->getKeys('testapp');
|
|
|
|
$this->assertEquals([
|
|
|
|
'deletethis',
|
|
|
|
'depends_on',
|
|
|
|
'enabled',
|
|
|
|
'installed_version',
|
|
|
|
'key',
|
|
|
|
], $keys);
|
2013-08-02 09:46:47 +00:00
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testGetValue() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
|
|
|
|
$value = $config->getValue('testapp', 'installed_version');
|
2015-05-11 10:29:28 +00:00
|
|
|
$this->assertConfigKey('testapp', 'installed_version', $value);
|
2013-08-02 09:46:47 +00:00
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$value = $config->getValue('testapp', 'nonexistant');
|
2013-08-02 09:46:47 +00:00
|
|
|
$this->assertNull($value);
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$value = $config->getValue('testapp', 'nonexistant', 'default');
|
2013-08-02 09:46:47 +00:00
|
|
|
$this->assertEquals('default', $value);
|
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testHasKey() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
2013-08-02 09:46:47 +00:00
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$this->assertTrue($config->hasKey('testapp', 'installed_version'));
|
|
|
|
$this->assertFalse($config->hasKey('testapp', 'nonexistant'));
|
|
|
|
$this->assertFalse($config->hasKey('nonexistant', 'nonexistant'));
|
2013-08-02 09:46:47 +00:00
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testSetValueUpdate() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
|
|
|
|
$this->assertEquals('1.2.3', $config->getValue('testapp', 'installed_version'));
|
|
|
|
$this->assertConfigKey('testapp', 'installed_version', '1.2.3');
|
|
|
|
|
2015-09-14 13:27:06 +00:00
|
|
|
$wasModified = $config->setValue('testapp', 'installed_version', '1.2.3');
|
|
|
|
if (!(\OC::$server->getDatabaseConnection() instanceof \OC\DB\OracleConnection)) {
|
|
|
|
$this->assertFalse($wasModified);
|
|
|
|
}
|
2015-09-02 16:56:17 +00:00
|
|
|
|
|
|
|
$this->assertEquals('1.2.3', $config->getValue('testapp', 'installed_version'));
|
|
|
|
$this->assertConfigKey('testapp', 'installed_version', '1.2.3');
|
|
|
|
|
|
|
|
$this->assertTrue($config->setValue('testapp', 'installed_version', '1.33.7'));
|
|
|
|
|
|
|
|
|
|
|
|
$this->assertEquals('1.33.7', $config->getValue('testapp', 'installed_version'));
|
2015-05-11 10:29:28 +00:00
|
|
|
$this->assertConfigKey('testapp', 'installed_version', '1.33.7');
|
2013-08-02 09:46:47 +00:00
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$config->setValue('someapp', 'somekey', 'somevalue');
|
2015-05-11 10:29:28 +00:00
|
|
|
$this->assertConfigKey('someapp', 'somekey', 'somevalue');
|
2013-08-02 09:46:47 +00:00
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testSetValueInsert() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
|
|
|
|
$this->assertFalse($config->hasKey('someapp', 'somekey'));
|
|
|
|
$this->assertNull($config->getValue('someapp', 'somekey'));
|
|
|
|
|
|
|
|
$this->assertTrue($config->setValue('someapp', 'somekey', 'somevalue'));
|
|
|
|
|
|
|
|
$this->assertTrue($config->hasKey('someapp', 'somekey'));
|
|
|
|
$this->assertEquals('somevalue', $config->getValue('someapp', 'somekey'));
|
|
|
|
$this->assertConfigKey('someapp', 'somekey', 'somevalue');
|
|
|
|
|
2015-09-14 13:27:06 +00:00
|
|
|
$wasInserted = $config->setValue('someapp', 'somekey', 'somevalue');
|
|
|
|
if (!(\OC::$server->getDatabaseConnection() instanceof \OC\DB\OracleConnection)) {
|
|
|
|
$this->assertFalse($wasInserted);
|
|
|
|
}
|
2015-09-02 16:56:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
public function testDeleteKey() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
|
|
|
|
$this->assertTrue($config->hasKey('testapp', 'deletethis'));
|
|
|
|
|
|
|
|
$config->deleteKey('testapp', 'deletethis');
|
|
|
|
|
|
|
|
$this->assertFalse($config->hasKey('testapp', 'deletethis'));
|
|
|
|
|
|
|
|
$sql = \OC::$server->getDatabaseConnection()->getQueryBuilder();
|
|
|
|
$sql->select('configvalue')
|
|
|
|
->from('appconfig')
|
|
|
|
->where($sql->expr()->eq('appid', $sql->createParameter('appid')))
|
|
|
|
->andWhere($sql->expr()->eq('configkey', $sql->createParameter('configkey')))
|
|
|
|
->setParameter('appid', 'testapp')
|
|
|
|
->setParameter('configkey', 'deletethis');
|
|
|
|
$query = $sql->execute();
|
|
|
|
$result = $query->fetch();
|
|
|
|
$query->closeCursor();
|
2015-05-11 10:22:23 +00:00
|
|
|
$this->assertFalse($result);
|
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testDeleteApp() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
|
|
|
|
$this->assertTrue($config->hasKey('someapp', 'otherkey'));
|
|
|
|
|
|
|
|
$config->deleteApp('someapp');
|
|
|
|
|
|
|
|
$this->assertFalse($config->hasKey('someapp', 'otherkey'));
|
|
|
|
|
|
|
|
$sql = \OC::$server->getDatabaseConnection()->getQueryBuilder();
|
|
|
|
$sql->select('configvalue')
|
|
|
|
->from('appconfig')
|
|
|
|
->where($sql->expr()->eq('appid', $sql->createParameter('appid')))
|
|
|
|
->setParameter('appid', 'someapp');
|
|
|
|
$query = $sql->execute();
|
|
|
|
$result = $query->fetch();
|
|
|
|
$query->closeCursor();
|
2015-05-11 10:22:23 +00:00
|
|
|
$this->assertFalse($result);
|
|
|
|
}
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
public function testGetValuesNotAllowed() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
2015-05-11 10:22:23 +00:00
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$this->assertFalse($config->getValues('testapp', 'enabled'));
|
|
|
|
|
|
|
|
$this->assertFalse($config->getValues(false, false));
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testGetValues() {
|
|
|
|
$config = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
|
|
|
|
$sql = \OC::$server->getDatabaseConnection()->getQueryBuilder();
|
|
|
|
$sql->select(['configkey', 'configvalue'])
|
|
|
|
->from('appconfig')
|
|
|
|
->where($sql->expr()->eq('appid', $sql->createParameter('appid')))
|
|
|
|
->setParameter('appid', 'testapp');
|
|
|
|
$query = $sql->execute();
|
|
|
|
$expected = [];
|
|
|
|
while ($row = $query->fetch()) {
|
2015-05-11 10:22:23 +00:00
|
|
|
$expected[$row['configkey']] = $row['configvalue'];
|
|
|
|
}
|
2015-09-02 16:56:17 +00:00
|
|
|
$query->closeCursor();
|
|
|
|
|
|
|
|
$values = $config->getValues('testapp', false);
|
2015-05-11 10:22:23 +00:00
|
|
|
$this->assertEquals($expected, $values);
|
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$sql = \OC::$server->getDatabaseConnection()->getQueryBuilder();
|
|
|
|
$sql->select(['appid', 'configvalue'])
|
|
|
|
->from('appconfig')
|
|
|
|
->where($sql->expr()->eq('configkey', $sql->createParameter('configkey')))
|
|
|
|
->setParameter('configkey', 'enabled');
|
|
|
|
$query = $sql->execute();
|
|
|
|
$expected = [];
|
|
|
|
while ($row = $query->fetch()) {
|
2015-05-11 10:22:23 +00:00
|
|
|
$expected[$row['appid']] = $row['configvalue'];
|
|
|
|
}
|
2015-09-02 16:56:17 +00:00
|
|
|
$query->closeCursor();
|
2015-05-11 10:22:23 +00:00
|
|
|
|
2015-09-02 16:56:17 +00:00
|
|
|
$values = $config->getValues(false, 'enabled');
|
|
|
|
$this->assertEquals($expected, $values);
|
2014-07-07 22:19:17 +00:00
|
|
|
}
|
2015-05-11 10:29:28 +00:00
|
|
|
|
2017-01-12 09:49:22 +00:00
|
|
|
public function testGetFilteredValues() {
|
|
|
|
/** @var \OC\AppConfig|\PHPUnit_Framework_MockObject_MockObject $config */
|
|
|
|
$config = $this->getMockBuilder(\OC\AppConfig::class)
|
|
|
|
->setConstructorArgs([\OC::$server->getDatabaseConnection()])
|
|
|
|
->setMethods(['getValues'])
|
|
|
|
->getMock();
|
|
|
|
|
|
|
|
$config->expects($this->once())
|
|
|
|
->method('getValues')
|
|
|
|
->with('user_ldap', false)
|
|
|
|
->willReturn([
|
|
|
|
'ldap_agent_password' => 'secret',
|
2019-07-26 11:31:14 +00:00
|
|
|
's42ldap_agent_password' => 'secret',
|
2017-01-12 09:49:22 +00:00
|
|
|
'ldap_dn' => 'dn',
|
|
|
|
]);
|
|
|
|
|
|
|
|
$values = $config->getFilteredValues('user_ldap');
|
|
|
|
$this->assertEquals([
|
|
|
|
'ldap_agent_password' => IConfig::SENSITIVE_VALUE,
|
2019-07-26 11:31:14 +00:00
|
|
|
's42ldap_agent_password' => IConfig::SENSITIVE_VALUE,
|
2017-01-12 09:49:22 +00:00
|
|
|
'ldap_dn' => 'dn',
|
|
|
|
], $values);
|
|
|
|
}
|
|
|
|
|
2015-05-11 10:29:28 +00:00
|
|
|
public function testSettingConfigParallel() {
|
2015-09-02 16:56:17 +00:00
|
|
|
$appConfig1 = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
|
|
|
$appConfig2 = new \OC\AppConfig(\OC::$server->getDatabaseConnection());
|
2015-05-11 10:29:28 +00:00
|
|
|
$appConfig1->getValue('testapp', 'foo', 'v1');
|
|
|
|
$appConfig2->getValue('testapp', 'foo', 'v1');
|
|
|
|
|
|
|
|
$appConfig1->setValue('testapp', 'foo', 'v1');
|
|
|
|
$this->assertConfigKey('testapp', 'foo', 'v1');
|
|
|
|
|
|
|
|
$appConfig2->setValue('testapp', 'foo', 'v2');
|
|
|
|
$this->assertConfigKey('testapp', 'foo', 'v2');
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @param string $app
|
|
|
|
* @param string $key
|
|
|
|
* @param string $expected
|
|
|
|
*/
|
|
|
|
protected function assertConfigKey($app, $key, $expected) {
|
2015-09-02 16:56:17 +00:00
|
|
|
$sql = \OC::$server->getDatabaseConnection()->getQueryBuilder();
|
|
|
|
$sql->select('configvalue')
|
|
|
|
->from('appconfig')
|
|
|
|
->where($sql->expr()->eq('appid', $sql->createParameter('appid')))
|
|
|
|
->andWhere($sql->expr()->eq('configkey', $sql->createParameter('configkey')))
|
|
|
|
->setParameter('appid', $app)
|
|
|
|
->setParameter('configkey', $key);
|
|
|
|
$query = $sql->execute();
|
|
|
|
$actual = $query->fetch();
|
|
|
|
$query->closeCursor();
|
|
|
|
|
2015-05-11 10:29:28 +00:00
|
|
|
$this->assertEquals($expected, $actual['configvalue']);
|
|
|
|
}
|
2013-08-02 09:46:47 +00:00
|
|
|
}
|