wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove duplicate call to groupExists

Browse source
This commit is contained in:
Robin Appelman 2014-02-14 14:25:45 +01:00
parent 4b603cd2f8
commit 0ba0596341
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/private/group/manager.php
View file

@ -76,13 +76,8 @@ class Manager extends PublicEmitter {
if (isset($this->cachedGroups[$gid])) { if (isset($this->cachedGroups[$gid])) {
return $this->cachedGroups[$gid]; return $this->cachedGroups[$gid];
} }
foreach ($this->backends as $backend) {
if ($backend->groupExists($gid)) {
return $this->getGroupObject($gid); return $this->getGroupObject($gid);
} }
}
return null;
}
protected function getGroupObject($gid) { protected function getGroupObject($gid) {
$backends = array(); $backends = array();
@ -91,6 +86,9 @@ class Manager extends PublicEmitter {
$backends[] = $backend; $backends[] = $backend;
} }
} }
if (count($backends) === 0) {
return null;
}
$this->cachedGroups[$gid] = new Group($gid, $backends, $this->userManager, $this); $this->cachedGroups[$gid] = new Group($gid, $backends, $this->userManager, $this);
return $this->cachedGroups[$gid]; return $this->cachedGroups[$gid];
} }