wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix 403 and 404 redirect

Browse source 
* Nextcloud is not properly loaded in the standalone version (especially the theming)
* it is already not listed anymore in the Nginx config (see nextcloud/documentation#392)
* the index.php-free version doesn't support this

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This commit is contained in:
Morris Jobke 2017-07-26 16:30:09 +02:00
parent 174cd4f478
commit 0de90cfc67
4 changed files with 10 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/templates/403.php
View file

@ -1,10 +1,10 @@
<?php
// @codeCoverageIgnoreStart
if(!isset($_)) {//also provide standalone error page
if(!isset($_)) {//standalone page is not supported anymore - redirect to /
require_once '../../lib/base.php';
$tmpl = new OC_Template( '', '403', 'guest' );
$tmpl->printPage();
$urlGenerator = \OC::$server->getURLGenerator();
header('Location: ' . $urlGenerator->getAbsoluteURL('/'));
exit;
}
// @codeCoverageIgnoreEnd

8
core/templates/404.php
View file

@ -3,11 +3,11 @@
/** @var $l \OCP\IL10N */
/** @var $theme OCP\Defaults */
// @codeCoverageIgnoreStart
if(!isset($_)) {//also provide standalone error page
if(!isset($_)) {//standalone page is not supported anymore - redirect to /
require_once '../../lib/base.php';
$tmpl = new OC_Template( '', '404', 'guest' );
$tmpl->printPage();
$urlGenerator = \OC::$server->getURLGenerator();
header('Location: ' . $urlGenerator->getAbsoluteURL('/'));
exit;
}
// @codeCoverageIgnoreEnd

4
lib/private/Setup.php
View file

@ -449,10 +449,10 @@ class Setup {
$htaccessContent = explode($content, $htaccessContent, 2)[0];
//custom 403 error page
$content.= "\nErrorDocument 403 ".$webRoot."/core/templates/403.php";
$content.= "\nErrorDocument 403 ".$webRoot."/";
//custom 404 error page
$content.= "\nErrorDocument 404 ".$webRoot."/core/templates/404.php";
$content.= "\nErrorDocument 404 ".$webRoot."/";
// Add rewrite rules if the RewriteBase is configured
$rewriteBase = $config->getValue('htaccess.RewriteBase', '');

20
tests/Core/Templates/TemplatesTest.php
View file

@ -1,20 +0,0 @@
<?php
namespace Tests\Core\Templates;
class TemplatesTest extends \Test\TestCase {
public function test403() {
$template = \OC::$SERVERROOT . '/core/templates/403.php';
$expectedHtml = "<ul><li class='error'>\n\t\tAccess forbidden<br><p class='hint'></p></li></ul>";
$this->assertTemplate($expectedHtml, $template);
}
public function test404() {
$template = \OC::$SERVERROOT . '/core/templates/404.php';
$href = \OC::$server->getURLGenerator()->linkTo('', 'index.php');
$expectedHtml = "<ul><li class='error'>\n\t\t\tFile not found<br><p class='hint'>The specified document has not been found on the server.</p>\n<p class='hint'><a href='$href'>You can click here to return to Nextcloud.</a></p>\n\t\t</li></ul>";
$this->assertTemplate($expectedHtml, $template);
}
}