wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

smaller changes related to reviews

Browse source
This commit is contained in:
Arthur Schiwon 2016-01-26 12:08:51 +01:00
parent ed546bd2a5
commit 11ae468c89
2 changed files with 17 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
apps/dav/lib/comments/commentnode.php
View file

@ -135,8 +135,7 @@ class CommentNode implements \Sabre\DAV\INode, \Sabre\DAV\IProperties {
* @return int
*/
function getLastModified() {
// we do not have a separate "mDateTime" field for updates currently.
return $this->comment->getCreationDateTime()->getTimestamp();
return null;
}
/**

43
apps/dav/lib/comments/commentsplugin.php
View file

@ -103,31 +103,25 @@ class CommentsPlugin extends ServerPlugin {
*/
public function httpPost(RequestInterface $request, ResponseInterface $response) {
$path = $request->getPath();
// Making sure the node exists
try {
$node = $this->server->tree->getNodeForPath($path);
} catch (NotFound $e) {
$node = $this->server->tree->getNodeForPath($path);
if (!$node instanceof EntityCollection) {
return null;
}
if ($node instanceof EntityCollection) {
$data = $request->getBodyAsString();
$data = $request->getBodyAsString();
$comment = $this->createComment(
$node->getName(),
$node->getId(),
$data,
$request->getHeader('Content-Type')
);
$url = $request->getUrl() . '/' . urlencode($comment->getId());
$comment = $this->createComment(
$node->getName(),
$node->getId(),
$data,
$request->getHeader('Content-Type')
);
$url = $request->getUrl() . '/' . urlencode($comment->getId());
$response->setHeader('Content-Location', $url);
$response->setHeader('Content-Location', $url);
// created
$response->setStatus(201);
return false;
}
// created
$response->setStatus(201);
return false;
}
/**
@ -224,13 +218,8 @@ class CommentsPlugin extends ServerPlugin {
try {
$comment = $this->commentsManager->create($actorType, $actorId, $objectType, $objectId);
$properties = [
'message' => 'setMessage',
'verb' => 'setVerb',
];
foreach($properties as $property => $setter) {
$comment->$setter($data[$property]);
}
$comment->setMessage($data['message']);
$comment->setVerb($data['verb']);
$this->commentsManager->save($comment);
return $comment;
} catch (\InvalidArgumentException $e) {