wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #19470 from nextcloud/backport/19465/stable18

Browse source 
[stable18] when we receive intentional empty whats new info, do not try to show it
This commit is contained in:
Joas Schilling 2020-02-17 12:40:28 +01:00 committed by GitHub
commit 1bc2b113ca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/private/Updater/ChangesCheck.php
View file

@ -55,7 +55,11 @@ class ChangesCheck {
public function getChangesForVersion(string $version): array { public function getChangesForVersion(string $version): array {
$version = $this->normalizeVersion($version); $version = $this->normalizeVersion($version);
$changesInfo = $this->mapper->getChanges($version); $changesInfo = $this->mapper->getChanges($version);
return json_decode($changesInfo->getData(), true); $changesData = json_decode($changesInfo->getData(), true);
if(empty($changesData)) {
throw new DoesNotExistException();
}
return $changesData;
} }
/** /**

4
tests/lib/Updater/ChangesCheckTest.php
View file

@ -279,6 +279,10 @@ class ChangesCheckTest extends TestCase {
], ],
] ]
], ],
[ # 4 - empty
'',
[]
],
]; ];
} }