Merge pull request #15158 from owncloud/fix-failing-master
Fix failing master unit tests
This commit is contained in:
commit
1bd141b655
2 changed files with 14 additions and 5 deletions
2
apps/files_sharing/lib/external/manager.php
vendored
2
apps/files_sharing/lib/external/manager.php
vendored
|
@ -368,7 +368,7 @@ class Manager {
|
|||
$query = 'SELECT * FROM `*PREFIX*share_external` WHERE `user` = ?';
|
||||
$parameters = [$this->uid];
|
||||
if (!is_null($accepted)) {
|
||||
$query .= 'AND `accepted` = ?';
|
||||
$query .= ' AND `accepted` = ?';
|
||||
$parameters[] = (int) $accepted;
|
||||
}
|
||||
$query .= ' ORDER BY `id` ASC';
|
||||
|
|
17
apps/files_sharing/tests/external/manager.php
vendored
17
apps/files_sharing/tests/external/manager.php
vendored
|
@ -21,7 +21,7 @@
|
|||
namespace OCA\Files_sharing\Tests\External;
|
||||
|
||||
use OC\Files\Storage\StorageFactory;
|
||||
use Test\TestCase;
|
||||
use OCA\Files_Sharing\Tests\TestCase;
|
||||
|
||||
class Manager extends TestCase {
|
||||
private $uid;
|
||||
|
@ -37,14 +37,23 @@ class Manager extends TestCase {
|
|||
private $instance;
|
||||
|
||||
public function setUp() {
|
||||
$this->uid = uniqid();
|
||||
parent::setUp();
|
||||
|
||||
$this->uid = $this->getUniqueID('user');
|
||||
|
||||
$this->mountManager = new \OC\Files\Mount\Manager();
|
||||
$this->instance = new \OCA\Files_Sharing\External\Manager(\OC::$server->getDatabaseConnection(),
|
||||
$this->mountManager, new StorageFactory(), \OC::$server->getHTTPHelper(), $this->uid);
|
||||
$this->instance = new \OCA\Files_Sharing\External\Manager(
|
||||
\OC::$server->getDatabaseConnection(),
|
||||
$this->mountManager,
|
||||
new StorageFactory(),
|
||||
$this->getMockBuilder('\OC\HTTPHelper')->disableOriginalConstructor()->getMock(),
|
||||
$this->uid
|
||||
);
|
||||
}
|
||||
|
||||
public function tearDown() {
|
||||
$this->instance->removeUserShares($this->uid);
|
||||
parent::tearDown();
|
||||
}
|
||||
|
||||
private function getFullPath($path) {
|
||||
|
|
Loading…
Reference in a new issue