wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Some more fixes in detecting the mimetype from the content

Browse source 
Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
Joas Schilling 2019-11-29 11:04:20 +01:00
parent 5c9f503146
commit 1dad2ddf39
No known key found for this signature in database
GPG key ID: 7076EA9751AACDDA
1 changed files with 25 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
lib/private/Files/Type/Detection.php
View file

@ -184,7 +184,7 @@ class Detection implements IMimeTypeDetector {
if (strpos($fileName, '.') > 0) { if (strpos($fileName, '.') > 0) {
// remove versioning extension: name.v1508946057 and transfer extension: name.ocTransferId2057600214.part // remove versioning extension: name.v1508946057 and transfer extension: name.ocTransferId2057600214.part
$fileName = preg_replace('!((\.v\d+)|((.ocTransferId\d+)?.part))$!', '', $fileName); $fileName = preg_replace('!((\.v\d+)|((\.ocTransferId\d+)?\.part))$!', '', $fileName);
//try to guess the type by the file extension //try to guess the type by the file extension
$extension = strtolower(strrchr($fileName, '.')); $extension = strtolower(strrchr($fileName, '.'));
@ -212,38 +212,46 @@ class Detection implements IMimeTypeDetector {
} }
if (function_exists('finfo_open') if (function_exists('finfo_open')
and function_exists('finfo_file') and $finfo = finfo_open(FILEINFO_MIME) && function_exists('finfo_file')
) { && $finfo = finfo_open(FILEINFO_MIME)) {
$info = @strtolower(finfo_file($finfo, $path)); $info = @finfo_file($finfo, $path);
finfo_close($finfo); finfo_close($finfo);
if ($info) { if ($info) {
$info = strtolower($info);
$mimeType = strpos($info, ';') !== false ? substr($info, 0, strpos($info, ';')) : $info; $mimeType = strpos($info, ';') !== false ? substr($info, 0, strpos($info, ';')) : $info;
return empty($mimeType) ? 'application/octet-stream' : $mimeType; return $this->getSecureMimeType($mimeType);
} }
} }
$isWrapped = (strpos($path, '://') !== false) and (substr($path, 0, 7) === 'file://');
if (!$isWrapped and function_exists("mime_content_type")) { if (strpos($path, '://') !== false && strpos($path, 'file://') === 0) {
// Is the file wrapped in a stream?
return 'application/octet-stream';
}
if (function_exists('mime_content_type')) {
// use mime magic extension if available // use mime magic extension if available
$mimeType = mime_content_type($path); $mimeType = mime_content_type($path);
if ($mimeType !== false) {
return $this->getSecureMimeType($mimeType);
}
} }
if (!$isWrapped and $mimeType === 'application/octet-stream' && \OC_Helper::canExecute("file")) {
if (\OC_Helper::canExecute('file')) {
// it looks like we have a 'file' command, // it looks like we have a 'file' command,
// lets see if it does have mime support // lets see if it does have mime support
$path = escapeshellarg($path); $path = escapeshellarg($path);
$fp = popen("file -b --mime-type $path 2>/dev/null", "r"); $fp = popen("test -f $path && file -b --mime-type $path", 'r');
$reply = fgets($fp); $mimeType = fgets($fp);
pclose($fp); pclose($fp);
//trim the newline if ($mimeType !== false) {
$mimeType = trim($reply); //trim the newline
$mimeType = trim($mimeType);
if (empty($mimeType)) { return $this->getSecureMimeType($mimeType);
$mimeType = 'application/octet-stream';
} }
} }
return $mimeType; return 'application/octet-stream';
} }
/** /**