wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

improve PHP doc and remove superflous by reference indicator

Browse source
This commit is contained in:
Arthur Schiwon 2015-12-08 14:58:18 +01:00
parent dec1f1d24a
commit 249dc4490f
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/private/comments/manager.php
View file

@ -51,7 +51,8 @@ class Manager implements ICommentsManager {
* all necessary fields have a value assigned.
*
* @param IComment $comment
* @return IComment
* @return IComment returns the same updated IComment instance as provided
* by parameter for convenience
* @throws \UnexpectedValueException
*/
protected function prepareCommentForDatabaseWrite(IComment $comment) {
@ -406,14 +407,13 @@ class Manager implements ICommentsManager {
* Throws NotFoundException when a comment that is to be updated does not
* exist anymore at this point of time.
*
* @param IComment &$comment
* @param IComment $comment
* @return bool
* @throws NotFoundException
* @since 9.0.0
*/
public function save(IComment &$comment) {
$comment = $this->prepareCommentForDatabaseWrite($comment);
if($comment->getId() === '') {
public function save(IComment $comment) {
if($this->prepareCommentForDatabaseWrite($comment)->getId() === '') {
$result = $this->insert($comment);
} else {
$result = $this->update($comment);

4
lib/public/comments/icommentsmanager.php
View file

@ -139,12 +139,12 @@ interface ICommentsManager {
* Throws NotFoundException when a comment that is to be updated does not
* exist anymore at this point of time.
*
* @param IComment &$comment
* @param IComment $comment
* @return bool
* @throws NotFoundException
* @since 9.0.0
*/
public function save(IComment &$comment);
public function save(IComment $comment);
/**
* removes references to specific actor (e.g. on user delete) of a comment.