From 32fe3a7d5ede8f37f2727603353d8c8317a5c217 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Wed, 23 Dec 2015 17:13:41 +0100 Subject: [PATCH 1/3] remove mention of 'filesystem_check_changes' => 2 from the config sample --- config/config.sample.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/config/config.sample.php b/config/config.sample.php index 6e052d7040..3208a25514 100644 --- a/config/config.sample.php +++ b/config/config.sample.php @@ -1063,9 +1063,6 @@ $CONFIG = array( * * 1 -> Check each file or folder at most once per request, recommended for * general use if outside changes might happen. - * - * 2 -> Check every time the filesystem is used, causes a performance hit when - * using external storages, not recommended for regular use. */ 'filesystem_check_changes' => 0, From dbafec0c28187f38150a1a8ae351247d9a797d58 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Wed, 23 Dec 2015 17:23:56 +0100 Subject: [PATCH 2/3] Also remove it from the web interface --- apps/files_external/js/settings.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/apps/files_external/js/settings.js b/apps/files_external/js/settings.js index 134db41fc3..59cf55d6ad 100644 --- a/apps/files_external/js/settings.js +++ b/apps/files_external/js/settings.js @@ -27,7 +27,6 @@ var MOUNT_OPTIONS_DROPDOWN_TEMPLATE = ' ' + ' ' + ''; @@ -39,7 +38,6 @@ var MOUNT_OPTIONS_DROPDOWN_TEMPLATE = t("files_external", "Check for changes") t("files_external", "Never") t("files_external", "Once every direct access") - t("files_external", "Every time the filesystem is used") */ /** From 06708cc1725c46ba615042bcd5de169d944b2e46 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Wed, 6 Jan 2016 20:06:04 +0100 Subject: [PATCH 3/3] fix js unit tests --- apps/files_external/tests/js/settingsSpec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/files_external/tests/js/settingsSpec.js b/apps/files_external/tests/js/settingsSpec.js index 3d0168898c..b6372649fb 100644 --- a/apps/files_external/tests/js/settingsSpec.js +++ b/apps/files_external/tests/js/settingsSpec.js @@ -254,13 +254,13 @@ describe('OCA.External.Settings tests', function() { // defaults to true var $field = $td.find('.dropdown [name=previews]'); expect($field.prop('checked')).toEqual(true); - $td.find('.dropdown [name=filesystem_check_changes]').val(2); + $td.find('.dropdown [name=filesystem_check_changes]').val(0); $('body').mouseup(); expect(JSON.parse($tr.find('input.mountOptions').val())).toEqual({ encrypt: true, previews: true, - filesystem_check_changes: 2 + filesystem_check_changes: 0 }); }); });