From 318682dd6dc81de2135af0f6bb609be1064467ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Tue, 7 Aug 2018 17:41:01 +0200
Subject: [PATCH] Fix security settings if password change is disabled
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 settings/templates/settings/personal/security.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/settings/templates/settings/personal/security.php b/settings/templates/settings/personal/security.php
index e0de11de60..253f20c0a2 100644
--- a/settings/templates/settings/personal/security.php
+++ b/settings/templates/settings/personal/security.php
@@ -22,7 +22,6 @@
  */
 
 script('settings', [
-	'security_password',
 	'authtoken',
 	'authtoken_collection',
 	'authtoken_view',
@@ -30,18 +29,18 @@ script('settings', [
 ]);
 
 if($_['passwordChangeSupported']) {
+	script('settings', 'security_password');
 	script('jquery-showpassword');
 	vendor_script('strengthify/jquery.strengthify');
 	vendor_style('strengthify/strengthify');
 }
 
 ?>
-
+<?php if($_['passwordChangeSupported']) { ?>
 <div id="security-password" class="section">
 	<h2 class="inlineblock"><?php p($l->t('Password'));?></h2>
 	<span id="password-error-msg" class="msg success hidden">Saved</span>
 	<div class="personal-settings-setting-box personal-settings-password-box">
-		<?php if($_['passwordChangeSupported']) { ?>
 			<form id="passwordform">
 				<label for="pass1" class="hidden-visually"><?php p($l->t('Current password')); ?>: </label>
 				<input type="password" id="pass1" name="oldpassword"
@@ -60,12 +59,10 @@ if($_['passwordChangeSupported']) {
 				<input id="passwordbutton" type="submit" value="<?php p($l->t('Change password')); ?>" />
 
 			</form>
-			<?php
-		}
-		?>
 	</div>
 	<span class="msg"></span>
 </div>
+<?php } ?>
 
 <div id="security" class="section">
 	<h2><?php p($l->t('Devices & sessions'));?></h2>