wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Theming: Generate favicon sizes to avoid resizing issues done by the browser

Browse source 
fixes #5193

Signed-off-by: Julius Haertl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl 2017-09-12 12:05:03 +02:00
parent 8e61ad8847
commit 31b9fc9eac
No known key found for this signature in database
GPG key ID: 4C614C6ED2CDE6DF
2 changed files with 26 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
apps/theming/lib/IconBuilder.php
View file

@ -56,13 +56,34 @@ class IconBuilder {
*/
public function getFavicon($app) {
try {
$icon = $this->renderAppIcon($app, 32);
$favicon = new Imagick();
$favicon->setFormat("ico");
$icon = $this->renderAppIcon($app, 128);
if ($icon === false) {
return false;
}
$icon->setImageFormat("png32");
$data = $icon->getImageBlob();
$clone = clone $icon;
$clone->scaleImage(16,0);
$favicon->addImage($clone);
$clone = clone $icon;
$clone->scaleImage(32,0);
$favicon->addImage($clone);
$clone = clone $icon;
$clone->scaleImage(64,0);
$favicon->addImage($clone);
$clone = clone $icon;
$clone->scaleImage(128,0);
$favicon->addImage($clone);
$data = $favicon->getImagesBlob();
$favicon->destroy();
$icon->destroy();
$clone->destroy();
return $data;
} catch (\ImagickException $e) {
return false;

3
apps/theming/tests/IconBuilderTest.php
View file

@ -71,6 +71,9 @@ class IconBuilderTest extends TestCase {
if (count($checkImagick->queryFormats('SVG')) < 1) {
$this->markTestSkipped('No SVG provider present.');
}
if (count($checkImagick->queryFormats('PNG')) < 1) {
$this->markTestSkipped('No PNG provider present.');
}
}
public function dataRenderAppIcon() {