From 39f44e1452c67b1b3da5a85c89d3fc3856d19ab8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Wed, 28 Mar 2018 12:24:32 +0200 Subject: [PATCH] Add typehints MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- apps/theming/lib/Controller/ThemingController.php | 1 - apps/theming/lib/ImageManager.php | 5 +++-- apps/theming/lib/ThemingDefaults.php | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php index fc282f2088..2f0bfdd05c 100644 --- a/apps/theming/lib/Controller/ThemingController.php +++ b/apps/theming/lib/Controller/ThemingController.php @@ -135,7 +135,6 @@ class ThemingController extends Controller { * @param string $setting * @param string $value * @return DataResponse - * @throws NotFoundException * @throws NotPermittedException */ public function updateStylesheet($setting, $value) { diff --git a/apps/theming/lib/ImageManager.php b/apps/theming/lib/ImageManager.php index 06cc37a3d1..d268552bf9 100644 --- a/apps/theming/lib/ImageManager.php +++ b/apps/theming/lib/ImageManager.php @@ -25,6 +25,7 @@ namespace OCA\Theming; use OCP\Files\SimpleFS\ISimpleFile; +use OCP\Files\SimpleFS\ISimpleFolder; use OCP\IConfig; use OCP\Files\IAppData; use OCP\Files\NotFoundException; @@ -132,7 +133,7 @@ class ImageManager { * @return \OCP\Files\SimpleFS\ISimpleFile * @throws NotPermittedException */ - public function getCachedImage($filename): ISimpleFile { + public function getCachedImage(string $filename): ISimpleFile { $currentFolder = $this->getCacheFolder(); return $currentFolder->getFile($filename); } @@ -146,7 +147,7 @@ class ImageManager { * @throws NotFoundException * @throws NotPermittedException */ - public function setCachedImage($filename, $data): ISimpleFile { + public function setCachedImage(string $filename, string $data): ISimpleFile { $currentFolder = $this->getCacheFolder(); if ($currentFolder->fileExists($filename)) { $file = $currentFolder->getFile($filename); diff --git a/apps/theming/lib/ThemingDefaults.php b/apps/theming/lib/ThemingDefaults.php index 4957b5ef3c..03d5a3f061 100644 --- a/apps/theming/lib/ThemingDefaults.php +++ b/apps/theming/lib/ThemingDefaults.php @@ -36,6 +36,7 @@ namespace OCA\Theming; use OCP\App\AppPathNotFoundException; use OCP\App\IAppManager; +use OCP\Files\NotFoundException; use OCP\ICacheFactory; use OCP\IConfig; use OCP\IL10N;