wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix usage of empty

Browse source
This commit is contained in:
Arthur Schiwon 2015-12-03 17:13:18 +01:00
parent e3dbc3d40c
commit 4273689e9f
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/private/comments/manager.php
View file

@ -55,11 +55,11 @@ class Manager implements ICommentsManager {
* @throws \UnexpectedValueException
*/
protected function prepareCommentForDatabaseWrite(IComment $comment) {
if( empty($comment->getActorType())
|| empty($comment->getActorId())
|| empty($comment->getObjectType())
|| empty($comment->getObjectId())
|| empty($comment->getVerb())
if( !$comment->getActorType()
|| !$comment->getActorId()
|| !$comment->getObjectType()
|| !$comment->getObjectId()
|| !$comment->getVerb()
) {
throw new \UnexpectedValueException('Actor, Object and Verb information must be provided for saving');
}
@ -430,7 +430,7 @@ class Manager implements ICommentsManager {
$result = $this->update($comment);
}
if($result && !empty($comment->getParentId())) {
if($result && !!$comment->getParentId()) {
$this->updateChildrenInformation(
$comment->getParentId(),
$comment->getCreationDateTime()