wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move OC_Helper code to OCP\Util for linkToRemote

Browse source
This commit is contained in:
Morris Jobke 2015-12-18 12:00:18 +01:00
parent e42f262d85
commit 450e2f3bd3
3 changed files with 5 additions and 59 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
lib/private/helper.php
View file

@ -53,32 +53,6 @@ use Symfony\Component\Process\ExecutableFinder;
class OC_Helper {
private static $templateManager;
/**
* Creates an url for remote use
* @param string $service id
* @return string the url
*
* Returns a url to the given service.
*/
public static function linkToRemoteBase($service) {
return OC::$server->getURLGenerator()->linkTo('', 'remote.php') . '/' . $service;
}
/**
* Creates an absolute url for remote use
* @param string $service id
* @param bool $add_slash
* @return string the url
*
* Returns a absolute url to the given service.
*/
public static function linkToRemote($service, $add_slash = true) {
return OC::$server->getURLGenerator()->getAbsoluteURL(
self::linkToRemoteBase($service)
. (($add_slash && $service[strlen($service) - 1] != '/') ? '/' : '')
);
}
/**
* Creates an absolute url for public use
* @param string $service id

6
lib/public/util.php
View file

@ -282,7 +282,11 @@ class Util {
* @since 4.0.0
*/
public static function linkToRemote( $service ) {
return(\OC_Helper::linkToRemote( $service ));
$urlGenerator = \OC::$server->getURLGenerator();
$remoteBase = $urlGenerator->linkTo('', 'remote.php') . '/' . $service;
return $urlGenerator->getAbsoluteURL(
$remoteBase . (($service[strlen($service) - 1] != '/') ? '/' : '')
);
}
/**

32
tests/lib/helper.php
View file

@ -243,38 +243,6 @@ class Test_Helper extends \Test\TestCase {
// Url generator methods
/**
* @small
* test linkToRemoteBase URL construction
*/
public function testLinkToRemoteBase() {
\OC::$WEBROOT = '';
$result = \OC_Helper::linkToRemoteBase('webdav');
$this->assertEquals('/remote.php/webdav', $result);
\OC::$WEBROOT = '/owncloud';
$result = \OC_Helper::linkToRemoteBase('webdav');
$this->assertEquals('/owncloud/remote.php/webdav', $result);
}
/**
* @small
* test linkToRemote URL construction
*/
public function testLinkToRemote() {
\OC::$WEBROOT = '';
$result = \OC_Helper::linkToRemote('webdav');
$this->assertEquals('http://localhost/remote.php/webdav/', $result);
$result = \OC_Helper::linkToRemote('webdav', false);
$this->assertEquals('http://localhost/remote.php/webdav', $result);
\OC::$WEBROOT = '/owncloud';
$result = \OC_Helper::linkToRemote('webdav');
$this->assertEquals('http://localhost/owncloud/remote.php/webdav/', $result);
$result = \OC_Helper::linkToRemote('webdav', false);
$this->assertEquals('http://localhost/owncloud/remote.php/webdav', $result);
}
/**
* @small
* test linkToPublic URL construction