wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove OC_Util::getUrlContent and replace by proper usage of public interfaces

Browse source
This commit is contained in:
Morris Jobke 2015-12-04 18:02:47 +01:00
parent e91eba4b5b
commit 4548a0aa90
2 changed files with 12 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/private/apphelper.php
View file

@ -36,6 +36,12 @@ class AppHelper implements \OCP\IHelper {
* @deprecated 8.1.0 Use \OCP\IServerContainer::getHTTPClientService
*/
public function getUrlContent($url) {
return \OC_Util::getUrlContent($url);
try {
$client = \OC::$server->getHTTPClientService()->newClient();
$response = $client->get($url);
return $response->getBody();
} catch (\Exception $e) {
return false;
}
}
}

23
lib/private/util.php
View file

@ -1237,7 +1237,11 @@ class OC_Util {
// accessing the file via http
$url = OC_Helper::makeURLAbsolute(OC::$WEBROOT . '/data' . $fileName);
$content = self::getUrlContent($url);
try {
$content = \OC::$server->getHTTPClientService()->newClient()->get($url)->getBody();
} catch (\Exception $e) {
$content = false;
}
// cleanup
@unlink($testFile);
@ -1312,23 +1316,6 @@ class OC_Util {
return \OC::$server->getSecureRandom()->getMediumStrengthGenerator()->generate($length, \OCP\Security\ISecureRandom::CHAR_LOWER.\OCP\Security\ISecureRandom::CHAR_DIGITS);
}
/**
* Get URL content
* @param string $url Url to get content
* @throws Exception If the URL does not start with http:// or https://
* @return string of the response or false on error
* This function get the content of a page via curl, if curl is enabled.
* If not, file_get_contents is used.
* @deprecated Use \OC::$server->getHTTPClientService()->newClient()->get($url);
*/
public static function getUrlContent($url) {
try {
return \OC::$server->getHTTPHelper()->getUrlContent($url);
} catch (\Exception $e) {
throw $e;
}
}
/**
* Checks whether the server is running on Windows
*