wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #15123 from nextcloud/fix/share-link-pwd-error-feedback

Browse source 
Improve the share link password error feedback with a red border
This commit is contained in:
Morris Jobke 2019-04-16 13:52:19 +02:00 committed by GitHub
commit 4c43e89dfd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
apps/files_sharing/js/dist/additionalScripts.js vendored
View file

Binary file not shown.

BIN
apps/files_sharing/js/dist/additionalScripts.js.map vendored
View file

Binary file not shown.

6
apps/files_sharing/src/style/sharetabview.scss
View file

@ -73,6 +73,12 @@
}
.popovermenu {
.linkPassMenu {
input.error {
border-color: var(--color-error) !important;
&[type="submit"] {
border-left: none;
}
}
.share-pass-submit {
width: auto !important;
}

BIN
core/js/dist/share_backend.js vendored
View file

Binary file not shown.

BIN
core/js/dist/share_backend.js.map vendored
View file

Binary file not shown.

4
core/js/sharedialoglinkshareview.js
View file

@ -352,6 +352,7 @@
}
var $input = $li.find('.linkPassText');
$input.removeClass('error');
$input.parent().find('input').removeClass('error');
var password = $input.val();
if ($li.find('.linkPassText').attr('placeholder') === PASSWORD_PLACEHOLDER_MESSAGE_OPTIONAL) {
@ -380,6 +381,9 @@
$loading.removeClass('inlineblock').addClass('hidden');
},
error: function(model, msg) {
// Add visual feedback to both the input and the submit button
$input.parent().find('input').addClass('error');
// destroy old tooltips
var $container = $input.parent();
$container.tooltip('destroy');