wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replaced urlencode() and urldecode() with htmlspecialchars() and htmlspecialchars_decode()

Browse source
This commit is contained in:
Tom Needham 2011-09-28 20:26:30 +01:00
parent 2ca74dc334
commit 4fe993a55d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
apps/editor/ajax/savefile.php
View file

@ -28,7 +28,7 @@ require_once('../../../lib/base.php');
OC_JSON::checkLoggedIn();
// Save the file data
$filecontents = $_POST['filecontents'];
$filecontents = htmlspecialchars_decode($_POST['filecontents']);
$file = $_POST['file'];
$dir = $_POST['dir'];
$path = $dir.'/'.$file;
@ -37,7 +37,7 @@ $sessionname = md5('oc_file_hash_'.$path);
function do_save($path,$filecontents){
$sessionname = md5('oc_file_hash_'.$path);
OC_Filesystem::update_session_file_hash($sessionname,md5(urlencode($filecontents)));
OC_Filesystem::update_session_file_hash($sessionname,md5(htmlspecialchars($filecontents)));
OC_Filesystem::file_put_contents($path, $filecontents);
}
@ -45,7 +45,7 @@ function do_save($path,$filecontents){
if(isset($_SESSION[$sessionname])){
if(!empty($_SESSION[$sessionname])){
// Compare to current hash of file.
$savedfilecontents = urlencode(OC_Filesystem::file_get_contents($path));
$savedfilecontents = htmlspecialchars(OC_Filesystem::file_get_contents($path));
$hash = md5($savedfilecontents);
$originalhash = $_SESSION[$sessionname];
// Compare with hash taken when file was opened