wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use cached app list

Browse source 
Followup to #7264

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This commit is contained in:
Morris Jobke 2017-12-14 09:50:17 +01:00
parent ce12763ab7
commit 54c227b6c4
No known key found for this signature in database
GPG key ID: FE03C3A163FEDE68
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/private/Installer.php
View file

@ -396,10 +396,10 @@ class Installer {
} }
if ($this->apps === null) { if ($this->apps === null) {
$apps = $this->appFetcher->get(); $this->apps = $this->appFetcher->get();
} }
foreach($apps as $app) { foreach($this->apps as $app) {
if($app['id'] === $appId) { if($app['id'] === $appId) {
$currentVersion = OC_App::getAppVersion($appId); $currentVersion = OC_App::getAppVersion($appId);
$newestVersion = $app['releases'][0]['version']; $newestVersion = $app['releases'][0]['version'];

1
tests/lib/InstallerTest.php
View file

@ -156,6 +156,7 @@ class InstallerTest extends TestCase {
$installer = $this->getInstaller(); $installer = $this->getInstaller();
$this->assertSame($updateAvailable, $installer->isUpdateAvailable('files')); $this->assertSame($updateAvailable, $installer->isUpdateAvailable('files'));
$this->assertSame($updateAvailable, $installer->isUpdateAvailable('files'), 'Cached result should be returned and fetcher should be only called once');
} }
/** /**