Add visibility to test methods
This commit is contained in:
parent
fb0fef78f4
commit
594f5b6a29
1 changed files with 11 additions and 11 deletions
|
@ -65,7 +65,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
parent::tearDown();
|
||||
}
|
||||
|
||||
function testUnshareFromSelf() {
|
||||
public function testUnshareFromSelf() {
|
||||
|
||||
\OC_Group::createGroup('testGroup');
|
||||
\OC_Group::addToGroup(self::TEST_FILES_SHARING_API_USER2, 'testGroup');
|
||||
|
@ -103,7 +103,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
/**
|
||||
* if a file was shared as group share and as individual share they should be grouped
|
||||
*/
|
||||
function testGroupingOfShares() {
|
||||
public function testGroupingOfShares() {
|
||||
|
||||
$fileinfo = $this->view->getFileInfo($this->filename);
|
||||
|
||||
|
@ -171,7 +171,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
* single user share to user2. If he re-shares the file to user2 the same target
|
||||
* then the group share should be used to group the item
|
||||
*/
|
||||
function testShareAndUnshareFromSelf() {
|
||||
public function testShareAndUnshareFromSelf() {
|
||||
$fileinfo = $this->view->getFileInfo($this->filename);
|
||||
|
||||
// share the file to group1 (user2 is a member of this group) and explicitely to user2
|
||||
|
@ -217,7 +217,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
|
||||
}
|
||||
|
||||
function verifyDirContent($content, $expected) {
|
||||
public function verifyDirContent($content, $expected) {
|
||||
foreach ($content as $c) {
|
||||
if (!in_array($c['name'], $expected)) {
|
||||
$this->assertTrue(false, "folder should only contain '" . implode(',', $expected) . "', found: " .$c['name']);
|
||||
|
@ -225,7 +225,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
}
|
||||
}
|
||||
|
||||
function testShareWithDifferentShareFolder() {
|
||||
public function testShareWithDifferentShareFolder() {
|
||||
|
||||
$fileinfo = $this->view->getFileInfo($this->filename);
|
||||
$folderinfo = $this->view->getFileInfo($this->folder);
|
||||
|
@ -249,7 +249,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
\OC::$server->getConfig()->deleteSystemValue('share_folder');
|
||||
}
|
||||
|
||||
function testShareWithGroupUniqueName() {
|
||||
public function testShareWithGroupUniqueName() {
|
||||
$this->loginHelper(self::TEST_FILES_SHARING_API_USER1);
|
||||
\OC\Files\Filesystem::file_put_contents('test.txt', 'test');
|
||||
|
||||
|
@ -283,9 +283,9 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
|
||||
/**
|
||||
* shared files should never have delete permissions
|
||||
* @dataProvider DataProviderTestFileSharePermissions
|
||||
* @dataProvider dataProviderTestFileSharePermissions
|
||||
*/
|
||||
function testFileSharePermissions($permission, $expectedPermissions) {
|
||||
public function testFileSharePermissions($permission, $expectedPermissions) {
|
||||
|
||||
$fileinfo = $this->view->getFileInfo($this->filename);
|
||||
|
||||
|
@ -305,7 +305,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
$this->assertSame($expectedPermissions, $share['permissions']);
|
||||
}
|
||||
|
||||
function DataProviderTestFileSharePermissions() {
|
||||
public function dataProviderTestFileSharePermissions() {
|
||||
$permission1 = \OCP\Constants::PERMISSION_ALL;
|
||||
$permission3 = \OCP\Constants::PERMISSION_READ;
|
||||
$permission4 = \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_UPDATE;
|
||||
|
@ -329,7 +329,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
* @param bool $includePaths whether to include paths in the result
|
||||
* @param array $expectedResult expected result of the API call
|
||||
*/
|
||||
function testGetUsersSharingFile($groupName, $includeOwner, $includePaths, $expectedResult) {
|
||||
public function testGetUsersSharingFile($groupName, $includeOwner, $includePaths, $expectedResult) {
|
||||
|
||||
$fileinfo = $this->view->getFileInfo($this->folder);
|
||||
|
||||
|
@ -368,7 +368,7 @@ class Test_Files_Sharing extends OCA\Files_sharing\Tests\TestCase {
|
|||
);
|
||||
}
|
||||
|
||||
function dataProviderGetUsersSharingFile() {
|
||||
public function dataProviderGetUsersSharingFile() {
|
||||
// note: "group" contains user1 (the owner), user2 and user3
|
||||
// and self::TEST_FILES_SHARING_API_GROUP1 contains only user2
|
||||
return [
|
||||
|
|
Loading…
Reference in a new issue