wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use / if installed in main folder

Browse source 
Otherwise an empty string is used indicating the cookie is only valid for those resources. This can lead to eunexpected behaviour.

Fixes https://github.com/owncloud/core/issues/19196
This commit is contained in:
Lukas Reschke 2015-10-06 15:24:19 +02:00
parent 191f1b2d49
commit 6a4f22c61f
3 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/private/appframework/dependencyinjection/dicontainer.php
View file

@ -79,7 +79,7 @@ class DIContainer extends SimpleContainer implements IAppContainer {
});
$this->registerService('OCP\\AppFramework\\Http\\IOutput', function($c){
return new Output();
return new Output($this->getServer()->getWebRoot());
});
$this->registerService('OCP\\IAvatarManager', function($c) {

16
lib/private/appframework/http/output.php
View file

@ -27,6 +27,15 @@ use OCP\AppFramework\Http\IOutput;
* Very thin wrapper class to make output testable
*/
class Output implements IOutput {
/** @var string */
private $webRoot;
/**
* @param $webRoot
*/
public function __construct($webRoot) {
$this->webRoot = $webRoot;
}
/**
* @param string $out
@ -72,10 +81,11 @@ class Output implements IOutput {
* @param string $path
* @param string $domain
* @param bool $secure
* @param bool $httponly
* @param bool $httpOnly
*/
public function setCookie($name, $value, $expire, $path, $domain, $secure, $httponly) {
setcookie($name, $value, $expire, $path, $domain, $secure, $httponly);
public function setCookie($name, $value, $expire, $path, $domain, $secure, $httpOnly) {
$path = $this->webRoot ? : '/';
setcookie($name, $value, $expire, $path, $domain, $secure, $httpOnly);
}
}

4
lib/public/appframework/http/ioutput.php
View file

@ -68,9 +68,9 @@ interface IOutput {
* @param string $path
* @param string $domain
* @param bool $secure
* @param bool $httponly
* @param bool $httpOnly
* @since 8.1.0
*/
public function setCookie($name, $value, $expire, $path, $domain, $secure, $httponly);
public function setCookie($name, $value, $expire, $path, $domain, $secure, $httpOnly);
}