From 6f4ed59883c7cda899ccb49e60e34a8529ffbd18 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Wed, 17 Dec 2014 14:12:13 +0100
Subject: [PATCH] use method to only visually hide elements, show only for
 screen reader

---
 apps/files/js/fileactions.js           |  2 +-
 apps/files/js/filelist.js              |  2 +-
 apps/files/templates/appnavigation.php |  2 +-
 apps/files/templates/list.php          |  2 +-
 core/css/styles.css                    | 13 ++++++++++++-
 5 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/apps/files/js/fileactions.js b/apps/files/js/fileactions.js
index e981ac625b..875857745b 100644
--- a/apps/files/js/fileactions.js
+++ b/apps/files/js/fileactions.js
@@ -290,7 +290,7 @@
 			var $actionLink = $('<a href="#" original-title="' +
 				escapeHTML(deleteTitle) +
 				'" class="action delete icon-delete">' +
-				'<span class="hidden">' + escapeHTML(deleteTitle) + '</span>' +
+				'<span class="hidden-visually">' + escapeHTML(deleteTitle) + '</span>' +
 				'</a>'
 			);
 			var $container = context.$file.find('td:last');
diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js
index 90d30507f4..d8b8916752 100644
--- a/apps/files/js/filelist.js
+++ b/apps/files/js/filelist.js
@@ -710,7 +710,7 @@
 					'<input id="select-' + this.id + '-' + fileData.id +
 					'" type="checkbox" class="selectCheckBox"/><label for="select-' + this.id + '-' + fileData.id + '">' +
 					'<div class="thumbnail" style="background-image:url(' + icon + '); background-size: 32px;"></div>' +
-					'<span class="hidden">' + t('files', 'Select') + '</span>' +
+					'<span class="hidden-visually">' + t('files', 'Select') + '</span>' +
 					'</label>'
 				);
 			} else {
diff --git a/apps/files/templates/appnavigation.php b/apps/files/templates/appnavigation.php
index aa2deea78e..faf2be39b0 100644
--- a/apps/files/templates/appnavigation.php
+++ b/apps/files/templates/appnavigation.php
@@ -7,7 +7,7 @@
 	<div id="app-settings">
 		<div id="app-settings-header">
 			<button class="settings-button" data-apps-slide-toggle="#app-settings-content">
-				<span class="hidden"><?php p($l->t('Settings'));?></span>
+				<span class="hidden-visually"><?php p($l->t('Settings'));?></span>
 			</button>
 		</div>
 		<div id="app-settings-content">
diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php
index bd27be8c5e..a90ababf2b 100644
--- a/apps/files/templates/list.php
+++ b/apps/files/templates/list.php
@@ -59,7 +59,7 @@
 				<div id="headerName-container">
 					<input type="checkbox" id="select_all_files" class="select-all"/>
 					<label for="select_all_files">
-						<span class="hidden"><?php p($l->t('Select all'))?></span>
+						<span class="hidden-visually"><?php p($l->t('Select all'))?></span>
 					</label>
 					<a class="name sort columntitle" data-sort="name"><span><?php p($l->t( 'Name' )); ?></span><span class="sort-indicator"></span></a>
 					<span id="selectedActionsList" class="selectedActions">
diff --git a/core/css/styles.css b/core/css/styles.css
index 7badfca6c1..856ba68def 100644
--- a/core/css/styles.css
+++ b/core/css/styles.css
@@ -711,7 +711,18 @@ label.infield {
 
 
 /* VARIOUS REUSABLE SELECTORS */
-.hidden { display:none; }
+.hidden {
+	display: none;
+}
+.hidden-visually {
+	position: absolute;
+	left:-10000px;
+	top: auto;
+	width: 1px;
+	height: 1px;
+	overflow: hidden;
+}
+
 .bold { font-weight:bold; }
 .center { text-align:center; }
 .inlineblock { display: inline-block; }