From 527d237289f19ffe0616f4061b9067ce415865df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Sat, 15 Sep 2018 18:42:52 +0200 Subject: [PATCH 1/2] Fix contacts menu not triggered on certain areas of a mention MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The contacts menu was triggered only when the avatar or the name of the user were clicked. Due to this, clicking on certain (small) areas of a mention (like the right end, or the space between the avatar and the name) did not show the contacts menu. Now the contacts menu is shown when any area of the mention is clicked. Signed-off-by: Daniel Calviño Sánchez --- apps/comments/js/commentstabview.js | Bin 24281 -> 24224 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/apps/comments/js/commentstabview.js b/apps/comments/js/commentstabview.js index 3c428fe86a62e01efbae57b7935a41b8da872d3b..28382c8b67e67d6c3e6d50872f03a8941e60d08c 100644 GIT binary patch delta 162 zcmcb)mvO;f#tj?ICkqA0PBsWo4^1pfEJ-Xlr88AM7i1*lC!9V7@+1yYomrl0{u7g=(-AC&cjN{JfIH dg7TAW&xmzbN1q$&kyhlV;#LLF*k zW}1QqOiV%1cJd5kNjFXvz1-BI^i&OqyL1#Fj?&ai&d)1JOfD(*P0cHXO6nnuRoB!} XFwlWJaB`rb#N^o#oSWBKd{PAf{zg$f From 9cb8b51d4238f15cc61860f7ac68f97128d87d55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Sat, 15 Sep 2018 19:53:06 +0200 Subject: [PATCH 2/2] Fix position of contacts menu shown on mentions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are no default CSS rules for the contacts menu, as its position depends on the element on which it is shown. Note, however, that if no explicit rules are provided the contacts menu on mentions is affected by the rules for the contacts menu on shares from the sharing tab. The contacts menu is now positioned to show the tip of the arrow horizontally aligned with the center of the avatar, and with the top of the menu slightly below the bottom border of the mention. Signed-off-by: Daniel Calviño Sánchez --- apps/comments/css/comments.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/apps/comments/css/comments.scss b/apps/comments/css/comments.scss index e3e5a21032..196846ab07 100644 --- a/apps/comments/css/comments.scss +++ b/apps/comments/css/comments.scss @@ -251,3 +251,8 @@ .app-files .action-comment { padding: 16px 14px; } + +#commentsTabView .comment .message .contactsmenu-popover { + left: -6px; + top: 24px; +}