wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle session initialization errors and display error page - fixes #15053

Browse source
This commit is contained in:
Thomas Müller 2015-03-20 12:21:03 +01:00
parent a87cc90d1e
commit 843fef0490
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/base.php
View file

@ -415,6 +415,7 @@ class OC {
}
// if session cant be started break with http 500 error
} catch (Exception $e) {
\OCP\Util::logException('base', $e);
//show the user a detailed error page
OC_Response::setStatus(OC_Response::STATUS_INTERNAL_SERVER_ERROR);
OC_Template::printExceptionErrorPage($e);

8
lib/private/session/internal.php
View file

@ -18,7 +18,9 @@ namespace OC\Session;
class Internal extends Session {
public function __construct($name) {
session_name($name);
set_error_handler(array($this, 'trapError'));
session_start();
restore_error_handler();
if (!isset($_SESSION)) {
throw new \Exception('Failed to start session');
}
@ -82,7 +84,11 @@ class Internal extends Session {
throw new \Exception('The session cannot be reopened - reopen() is ony to be used in unit testing.');
}
private function validateSession() {
public function trapError($errorNumber, $errorString) {
throw new \ErrorException($errorString);
}
private function validateSession() {
if ($this->sessionClosed) {
throw new \Exception('Session has been closed - no further changes to the session as allowed');
}