wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

adding unit tests

Browse source
This commit is contained in:
Thomas Müller 2015-03-26 10:49:26 +01:00
parent 30ee8b6f99
commit 8d327c94a8
2 changed files with 33 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/private/connector/sabre/filesplugin.php
View file

@ -184,11 +184,8 @@ class FilesPlugin extends \Sabre\DAV\ServerPlugin {
/**
* @param \OC\Connector\Sabre\Node $node
*/
private function getETag($node) {
if (isset($_SERVER['HTTP_OC_CHUNKED'])) {
if (isset($_SERVER['X-CHUNKING_COMPLETE'])) {
return $node->getETag();
}
public function getETag($node) {
if (isset($_SERVER['HTTP_OC_CHUNKED']) && !isset($_SERVER['X-CHUNKING_COMPLETE'])) {
return null;
}
return $node->getETag();

31
tests/lib/connector/sabre/filesplugin.php
View file

@ -171,4 +171,35 @@ class FilesPlugin extends \Test\TestCase {
$this->assertEquals(200, $result[self::GETETAG_PROPERTYNAME]);
}
/**
* @dataProvider providesETagTestData
* @param $expectedETag
* @param $isChunked
* @param $isChunkComplete
*/
public function testETag($expectedETag, $isChunked, $isChunkComplete) {
if (!is_null($isChunked)) {
$_SERVER['HTTP_OC_CHUNKED'] = $isChunked;
}
if (!is_null($isChunkComplete)) {
$_SERVER['X-CHUNKING_COMPLETE'] = $isChunkComplete;
}
$node = $this->createTestNode('\OC\Connector\Sabre\File');
$etag = $this->plugin->getETag($node);
$this->assertEquals($expectedETag, $etag);
}
public function providesETagTestData() {
return [
// non-chunked tests
['"abc"', null, null],
['"abc"', null, false],
// chunked tests
[null, true, null],
['"abc"', true, true],
];
}
}