wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

more efficient write only fopen

Browse source 
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2017-06-07 16:50:51 +02:00
parent d70607104e
commit 9b5accf9f3
No known key found for this signature in database
GPG key ID: CBCA68FBAEBF98C9
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
apps/files_external/lib/Lib/Storage/AmazonS3.php
View file

@ -42,6 +42,7 @@ use Icewind\Streams\CallbackWrapper;
use Icewind\Streams\IteratorDirectory;
use OC\Files\ObjectStore\S3ConnectionTrait;
use OC\Files\ObjectStore\S3ObjectTrait;
use OCP\Constants;
class AmazonS3 extends \OC\Files\Storage\Common {
use S3ConnectionTrait;
@ -339,6 +340,12 @@ class AmazonS3 extends \OC\Files\Storage\Common {
}
case 'w':
case 'wb':
$tmpFile = \OCP\Files::tmpFile();
$handle = fopen($tmpFile, 'w');
return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
$this->writeBack($tmpFile, $path);
});
case 'a':
case 'ab':
case 'r+':
@ -506,11 +513,12 @@ class AmazonS3 extends \OC\Files\Storage\Common {
public function writeBack($tmpFile, $path) {
try {
$source = $this->fopen($tmpFile, 'r');
$source = fopen($tmpFile, 'r');
$this->writeObject($path, $source);
fclose($source);
unlink($tmpFile);
return true;
} catch (S3Exception $e) {
\OCP\Util::logException('files_external', $e);
return false;