wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Share 2.0] Properly handle user deleted group shares

Browse source 
If a user deletes a group share we create a special share entry. To the
API this is just a normal group share for that user with permissions 0.
But we should not return this.
This commit is contained in:
Roeland Jago Douma 2016-01-27 09:02:12 +01:00
parent 1df31c802b
commit a4900d721f
3 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
apps/files_sharing/api/share20ocs.php
View file

@ -335,7 +335,9 @@ class Share20OCS {
$formatted = [];
foreach ($shares as $share) {
$formatted[] = $this->formatShare($share);
if ($this->canAccessShare($share)) {
$formatted[] = $this->formatShare($share);
}
}
return new \OC_OCS_Result($formatted);
@ -430,6 +432,11 @@ class Share20OCS {
* @return bool
*/
protected function canAccessShare(IShare $share) {
// A file with permissions 0 can't be accessed by us. So Don't show it
if ($share->getPermissions() === 0) {
return false;
}
// Owner of the file and the sharer of the file can always get share
if ($share->getShareOwner() === $this->currentUser ||
$share->getSharedBy() === $this->currentUser

2
lib/private/share20/defaultshareprovider.php
View file

@ -697,7 +697,7 @@ class DefaultShareProvider implements IShareProvider {
$stmt->closeCursor();
if ($data !== false) {
$share->setPermissions($data['permissions']);
$share->setPermissions((int)$data['permissions']);
$share->setTarget($data['file_target']);
}

14
tests/lib/share20/defaultshareprovidertest.php
View file

@ -943,13 +943,13 @@ class DefaultShareProviderTest extends \Test\TestCase {
$this->assertCount(1, $share);
$share = $share[0];
$this->assertEquals($id, $share->getId());
$this->assertEquals($group, $share->getSharedWith());
$this->assertEquals($owner, $share->getShareOwner());
$this->assertEquals($initiator, $share->getSharedBy());
$this->assertEquals(\OCP\Share::SHARE_TYPE_GROUP, $share->getShareType());
$this->assertEquals(0, $share->getPermissions());
$this->assertEquals('userTarget', $share->getTarget());
$this->assertSame($id, $share->getId());
$this->assertSame($group, $share->getSharedWith());
$this->assertSame($owner, $share->getShareOwner());
$this->assertSame($initiator, $share->getSharedBy());
$this->assertSame(\OCP\Share::SHARE_TYPE_GROUP, $share->getShareType());
$this->assertSame(0, $share->getPermissions());
$this->assertSame('userTarget', $share->getTarget());
}
public function testGetSharesBy() {