Also cache avatars when it's not allowed

Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
Joas Schilling 2020-02-28 10:44:15 +01:00
parent d7523c7f4e
commit a92ab77747
No known key found for this signature in database
GPG key ID: 7076EA9751AACDDA

View file

@ -134,13 +134,15 @@ class AvatarController extends Controller {
if ($scope !== IAccountManager::VISIBILITY_PUBLIC && $this->userId === null) {
// Public avatar access is not allowed
return new JSONResponse([], Http::STATUS_NOT_FOUND);
$response = new JSONResponse([], Http::STATUS_NOT_FOUND);
$response->cacheFor(1800);
return $response;
}
try {
$avatar = $this->avatarManager->getAvatar($userId);
$avatarFile = $avatar->getFile($size);
$resp = new FileDisplayResponse(
$response = new FileDisplayResponse(
$avatarFile,
$avatar->isCustomAvatar() ? Http::STATUS_OK : Http::STATUS_CREATED,
['Content-Type' => $avatarFile->getMimeType()]
@ -150,8 +152,8 @@ class AvatarController extends Controller {
}
// Cache for 30 minutes
$resp->cacheFor(1800);
return $resp;
$response->cacheFor(1800);
return $response;
}
/**