wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #13675 from imsolost/master

Browse source 
Fixed some LGTM alerts
This commit is contained in:
Morris Jobke 2019-01-28 14:46:01 +01:00 committed by GitHub
commit b5b8a17222
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
apps/files/js/filelist.js
View file

@ -1674,7 +1674,7 @@
c: fileData.etag
};
var previewUrl = this.generatePreviewUrl(urlSpec);
previewUrl = previewUrl.replace('(', '%28').replace(')', '%29');
previewUrl = previewUrl.replace(/\(/g, '%28').replace(/\)/g, '%29');
iconDiv.css('background-image', 'url("' + previewUrl + '")');
}
}
@ -2058,8 +2058,7 @@
}
previewURL = self.generatePreviewUrl(urlSpec);
previewURL = previewURL.replace('(', '%28');
previewURL = previewURL.replace(')', '%29');
previewURL = previewURL.replace(/\(/g, '%28').replace(/\)/g, '%29');
// preload image to prevent delay
// this will make the browser cache the image

2
core/js/oc-dialogs.js
View file

@ -280,7 +280,7 @@ var OCdialogs = {
self.$form.submit();
});
var newName = $input.val();
lastPos = newName.lastIndexOf('.');
var lastPos = newName.lastIndexOf('.');
if (lastPos === -1) {
lastPos = newName.length;
}

4
core/js/sharedialoglinkshareview.js
View file

@ -245,7 +245,7 @@
var $newShare = self.$el.find('li[data-share-id="'+newShareId+'"]');
// only open the menu by default if this is the first share
if ($newShare && shares.length === 1) {
$menu = $newShare.find('.popovermenu');
var $menu = $newShare.find('.popovermenu');
OC.showMenu(null, $menu);
}
}
@ -257,7 +257,7 @@
// password failure? Show error
self.password = ''
if (isPasswordEnforced && response && response.responseJSON && response.responseJSON.ocs.meta && response.responseJSON.ocs.meta.message) {
$input = self.$el.find('.pending #enforcedPassText')
var $input = self.$el.find('.pending #enforcedPassText')
$input.tooltip('destroy');
$input.attr('title', response.responseJSON.ocs.meta.message);
$input.tooltip({placement: 'bottom', trigger: 'manual'});

2
core/js/sharedialogview.js
View file

@ -338,7 +338,7 @@
* build the result array that only contains all contact entries from
* merged contacts, if the search term matches its contact name
*/
for (i = 0; i < groupedLength; i++) {
for (var i = 0; i < groupedLength; i++) {
if (typeof grouped[i].uuid !== 'undefined' && grouped[i].uuid === previousUuid) {
grouped[i].merged = true;
}