wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Expiration date can only be enforced if default is enabled

Browse source 
If the default expiration date is not enebaled it can not be enforced.

* Added unit tests
This commit is contained in:
Roeland Jago Douma 2016-02-26 11:38:06 +01:00
parent 62d7885c3b
commit bfcdf40a64
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/private/share20/manager.php
View file

@ -1079,7 +1079,8 @@ class Manager implements IManager {
* @return bool * @return bool
*/ */
public function shareApiLinkDefaultExpireDateEnforced() { public function shareApiLinkDefaultExpireDateEnforced() {
return $this->config->getAppValue('core', 'shareapi_enforce_expire_date', 'no') === 'yes'; return $this->shareApiLinkDefaultExpireDate() &&
$this->config->getAppValue('core', 'shareapi_enforce_expire_date', 'no') === 'yes';
} }
/** /**

15
tests/lib/share20/managertest.php
View file

@ -746,12 +746,27 @@ class ManagerTest extends \Test\TestCase {
$this->config->method('getAppValue') $this->config->method('getAppValue')
->will($this->returnValueMap([ ->will($this->returnValueMap([
['core', 'shareapi_default_expire_date', 'no', 'yes'],
['core', 'shareapi_enforce_expire_date', 'no', 'yes'], ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
])); ]));
$this->invokePrivate($this->manager, 'validateExpirationDate', [$share]); $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
} }
public function testvalidateExpirationDateEnforceButNotEnabledAndNotSet() {
$share = $this->manager->newShare();
$share->setProviderId('foo')->setId('bar');
$this->config->method('getAppValue')
->will($this->returnValueMap([
['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
]));
$this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
$this->assertNull($share->getExpirationDate());
}
public function testvalidateExpirationDateEnforceButNotSetNewShare() { public function testvalidateExpirationDateEnforceButNotSetNewShare() {
$share = $this->manager->newShare(); $share = $this->manager->newShare();