wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

more efficient way to detect added and removed mounts

Browse source 
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2018-08-16 19:56:49 +02:00
parent 3155c1bd9a
commit c300516e51
No known key found for this signature in database
GPG key ID: 42B69D8A64526EFB
1 changed files with 22 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
lib/private/Files/Config/UserMountCache.php
View file

@ -101,17 +101,31 @@ class UserMountCache implements IUserMountCache {
} }
}, $mounts); }, $mounts);
$newMounts = array_values(array_filter($newMounts)); $newMounts = array_values(array_filter($newMounts));
$newMountRootIds = array_map(function (ICachedMountInfo $mount) {
return $mount->getRootId();
}, $newMounts);
$newMounts = array_combine($newMountRootIds, $newMounts);
$cachedMounts = $this->getMountsForUser($user); $cachedMounts = $this->getMountsForUser($user);
$mountDiff = function (ICachedMountInfo $mount1, ICachedMountInfo $mount2) { $cachedMountRootIds = array_map(function (ICachedMountInfo $mount) {
// since we are only looking for mounts for a specific user comparing on root id is enough return $mount->getRootId();
return $mount1->getRootId() - $mount2->getRootId(); }, $cachedMounts);
}; $cachedMounts = array_combine($cachedMountRootIds, $cachedMounts);
/** @var ICachedMountInfo[] $addedMounts */ $addedMounts = [];
$addedMounts = array_udiff($newMounts, $cachedMounts, $mountDiff); $removedMounts = [];
/** @var ICachedMountInfo[] $removedMounts */
$removedMounts = array_udiff($cachedMounts, $newMounts, $mountDiff); foreach ($newMounts as $rootId => $newMount) {
if (!isset($cachedMounts[$rootId])) {
$addedMounts[] = $newMount;
}
}
foreach ($cachedMounts as $rootId => $cachedMount) {
if (!isset($newMounts[$rootId])) {
$removedMounts[] = $cachedMount;
}
}
$changedMounts = $this->findChangedMounts($newMounts, $cachedMounts); $changedMounts = $this->findChangedMounts($newMounts, $cachedMounts);