wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed complete app-breakdown if no favorites are set

Browse source 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Hid three-dot menu if no favorites are selected

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
This commit is contained in:
fnuesse 2018-06-17 22:21:11 +02:00 committed by John Molakvoæ (skjnldsv)
parent fc4baed6e5
commit ce05cb371b
No known key found for this signature in database
GPG key ID: 60C25B8C072916CF
2 changed files with 23 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
apps/files/lib/Controller/ViewController.php
View file

@ -161,6 +161,7 @@ class ViewController extends Controller {
$user = $this->userSession->getUser()->getUID();
//Load QuickAccess-Defaults
$sorting=$this->config->getUserValue($user,$this->appName,'quickaccess_sorting_strategy','date');
$reverseListSetting=$this->config->getUserValue($user,$this->appName,'quickaccess_reverse_list','false');
if($this->config->getUserValue($user,$this->appName,'show_Quick_Access',true)){
@ -169,6 +170,20 @@ class ViewController extends Controller {
$expanded='false';
}
//Get Favorite-Folder
$tagger=\OC::$server->getTagManager();
$helper= new \OCA\Files\Activity\Helper($tagger);
try {
$favElements = $helper->getFavoriteFilePaths($this->userSession->getUser()->getUID());
} catch (\RuntimeException $e) {
$favElements['folders'] = null;
}
$FavoritesFolderCount=sizeof($favElements['folders']);
\OCA\Files\App::getNavigationManager()->add(
[
'id' => 'favorites',
@ -178,16 +193,14 @@ class ViewController extends Controller {
'quickaccessSortingStrategy' => $sorting,
'quickaccessSortingReverse' => $reverseListSetting,
'order' => 5,
'name' => $this->l10n->t('Favorites')
'name' => $this->l10n->t('Favorites'),
//If there are zero elements, add ul end tag directly.
'favoritescount' => $FavoritesFolderCount
]
);
$tagger=\OC::$server->getTagManager();
$helper= new \OCA\Files\Activity\Helper($tagger);
$favElements = $helper->getFavoriteFilePaths($this->userSession->getUser()->getUID());
$FavoritesFolderCount=sizeof($favElements['folders']);
//Add Favorite-folder as menuentries, if there are any
if($FavoritesFolderCount>0){
$NavBarPositionPosition=6;

6
apps/files/templates/appnavigation.php
View file

@ -14,7 +14,7 @@
class="nav-icon-<?php p($item['icon'] !== '' ? $item['icon'] : $item['id']) ?> svg"><?php p($item['name']);?></a>
<?php if($item['id']=='favorites'){?>
<div class="app-navigation-entry-utils">
<div class="app-navigation-entry-utils" <?php if($item['favoritescount']==0){ ?> style="display: none"<?php } ?>>
<ul>
<li class="app-navigation-entry-utils-menu-button svg"><button id="button-<?php p($item['id']) ?>"></button></li>
</ul>
@ -47,8 +47,10 @@
</li>
</ul>
</div>
<ul id="quickaccess-list" <?php if($item['enableQuickaccess']=='false'){ ?> style="display: none"<?php } ?>>
<ul id="quickaccess-list" <?php if($item['enableQuickaccess']=='false'){ ?> style="display: none"<?php } ?>>
<?php /*This fixes the styleerrors if no favorites are set*/ if($item['favoritescount']==0){?></ul><?php } ?>
<?php } ?>
<?php if($item['quickaccesselement']=='last'){?>
</ul>
<?php } ?>