From e32766bd1196fa6f49fd76c7d26024a48e44b41a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= <danxuliu@gmail.com>
Date: Thu, 7 Nov 2019 12:28:43 +0100
Subject: [PATCH] Change menu toggle element from span to button
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This makes possible to navigate to the menu toggle using the keyboard,
as well as being semantically more correct.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---
 core/css/public.scss             | 10 ++++++++++
 core/templates/layout.public.php |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/core/css/public.scss b/core/css/public.scss
index 1b55d9d12d..6ec22cbc6d 100644
--- a/core/css/public.scss
+++ b/core/css/public.scss
@@ -11,6 +11,16 @@ $footer-height: 65px;
 			ul li {
 				min-width: 270px;
 			}
+			#header-actions-toggle {
+				background-color: transparent;
+				border-color: transparent;
+
+				&:hover,
+				&:focus,
+				&:active {
+					opacity: 1;
+				}
+			}
 			#save-external-share {
 				form {
 					display: flex;
diff --git a/core/templates/layout.public.php b/core/templates/layout.public.php
index bbfa264d17..996b78a922 100644
--- a/core/templates/layout.public.php
+++ b/core/templates/layout.public.php
@@ -61,7 +61,7 @@
 			</span>
 			<?php if($template->getActionCount() > 1) { ?>
 			<div id="header-secondary-action">
-				<span id="header-actions-toggle" class="menutoggle icon-more-white"></span>
+				<button id="header-actions-toggle" class="menutoggle icon-more-white"></button>
 				<div id="header-actions-menu" class="popovermenu menu">
 					<ul>
 						<?php