wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixes #8326: deletion of directories on S3

Browse source
This commit is contained in:
Johan Björk 2014-07-08 22:28:12 +02:00
parent 87adbf1c6e
commit e44a7aa034
1 changed files with 12 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
apps/files_external/lib/amazons3.php
View file

@ -190,26 +190,17 @@ class AmazonS3 extends \OC\Files\Storage\Common {
return false;
}
$dh = $this->opendir($path);
if(is_resource($dh)) {
while (($file = readdir($dh)) !== false) {
if ($file === '.' || $file === '..') {
continue;
}
if ($this->is_dir($path . '/' . $file)) {
$this->rmdir($path . '/' . $file);
} else {
$this->unlink($path . '/' . $file);
}
}
}
// Since there are no real directories on S3, we need
// to delete all objects prefixed with the path.
$objects = $this->connection->listObjects([
'Bucket' => $this->bucket,
'Prefix' => $path . '/'
]);
try {
$result = $this->connection->deleteObject(array(
$result = $this->connection->deleteObjects(array(
'Bucket' => $this->bucket,
'Key' => $path . '/'
'Objects' => $objects['Contents']
));
$this->testTimeout();
} catch (S3Exception $e) {
@ -310,6 +301,10 @@ class AmazonS3 extends \OC\Files\Storage\Common {
public function unlink($path) {
$path = $this->normalizePath($path);
if ( $this->is_dir($path) ) {
return $this->rmdir($path);
}
try {
$result = $this->connection->deleteObject(array(
'Bucket' => $this->bucket,