wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use short for of substr to not need strlen()

Browse source 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This commit is contained in:
Morris Jobke 2018-01-25 22:23:48 +01:00
parent b9bbb894f8
commit e6efa755c9
No known key found for this signature in database
GPG key ID: FE03C3A163FEDE68
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/files_versions/lib/Storage.php
View file

@ -167,7 +167,7 @@ class Storage {
// to get the right target
$ext = pathinfo($filename, PATHINFO_EXTENSION);
if ($ext === 'part') {
$filename = substr($filename, 0, strlen($filename) - 5);
$filename = substr($filename, 0, -5);
}
// we only handle existing files

2
lib/private/DB/Adapter.php
View file

@ -108,7 +108,7 @@ class Adapter {
$query .= ' = ? AND ';
}
}
$query = substr($query, 0, strlen($query) - 5);
$query = substr($query, 0, -5);
$query .= ' HAVING COUNT(*) = 0';
return $this->conn->executeUpdate($query, $inserts);

2
lib/private/DB/AdapterSqlite.php
View file

@ -79,7 +79,7 @@ class AdapterSqlite extends Adapter {
$query .= ' = ? AND ';
}
}
$query = substr($query, 0, strlen($query) - 5);
$query = substr($query, 0, -5);
$query .= ')';
return $this->conn->executeUpdate($query, $inserts);

2
lib/private/legacy/template.php
View file

@ -132,7 +132,7 @@ class OC_Template extends \OC\Template\Base {
foreach(array_reverse($coreDependencies['vendor']) as $vendorLibrary) {
//remove trailing ".js" as addVendorScript will append it
OC_Util::addVendorScript(
substr($vendorLibrary, 0, strlen($vendorLibrary) - 3),null,true);
substr($vendorLibrary, 0, -3),null,true);
}
} else {
throw new \Exception('Cannot read core/js/core.json');