Merge pull request #16440 from owncloud/scrutinizer-patch-1

Scrutinizer Auto-Fixes

apps/files/controller/apicontroller.php

@@ -31,7 +31,6 @@ use OCP\AppFramework\Controller;
 use OCP\IRequest;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\DataDisplayResponse;
-use OCP\AppFramework\Http\DownloadResponse;
 use OCA\Files\Service\TagService;
 use OCP\IPreview;
 

apps/files/index.php

@@ -29,7 +29,6 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  *
  */
-use OCA\Files\Appinfo\Application;
 
 // Check if we are a user
 OCP\User::checkLoggedIn();

apps/files/tests/controller/apicontrollertest.php

@@ -25,7 +25,6 @@ namespace OCA\Files\Controller;
 
 use OC\Files\FileInfo;
 use OCP\AppFramework\Http;
-use OC\Preview;
 use OCP\Files\NotFoundException;
 use OCP\Files\StorageNotAvailableException;
 use Test\TestCase;

apps/files_sharing/lib/controllers/sharecontroller.php

@@ -46,7 +46,6 @@ use OCA\Files_Sharing\Helper;
 use OCP\User;
 use OCP\Util;
 use OCA\Files_Sharing\Activity;
-use OCP\AppFramework\Http\DataResponse;
 
 /**
  * Class ShareController

apps/files_sharing/lib/external/storage.php

@@ -25,7 +25,6 @@
 
 namespace OCA\Files_Sharing\External;
 
-use OC\Files\Filesystem;
 use OC\Files\Storage\DAV;
 use OC\ForbiddenException;
 use OCA\Files_Sharing\ISharedStorage;

apps/files_sharing/lib/sharedstorage.php

@@ -29,11 +29,8 @@
 
 namespace OC\Files\Storage;
 
-use OC\Files\Cache\ChangePropagator;
 use OC\Files\Filesystem;
 use OCA\Files_Sharing\ISharedStorage;
-use OCA\Files_Sharing\Propagator;
-use OCA\Files_Sharing\SharedMount;
 
 /**
  * Convert target path to source path and pass the function call to the correct storage provider

apps/files_sharing/tests/controller/sharecontroller.php

@@ -29,7 +29,6 @@ use OC\Files\Filesystem;
 use OCA\Files_Sharing\AppInfo\Application;
 use OCP\AppFramework\Http\NotFoundResponse;
 use OCP\AppFramework\IAppContainer;
-use OCP\Files;
 use OCP\AppFramework\Http\RedirectResponse;
 use OCP\AppFramework\Http\TemplateResponse;
 use OCP\Security\ISecureRandom;

apps/files_trashbin/tests/storage.php

@@ -23,9 +23,7 @@
 
 namespace OCA\Files_trashbin\Tests\Storage;
 
-use OC\Files\Storage\Home;
 use OC\Files\Storage\Temporary;
-use OC\Files\Mount\MountPoint;
 use OC\Files\Filesystem;
 
 class Storage extends \Test\TestCase {

apps/files_versions/command/expire.php

@@ -11,7 +11,6 @@ namespace OCA\Files_Versions\Command;
 use OC\Command\FileAccess;
 use OCA\Files_Versions\Storage;
 use OCP\Command\ICommand;
-use OCP\IUser;
 
 class Expire implements ICommand {
 	use FileAccess;

apps/user_ldap/command/setconfig.php

@@ -26,7 +26,6 @@ namespace OCA\user_ldap\Command;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use \OCA\user_ldap\lib\Helper;
 use \OCA\user_ldap\lib\Configuration;

core/command/db/converttype.php

@@ -30,7 +30,6 @@ namespace OC\Core\Command\Db;
 use \OCP\IConfig;
 use OC\DB\Connection;
 use OC\DB\ConnectionFactory;
-
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;

lib/private/app/codecheckvisitor.php

@@ -22,18 +22,9 @@
 
 namespace OC\App;
 
-use OC\Hooks\BasicEmitter;
-use PhpParser\Lexer;
 use PhpParser\Node;
 use PhpParser\Node\Name;
-use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
-use PhpParser\Parser;
-use RecursiveCallbackFilterIterator;
-use RecursiveDirectoryIterator;
-use RecursiveIteratorIterator;
-use RegexIterator;
-use SplFileInfo;
 
 class CodeCheckVisitor extends NodeVisitorAbstract {
 

lib/private/appframework/dependencyinjection/dicontainer.php

@@ -42,7 +42,6 @@ use OC\AppFramework\Utility\SimpleContainer;
 use OC\AppFramework\Utility\TimeFactory;
 use OC\AppFramework\Utility\ControllerMethodReflector;
 use OCP\AppFramework\IApi;
-use OCP\AppFramework\QueryException;
 use OCP\AppFramework\IAppContainer;
 use OCP\AppFramework\Middleware;
 use OCP\IServerContainer;

lib/private/connector/sabre/objecttree.php

@@ -27,9 +27,7 @@ namespace OC\Connector\Sabre;
 
 use OC\Connector\Sabre\Exception\InvalidPath;
 use OC\Files\FileInfo;
-use OC\Files\Filesystem;
 use OC\Files\Mount\MoveableMount;
-use OC_Connector_Sabre_Exception_InvalidPath;
 use OCP\Files\StorageInvalidException;
 use OCP\Files\StorageNotAvailableException;
 

lib/private/files/node/root.php

@@ -25,14 +25,11 @@
 
 namespace OC\Files\Node;
 
-use OC\Files\Cache\Cache;
 use OC\Files\Mount\Manager;
 use OC\Files\Mount\MountPoint;
 use OCP\Files\NotFoundException;
 use OCP\Files\NotPermittedException;
-use OC\Hooks\Emitter;
 use OC\Hooks\PublicEmitter;
-
 use OCP\Files\IRootFolder;
 
 /**

lib/private/files/objectstore/objectstorestorage.php

@@ -24,7 +24,6 @@
 
 namespace OC\Files\ObjectStore;
 
-use OC\Files\Filesystem;
 use OCP\Files\ObjectStore\IObjectStore;
 
 class ObjectStoreStorage extends \OC\Files\Storage\Common {

lib/private/files/storage/localtempfiletrait.php

@@ -21,15 +21,6 @@
 
 namespace OC\Files\Storage;
 
-use OC\Files\Cache\Cache;
-use OC\Files\Cache\Scanner;
-use OC\Files\Filesystem;
-use OC\Files\Cache\Watcher;
-use OCP\Files\FileNameTooLongException;
-use OCP\Files\InvalidCharacterInPathException;
-use OCP\Files\InvalidPathException;
-use OCP\Files\ReservedWordException;
-
 /**
  * Storage backend class for providing common filesystem operation methods
  * which are not storage-backend specific.

lib/private/search/result/file.php

@@ -23,7 +23,6 @@
  */
 
 namespace OC\Search\Result;
-use OC\Files\Filesystem;
 use OCP\Files\FileInfo;
 use OCP\Files\Folder;
 

tests/lib/files/node/integration.php

@@ -8,7 +8,6 @@
 
 namespace Test\Files\Node;
 
-use OC\Files\Cache\Cache;
 use OC\Files\Node\Root;
 use OC\Files\Storage\Temporary;
 use OC\Files\View;

tests/lib/files/stream/encryption.php

@@ -3,7 +3,6 @@
 namespace Test\Files\Stream;
 
 use OC\Files\View;
-use OCA\Encryption_Dummy\DummyModule;
 
 class Encryption extends \Test\TestCase {