wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
43391 commits 157 branches 562 tags 714 MiB
Commit graph

17870 commits

Author SHA1 Message Date
Roeland Jago Douma
734cddfa97
Merge pull request #8880 from nextcloud/delete_unused_download 
Remove unused download.php
 2018-03-19 14:18:51 +01:00
Roeland Jago Douma
9834f33d56
Merge pull request #8878 from nextcloud/remove_tmpfile 
Remove deprecated tmpFile/tmpFolder
 2018-03-19 12:29:08 +01:00
Roeland Jago Douma
1d6a2a7019
Remove unused download.php 
There were two routes apps/files/ajax/download.php but apparently also
apps/files/download.php I could not find any use of it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-19 11:45:48 +01:00
Roeland Jago Douma
17bfa1c74e
Merge pull request #8815 from nextcloud/channel-description 
Provide a description of the update channels inline
 2018-03-19 11:25:15 +01:00
Roeland Jago Douma
47a3008141
Remove \OCP\Files::tmpFile 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-19 10:52:35 +01:00
Morris Jobke
63bc633d89
Merge pull request #8857 from nextcloud/swift-verify-cached-token 
verify cached swift token
 2018-03-19 10:10:04 +01:00
John Molakvoæ (skjnldsv)
ccd57ce1b1
Allow empty emails provisionning api 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-17 12:18:22 +01:00
Nextcloud bot
3cac7911d5
[tx-robot] updated from transifex 2018-03-17 01:11:30 +00:00
rakekniven
b2ceb29484
Update ThemingController.php 
Changed wording according to discussion at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/121491259?issue=yes
Aligned ending of error messages
 2018-03-16 18:45:20 +01:00
blizzz
e56759917b
Merge pull request #8843 from nextcloud/set-share-with-field-to-the-id-of-the-circle 
Set "share with" field to the ID of the circle
 2018-03-16 16:42:31 +01:00
John Molakvoæ (skjnldsv)
2493e9426d
Check if groups is array, return empty do not throw 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-16 15:32:36 +01:00
Robin Appelman
41954d2903
verify cached swift token 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-03-16 15:20:16 +01:00
John Molakvoæ (skjnldsv)
f5137fef6c
Fixed tests and improved code 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-16 11:44:20 +01:00
John Molakvoæ (skjnldsv)
aa1e8713fb
Fixed throw error on unreachable users 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-16 09:38:09 +01:00
Morris Jobke
f83aa58d1f
Merge pull request #8835 from nextcloud/fix/noid/ldap_existence_check 
group existence check works without attribute (like with users)
 2018-03-16 09:31:49 +01:00
John Molakvoæ (skjnldsv)
ce625bbad5
Add userdetails to ocs api 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-16 09:19:47 +01:00
Daniel Calviño Sánchez
2c073dc53d Set "share_with" field to the ID of the circle 
When a share is shared with a circle the "share_with" field returned by
the API endpoint was always set to the name of the circle. However, the
name is not enough to identify a circle. The Circles app now provides
the ID of the circle in the "shared with" field of a Share, so this
commit modifies the API endpoint to set the "share_with" field to the ID
of the circle when provided by the Circles app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-03-16 04:58:00 +01:00
Nextcloud bot
b7e7ae5d6d
[tx-robot] updated from transifex 2018-03-16 01:11:31 +00:00
Arthur Schiwon
cbf60f2e91
existence check works without attribute (like with users) 
cn is not necessarily given everywhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-03-15 15:47:44 +01:00
blizzz
208e38e84e
Merge pull request #8255 from nextcloud/bugfix/noid/group-display-name 
Full implement group display names
 2018-03-15 12:07:30 +01:00
Morris Jobke
b01b3454e6
Provide a description of the update channels inline 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-15 07:11:50 +01:00
Nextcloud bot
055d15e305
[tx-robot] updated from transifex 2018-03-15 01:11:41 +00:00
Roeland Jago Douma
2d5febd0b9
Merge pull request #8811 from nextcloud/remove_dep_util_link 
Remove deprecated URL functions for OCP\Util
 2018-03-14 09:49:51 +01:00
Roeland Jago Douma
0e48afafed
Merge pull request #8804 from nextcloud/remove_httphelper 
Remove deprecated HTTPHelper
 2018-03-14 09:49:24 +01:00
Nextcloud bot
7f00de841b
[tx-robot] updated from transifex 2018-03-14 01:11:29 +00:00
Roeland Jago Douma
b93d26a209
Replace ContactsManager 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-13 22:18:38 +01:00
Roeland Jago Douma
83873e3da1
Remove deprecated URL functions for OCP\Util 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-13 22:04:08 +01:00
Roeland Jago Douma
7785c3752f
Remove deprecated HTTPHelper 
* Remove the HTTP Helper
* Remove from Server Containter
* Removed legacy share tests that use it

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-13 21:54:56 +01:00
Roeland Jago Douma
f52ba44edb
Move storagestats endpoint to proper controller 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-13 12:44:48 +01:00
Morris Jobke
58599e0360
Merge pull request #8781 from nextcloud/cleanup-old-federation-code 
Remove old code to be compatible with Nextcloud 9 and before
 2018-03-13 11:53:21 +01:00
Morris Jobke
7488218535
Merge pull request #8792 from nextcloud/cleanup-oc_response 
Remove unused methods of OC_Response
 2018-03-13 09:47:29 +01:00
Morris Jobke
53a899a1f5
Fix the HTTP 1.0 status code and properly detect 1.0 vs 1.1&2.0 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-13 09:22:26 +01:00
Nextcloud bot
3cae276149
[tx-robot] updated from transifex 2018-03-13 01:12:01 +00:00
Morris Jobke
e758cfcdc8
Remove unused methods of OC_Response 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-12 18:42:30 +01:00
Morris Jobke
044d01d0e1
Use proper method to log exceptions 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-12 18:10:59 +01:00
Morris Jobke
8195b17ed7
Remove deprecated and unsused methods of OCP\DB 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-12 15:13:37 +01:00
Morris Jobke
4cbcf6f920
Remove old code to be compatible with Nextcloud 9 and before 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-12 14:21:12 +01:00
Morris Jobke
430c478ba3
Merge pull request #8769 from nextcloud/admin_audit_strict 
Make admin_audit strict
 2018-03-12 11:57:37 +01:00
Nextcloud bot
4e56a02450
[tx-robot] updated from transifex 2018-03-12 01:12:21 +00:00
Morris Jobke
15c099df4d
Merge pull request #8633 from nextcloud/rakekniven-i18n-fix 
Improved translation strings
 2018-03-11 19:33:26 +01:00
Nextcloud bot
2c503ccdee
[tx-robot] updated from transifex 2018-03-11 01:12:13 +00:00
Roeland Jago Douma
4d5830c4aa
Make admin_audit strict 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-10 19:40:19 +01:00
Roeland Jago Douma
f4bcf2db60
Use variable for proper translations 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-10 13:00:25 +01:00
rakekniven
bcdbbb56b0
Update ThemingControllerTest.php 
Fixed tests for https://github.com/nextcloud/server/pull/8633
 2018-03-10 12:57:09 +01:00
rakekniven
746022ce46
Update wizardTabElementary.js 
Fixed grammar.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/91002422?issue=yes
 2018-03-10 12:57:09 +01:00
rakekniven
2b0c523cc0
Update settings.js 
Added question mark.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/120539223?issue=yes
 2018-03-10 12:57:09 +01:00
rakekniven
4fc4e6dcaa
Update ThemingController.php 
Improved translation string.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/121491256?issue=yes
 2018-03-10 12:57:05 +01:00
Nextcloud bot
f08bc1bc6f
[tx-robot] updated from transifex 2018-03-10 01:11:58 +00:00
Morris Jobke
ed5008597f
Merge pull request #8112 from nextcloud/fix-integer-overflow 
Fix integer overflow in ChunkingPlugin
 2018-03-09 10:27:17 +01:00
Nextcloud bot
a20e9d7891
[tx-robot] updated from transifex 2018-03-09 01:12:12 +00:00
Roeland Jago Douma
7a7c350a2d
Merge pull request #8716 from nextcloud/fix-cache-prefixing 
Remove base url from global cache prefix
 2018-03-08 21:12:54 +01:00
Roeland Jago Douma
7e374200c4
Merge pull request #8575 from nextcloud/new-folder-button 
Updated popover rules to allow form inputs and added input submit for…
 2018-03-08 21:09:44 +01:00
Roeland Jago Douma
d05469959e
Merge pull request #8715 from nextcloud/objectstore-no-part-files 
disable part files for object stores
 2018-03-08 20:52:16 +01:00
John Molakvoæ (skjnldsv)
23a1553539
Fixed api tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-08 17:13:52 +01:00
John Molakvoæ (skjnldsv)
f1478ea440
No ES6 :( 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-08 17:13:51 +01:00
John Molakvoæ (skjnldsv)
6e0044b668
Fixed sharing groups select and fixed search 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-08 17:13:51 +01:00
Joas Schilling
1f9a5c0d7f
Remove resolved FIXME 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv)
720e64ba55
Fixed caldav tests and metadata 2 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv)
e6a7a9f251
Fixed select2 workflow 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-08 17:13:50 +01:00
Joas Schilling
db9b2398dd
Fix group displaynames in activity 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-03-08 17:13:49 +01:00
Joas Schilling
0e2366233a
Start fixing Select2 options 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-03-08 17:13:49 +01:00
Morris Jobke
cccf6f4d5f
Merge pull request #8221 from Cybso/8220_applyLdapUserFilter_on_members 
Apply ldapUserFilter on members of group
 2018-03-08 13:19:02 +01:00
Robin Appelman
f5ef9e02b2
emit pre-hooks earlier when not using part files 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-03-08 13:02:35 +01:00
John Molakvoæ (skjnldsv)
cee5be6ff2
Fixed jsunit 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-08 10:31:33 +01:00
John Molakvoæ (skjnldsv)
3ef4131533
Fixed event propagation on safari 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 17:10:46 +01:00
John Molakvoæ (skjnldsv)
e1ec4514cc
Use label for better focus on external share 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 15:28:03 +01:00
John Molakvoæ (skjnldsv)
446a3a9d5a
Fixed ext share style and use varable for popover height 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 15:12:06 +01:00
Julius Härtl
573b940761
Use cache prefix for theming as well 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-03-07 15:09:43 +01:00
Julius Härtl
95366bbd1f
Fix tests to use ICacheFactory 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-03-07 15:09:43 +01:00
Julius Härtl
50a9beb4bb
Move base url from global cache prefix to frontend related ones 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-03-07 15:09:43 +01:00
John Molakvoæ (skjnldsv)
8d986160b8
Improved inline confirm icon with opacity and fixed ext share loading state 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv)
4e6043fd6b
Fixed tooltip positionning & error display 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv)
955c2ee1a7
PoC inline icon-confirm with inputs 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv)
3964616a9e
Updated popover rules to allow form inputs and added input submit for new File 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 13:17:36 +01:00
Morris Jobke
d1aa96fef9
Merge pull request #8373 from nextcloud/right-header-stdrd 
New standard for top right header
 2018-03-07 12:33:11 +01:00
Roland Tapken
2472b93fd9 dn2ocname: also apply group filter to readAttribute() 
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
 2018-03-07 12:18:46 +01:00
John Molakvoæ (skjnldsv)
d9bd6f3253
Fixed public template 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-07 11:05:23 +01:00
Morris Jobke
c88112bb41
Merge pull request #8579 from nextcloud/feature/2692/merge-can-i-update 
Display a list of unavailable apps for updates (aka. merge "Can I update?")
 2018-03-06 21:31:06 +01:00
Morris Jobke
fc4e0501f0
Fix integer overflow in ChunkingPlugin 
Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-06 18:47:26 +01:00
Joas Schilling
c7b322b863
Fix the cursor on the icon 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-03-06 17:28:20 +01:00
Joas Schilling
303085421e
Add a little arrow to indicate that the list can be opened 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-03-06 17:24:24 +01:00
Joas Schilling
f9eb5c85a3
Fix the available list 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-03-06 17:14:07 +01:00
Joas Schilling
2d72c16ecd
Show a loading message while we determinate the status of the updates 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-03-06 17:13:35 +01:00
Tobia De Koninck
55b9a5d886
Remove OC_App::disable method 
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
 2018-03-06 10:45:20 +01:00
Nextcloud bot
3867a74f0d
[tx-robot] updated from transifex 2018-03-06 01:12:16 +00:00
Roeland Jago Douma
c2320aea22
Merge pull request #8634 from nextcloud/ldap-no-empty-names 
do not create empty userid when attribute does not have allowed chars
 2018-03-05 19:37:17 +01:00
Arthur Schiwon
47a10bd25a
treat iconv issues 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-03-05 14:03:08 +01:00
Arthur Schiwon
4f8c724318
typo + phpdoc 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-03-05 13:30:28 +01:00
Joas Schilling
c85c64c787
Merge pull request #8630 from nextcloud/ldap-cachekey-sha256 
use hash algo that's robust against collisions
 2018-03-05 12:34:07 +01:00
Morris Jobke
3ced2c7ab2
Merge pull request #8601 from nextcloud/theming-fix-background-color 
Remove too restrict check for background image/color
 2018-03-05 11:28:41 +01:00
Morris Jobke
a8f56ac8c7
Merge pull request #8603 from nextcloud/enc-cleanup 
kill old encryption migration steps
 2018-03-05 11:16:27 +01:00
Roeland Jago Douma
05ef2d70e7
Merge pull request #8590 from nextcloud/redirect-to-download-after-share 
Sharing: redirect to download after authentification if requested
 2018-03-05 11:11:43 +01:00
Nextcloud bot
6c49cc0294
[tx-robot] updated from transifex 2018-03-05 01:12:12 +00:00
Nextcloud bot
6975cef00b
[tx-robot] updated from transifex 2018-03-04 01:12:42 +00:00
Nextcloud bot
3b000d4f91
[tx-robot] updated from transifex 2018-03-03 01:12:14 +00:00
Roeland Jago Douma
5053877c45
Merge pull request #8619 from coliff/patch-1 
Use correct input type for the url entry
 2018-03-02 21:26:36 +01:00
Arthur Schiwon
8607992e85
do not create empty userid when attribute does not have allowed chars 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-03-02 17:44:06 +01:00
Arthur Schiwon
04f7252fc4
use hash algo that's robust against collisions 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-03-02 16:26:36 +01:00
Morris Jobke
064cb5ebce
Merge pull request #8612 from nextcloud/rakekniven-i18n-fix 
Update commentstabview.js
 2018-03-02 10:36:36 +01:00
Bjoern Schiessle
8042e6b8fb
this was a migration step to ownCloud 8.0 to restructure the encryption folder which is no longer needed 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-03-02 10:09:52 +01:00
Christian Oliff
d838789259
Use correct input type for the url entry 
Change `type="text"` to `type="url"`
 2018-03-02 16:49:56 +09:00
Nextcloud bot
777313db42
[tx-robot] updated from transifex 2018-03-02 01:12:16 +00:00
rakekniven
b348cd170a
Update commentstabview.js 
Changed typo reported at GitHub.
See https://www.transifex.com/nextcloud/nextcloud/translate/#de_DE/$/91002505?issue=yes
 2018-03-01 20:53:50 +01:00
Roeland Jago Douma
6b931eb64b
Merge pull request #8588 from nextcloud/fix-breadcrumbs-width-calculation 
Fix breadcrumbs width calculation
 2018-03-01 20:13:26 +01:00
Julius Härtl
c521791653
Remove to restrict check for background image/color 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-03-01 14:39:31 +01:00
Sagorika Das
5d9d0b00e0 updated js 
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
 2018-03-01 18:20:37 +05:30
John Molakvoæ (skjnldsv)
3824e6f631
fixup! fixup! Sharing: redirect to download after authentification if requested 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-01 13:17:08 +01:00
John Molakvoæ (skjnldsv)
4c2aff0807
fixup! Sharing: redirect to download after authentification if requested 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-03-01 13:12:24 +01:00
Sagorika Das
d78e314d51 New folder creation flow 
Descend into newly created folder by clicking enter again.
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
 2018-03-01 17:19:07 +05:30
Joas Schilling
0f3ba9444e
Merge pull request #8298 from nextcloud/bugfix/e2e-45/fix-activities-for-end2end-encryption 
Fix activities for e2e encryption
 2018-03-01 10:51:27 +01:00
Morris Jobke
6b4a2d01c3
Merge pull request #8574 from nextcloud/breadcrumb-flash-fix 
Fixed breadcrumb menu flashing
 2018-03-01 09:39:29 +01:00
Nextcloud bot
a7fb9ff8da
[tx-robot] updated from transifex 2018-03-01 01:12:11 +00:00
John Molakvoæ (skjnldsv)
7bcc821642
fixup! Fixed tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-28 19:03:00 +01:00
John Molakvoæ (skjnldsv)
8c69d783e0
Fixed tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-28 17:35:42 +01:00
Daniel Calviño Sánchez
542dc2b335 Fix upload button visible on read-only folders 
The div that contains the elements related to the creation of new files,
and thus the upload button, is always present in the DOM; it is hidden
or shown based on the folder permissions by adding or removing the
"hidden" CSS class. However, as the other CSS classes for the div are
"actions" and "creatable" and a "display: flex" rule was defined for
".actions.creatable" below the "display: none" rule for
".actions.hidden" the last one took precedence and the div ended being
always visible, even if the "hidden" CSS class was set. Now the rules
for the ".actions.hidden" selector are defined below the rules for the
".actions.creatable" selector and thus the "display: none" rule is
applied as expected.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 17:26:36 +01:00
John Molakvoæ (skjnldsv)
a0641e43dc
fixup! Sharing: redirect to download after authentification if requested 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-28 17:08:25 +01:00
John Molakvoæ (skjnldsv)
fb890807c0
Sharing: redirect to download after authentification if requested 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-28 17:05:55 +01:00
Joas Schilling
8b73560cac
Fix unit test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 16:04:45 +01:00
Joas Schilling
0b883ab9d9
Catch exception when the parent is deleted as well 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 15:40:01 +01:00
Joas Schilling
825c276e84
Do a recursion instead of an endless loop 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 15:16:18 +01:00
Joas Schilling
62e982a91f
Fix problem with deleted files 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 15:06:06 +01:00
Joas Schilling
d202bae3b5
Fix path handling for activities 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 15:06:06 +01:00
Joas Schilling
f8c27cb57d
Add special handling for e2e encryption 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 15:06:06 +01:00
Joas Schilling
03a25410f1
Extract duplicated logic into a method 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 15:06:05 +01:00
Daniel Calviño Sánchez
ad71abca6f Update comments in tests 
Menu and home are not always visible; home is always visible, but menu
is shown only when needed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
292476911f Improve documentation of "getTotalWidth" 
"getTotalWidth" is not more accurate; it is simply not clamped.
Moreover, "width/outerWidth" could be used in tests too, and also even
if "getTotalWidth" could be used in tests while others not that would
not be something to be stated in the API documentation, but in a
comment.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
d122d054d3 Do not show the crumbs again after hiding them 
After the changes in the previous commit "_showCrumb" no longer shows
the menu, only the same crumb that was hidden by the last call to
"_hideCrumb". Therefore, if the crumb was hidden because it did not fit
there is no need to try to show it again, as it will still not fit.

Moreover, the calculated width for a hidden element is not always
accurate; in some cases the calculated width is lower than the actual
width (it happens, for example, when using a background image like the
"Share" icon), which causea the crumb to be shown even if there is not
enough room, which in the end causes the siblings to overflow the
contents.

No unit tests for this one, though; you will have to trust me on this,
sorry ;-)

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
10e9eeec45 Fix menu visibility 
The crumb for the menu was shown like any other crumb when calling
"_showCrumb", but it was also shown when other crumbs were hidden
without taking into account the available width. This caused several
related problems, like the breadcrumbs taking too much space when the
menu was sometimes shown after the rest of the crumbs were adjusted to
the available width, or the menu being shown instead of the last crumb
even if there was room for it when the available width was increased.

Now the menu is always hidden before starting the resizing of the crumbs
to ensure that whether it was previously shown or not does not affect
the result. In a similar way, the menu will no longer be shown by
"_showCrumb", as it is not a regular crumb that has to be shown simply
if there is enough room. The menu is now shown as soon as any other
crumb is hidden; this ensures that the menu width will be taken into
account in further width checks. As when _updateMenu" is called it no
longer needs to take care of showing the menu this fixes the issue
revealed when fixing the test setup in the previous commit.

Finally, this implicitly fixes the failure in the breadcrumbs tests when
run on Firefox, as it was caused by the menu interfering in the
calculations of the other crumbs when increasing the width.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
1bcba56d8f Fix setup to test the breadcrumbs menu 
The "Shows only items not in the breadcrumb" test was failing when run
on Firefox, but not on PhantomJS. This was caused by the differences in
the starting width between both browsers and an incorrect setup of the
test (the width set for the crumbs was overriden when the breadcrumbs
were rendered again, and the breadcrumb was resized to 300 from an
indeterminate initial width).

Now the crumbs are rendered and then its width, padding and margin are
set to a known value. Then it is resized to 1000px, which ensures that
there will be enough room for all the crumbs and thus the menu will be
hidden, and finally it is resized to 300, which causes the middle crumb
to be hidden and the menu to be shown.

Note, however, that the test now always fails, no matter if it is run on
PhantomJS or on Firefox; if the menu crumb is hidden when "_updateMenu"
is called it will show it, but it will also wrongly try to add the menu
itself to the menu. As the "crumb-id" of the menu crumb is "-1" this
causes the last regular crumb to be added to the menu. This will be
fixed with other related issues in the next commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
92345f2c38 Take padding and margins of crumbs into account 
When calculating the total width of the crumbs only its padding was
taken into account; now the margin is too. In a similar way, before
showing a crumb only its width was taken into account; now its padding
and margin are taken into account too.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
29c924f74b Use hard-coded values for paddings and margins 
This ensures that the resize tests do not depend on the values set in
the CSS files.

Note that this change causes a test to fail with Firefox, but not with
PhantomJS. This is due to a difference in the starting width used by
Firefox and by PhantomJS, and it will be fixed in a following commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
acdf091f84 Compress siblings before calculating the available width for crumbs 
When the parent element of the breadcrumbs was resized to a larger width
and the siblings of the breadcrumbs expanded to fill all the available
width some crumbs could be hidden even if there was enough room for
them. The reason was that the width of the siblings being used to
calculate the available width for the breadcrumbs was the expanded width
of the siblings. Now as many crumbs as possible (that is, fitting in the
parent, no matter the siblings) are first shown so the expanding
siblings are compressed before calculating the available width.

Due to the lack of support for flexboxes in PhantomJS the related unit
test is skipped; it has to be run in other browser, like Firefox.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
a37007f872 Take all visible siblings into account 
Other apps could add elements to the controls outside the creatable
actions div (for example, the button to switch to the gallery), so the
widths of all the visible siblings of the breadcrumbs have to be taken
into account in the size calculations.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
e37c4fd7f3 Take padding and margin of the creatable actions div into account 
There are some differences in width handling between the browsers used
to run the tests, most likely due to their support (or lack of) of
certain CSS features: PhantomJS requires "width" to be set (probably
because it does not handle flex displays and treats it like a block, so
"min-width" does not matter in this case), while Firefox requires
"min-width" to be set (otherwise the children of "#controls" could be
compressed due to its use of flex display and the elements would end
with a different width than the one needed for the tests). Due to all
that the width of the breadcrumb siblings must be specified in the tests
using both "width" and "min-width".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
3850221ae1 Do not render the breadcrumbs again in resize tests 
There is no need to call "setDirectory" again in resize tests; it is
enough to simply resize them (and isolates them better to just test the
resizing behaviour).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
a828e7b12a Replace attribute with local variable 
The "usedWidth" attribute was not used elsewhere outside the "_resize"
method, so it was replaced with a local variable. Moreover, it was also
renamed to a more suitable name ("availableWidth").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez
a9552de089 Set the width of the parent element in breadcrumb tests 
Setting the width of the parent element of the breadcrumbs and then
explicitly calling "_resize" is enough to test the resizing behaviour.
This makes possible to remove the "setMaxWidth" method and its related
code, which was used only for testing purposes.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-02-28 15:03:26 +01:00
Joas Schilling
bb58d12bca
Check for app updates when there is a new major version available 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-28 14:27:35 +01:00
Roeland Jago Douma
0e0d852b89
Merge pull request #8566 from nextcloud/provisioning_strict 
Make the provisioning api app strict
 2018-02-28 14:09:34 +01:00
Roeland Jago Douma
4b05f03c34
Merge pull request #8569 from nextcloud/cleanup_unused_static_sharing 
Remove unused static sharing helper code
 2018-02-28 13:09:06 +01:00
John Molakvoæ (skjnldsv)
d78026c3b4
Fixed breadcrumb menu flashing 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-28 11:04:27 +01:00
Nextcloud bot
533e8351ad
[tx-robot] updated from transifex 2018-02-28 01:12:31 +00:00
Roeland Jago Douma
7e8c84ec20
Remove unused static sharing helper code 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-02-27 22:40:59 +01:00
Roeland Jago Douma
b369abc378
Merge pull request #8565 from nextcloud/bugfix/fat-48/make-outlook-and-thunderbird-addons-identifyable 
Make the Outlook and Thunderbird addons identifyable
 2018-02-27 22:27:26 +01:00
Roeland Jago Douma
fbeaacdf1b
Fix tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-02-27 22:03:40 +01:00
Morris Jobke
77927442a6
Merge pull request #8496 from nextcloud/ext-strg-design-fixes 
External storage design fixes and update
 2018-02-27 15:59:06 +01:00
Roeland Jago Douma
24b58a7683
Make the provisioning api app strict 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-02-27 15:47:59 +01:00
Joas Schilling
f81d4eb060
Make the Outlook and Thunderbird addons identifyable 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-27 14:37:32 +01:00
Morris Jobke
7bc3c2e057
Merge pull request #7363 from nextcloud/default-share-perms 
Let the admin configure the default share permissions
 2018-02-27 13:44:34 +01:00
Roeland Jago Douma
01f420c7ac
Merge pull request #8051 from nextcloud/public-template 
Public page template response
 2018-02-27 13:33:19 +01:00
John Molakvoæ (skjnldsv)
5f217e2d83
fixup! Fixed tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-27 13:25:42 +01:00
Roeland Jago Douma
017e1325f1
Merge pull request #8285 from nextcloud/apps_files-smb-catch-exceptions-on-listing 
Make SMB module more fault-tolerant
 2018-02-27 13:10:54 +01:00
John Molakvoæ (skjnldsv)
6ee9a2b35b
fixup! Fixed tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-27 13:05:39 +01:00
Bjoern Schiessle
3285becdc1
fix unit tests 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-02-27 12:29:25 +01:00
Bjoern Schiessle
ebb15283a6
share api: use default permission of no permission is given 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-02-27 12:29:25 +01:00
Bjoern Schiessle
1615312bf1
add share permissions to settings page 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-02-27 12:29:25 +01:00
John Molakvoæ (skjnldsv)
f1634cd3e2
fixup! Fixed tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-27 12:27:25 +01:00
Julius Härtl
4a1cbefc90
Fix files_sharing tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-27 12:25:53 +01:00
Julius Härtl
038aad73c7
Add missing phpdoc for public API 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-27 12:25:53 +01:00
Julius Härtl
4f83462f67
Add phpdoc, typehints and sanitize HTML 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-27 12:25:52 +01:00
Julius Härtl
8a13851da8
Use PublicTemplateResponse for files_sharing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-02-27 12:25:52 +01:00
John Molakvoæ (skjnldsv)
324e96b780
Fixed tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-27 12:11:36 +01:00
John Molakvoæ (skjnldsv)
6b45d7e549
Fixed actions and header missing th 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-27 11:35:11 +01:00
Morris Jobke
048ad0df1d
Merge pull request #8475 from sagorika1996/theme 
Empty name not allowed in theming app
 2018-02-27 11:30:59 +01:00
Sagorika Das
7394e8ae58
Empty name not allowed 
Do not allow empty name in theming app.

Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
 2018-02-27 10:54:21 +01:00
Roeland Jago Douma
6994bce951
Loglevel is an int 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-02-27 10:45:35 +01:00
Roeland Jago Douma
4077f16aec
Make ILogger strict 
* Make implementations strict
* Add scalar typehints

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-02-27 10:41:46 +01:00
Nextcloud bot
ad2eefe896
[tx-robot] updated from transifex 2018-02-27 01:14:26 +00:00
Roeland Jago Douma
350b66b73d
Merge pull request #8485 from sagorika1996/rename 
Rename dialog closed when not active
 2018-02-26 21:36:39 +01:00
Joas Schilling
abb0a08ed5
Merge pull request #7933 from nextcloud/update-notification-vuejs 
Migrate Update notifications to Vue.js
 2018-02-26 18:55:08 +01:00
Morris Jobke
8867629cf1
Merge pull request #8359 from nextcloud/swift-v3 
Support swift v3 authentication
 2018-02-26 18:30:00 +01:00
Morris Jobke
4076c09195
Merge pull request #8463 from kyrofa/bugfix/8462/theming_app_outside_root 
theming: handle not being in the serverroot
 2018-02-26 18:27:54 +01:00
Morris Jobke
955e136fd9
Fix appname 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-02-26 17:47:42 +01:00
Morris Jobke
950e7e0467
Merge pull request #8455 from nextcloud/proper_mount_type_external 
Properly set the mount type for external storages
 2018-02-26 17:19:54 +01:00
Morris Jobke
612e875f60
Merge pull request #8355 from nextcloud/fix-comments-num-index 
Fix comments (and systemtags) when involving users with numerical ids
 2018-02-26 17:12:57 +01:00
Morris Jobke
a3c09f51c6
Merge pull request #8203 from Cybso/split-move-copy 
Split move and copy operations
 2018-02-26 16:06:20 +01:00
Morris Jobke
07a6821ab2
Merge pull request #8511 from nextcloud/ext-storage-error-warning-fix 
Ext storage error warning fix
 2018-02-26 15:36:46 +01:00
Robin Appelman
d40c61a71a
adjust external storage config format to the one used in primary storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-02-26 14:54:30 +01:00
Robin Appelman
31dd6d6aae
add support for v3 swift auth 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-02-26 14:54:08 +01:00
Joas Schilling
226e63695f
Merge pull request #8026 from nextcloud/feature/noid/allow-custom-html-in-html-emails 
Allow custom HTML in HTML Emails
 2018-02-26 13:38:39 +01:00
John Molakvoæ (skjnldsv)
0f229d23f7
fixup! Fixed icons padding 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-26 13:03:44 +01:00
John Molakvoæ (skjnldsv)
da2aafa5cf
Fixed icons padding 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-26 13:02:07 +01:00
Joas Schilling
695e32d0a6
Merge pull request #8491 from nextcloud/strict_request 
Make Request strict
 2018-02-26 11:02:30 +01:00
Morris Jobke
2f12094ea8
Merge pull request #8522 from nextcloud/fix-groupmembers-numids 
Fix retrieval of group members with numerical uids from LDAP
 2018-02-26 09:01:38 +01:00
Kyle Fazzari
8dcbea124e
Remove null check 
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
 2018-02-25 07:08:59 -08:00
Kyle Fazzari
25c89a6feb
Add mock to setup 
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
 2018-02-24 08:16:42 -08:00
Nextcloud bot
a210247559
[tx-robot] updated from transifex 2018-02-24 01:12:16 +00:00
John Molakvoæ (skjnldsv)
fdfa934078
Updated error message 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-23 12:13:10 +01:00
Arthur Schiwon
238c3a5201
fix retrieving group members with numerical uids from LDAP 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-02-23 12:05:50 +01:00
Arthur Schiwon
72af741e78
tests for retrieving group members with numerical uids 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-02-23 12:04:48 +01:00
Morris Jobke
e01e1696da
Merge pull request #8507 from nextcloud/fix-change-icon 
Add some whitespace around change.svg icon
 2018-02-23 10:36:32 +01:00
Morris Jobke
98baf8915d
Merge pull request #8502 from nextcloud/properly-show-hints-in-ocs 
Show hint in OCS API for user creation
 2018-02-23 10:02:31 +01:00
Joas Schilling
69c88ad075
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-02-23 09:06:43 +01:00
Nextcloud bot
68187e6036
[tx-robot] updated from transifex 2018-02-23 01:12:16 +00:00
Morris Jobke
930aad5aaa
Merge pull request #8499 from nextcloud/avoid-fruitless-login-attempts 
Avoid fruitless login attempts
 2018-02-22 19:19:40 +01:00
John Molakvoæ (skjnldsv)
4a429cc810
Fixed default urls 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-22 18:17:42 +01:00
John Molakvoæ (skjnldsv)
887241b355
Show error if no external storage configured 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-22 18:14:19 +01:00
Roeland Jago Douma
6335c6c5ec
Fix dav server test 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-02-22 15:51:19 +01:00
Marin Treselj
dc6ae9e622 Add some whitespace around change.svg icon 
Signed-off-by: Marin Treselj <marin@pixelipo.com>
 2018-02-22 15:46:21 +01:00
John Molakvoæ (skjnldsv)
dab83c4a49
Select in popover fix 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-02-22 15:45:37 +01:00