Daniel Calviño Sánchez
766135cb64
Generalize file list locators so a specific ancestor can be used
...
The file list is used in other places besides the Files app (for
example, the File sharing app); in those cases the locators for the file
list elements are the same, but not for the ancestor of the file list.
To make possible to reuse the file list locators in those cases too now
they receive the ancestor to use.
Note that the locators for the file actions menu were not using an
ancestor locator because it is expected that there is only one file
actions menu at a time in the whole page; that may change in the future,
but for the time being it is a valid assumption and thus the ancestor
was not added to those locators in this commit.
Although the locators were generalized the steps themselves still use
the "FilesAppContext::currentSectionMainView" locator as ancestor; the
steps will be generalized in a following commit.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Daniel Calviño Sánchez
10490f2ac3
Store the name of the actor in the Actor object
...
This is needed to be able to easily use the actor as a key in an array.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Daniel Calviño Sánchez
49f2ba16f0
Extract file list locators and steps to its own class
...
Besides the extraction some minor adjustments (sorting locators for file
action menu entries to reflect the order of the menu entries in the UI,
moving parametrized locators like "createMenuItemFor" above the locators
that use them and placing "descendantOf" calls always in a new line)
were made too.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Nextcloud bot
a20e9d7891
[tx-robot] updated from transifex
2018-03-09 01:12:12 +00:00
Roeland Jago Douma
1329061d31
Merge pull request #8648 from nextcloud/feature/csrf-token-controller
...
Use session heartbeat to update CSRF token
2018-03-08 21:15:24 +01:00
Roeland Jago Douma
7a7c350a2d
Merge pull request #8716 from nextcloud/fix-cache-prefixing
...
Remove base url from global cache prefix
2018-03-08 21:12:54 +01:00
Roeland Jago Douma
7e374200c4
Merge pull request #8575 from nextcloud/new-folder-button
...
Updated popover rules to allow form inputs and added input submit for…
2018-03-08 21:09:44 +01:00
Roeland Jago Douma
633d0581a3
Merge pull request #8728 from nextcloud/better-handling-of-invisible-elements-in-acceptance-tests
...
Better handling of invisible elements in acceptance tests
2018-03-08 21:04:20 +01:00
Roeland Jago Douma
d05469959e
Merge pull request #8715 from nextcloud/objectstore-no-part-files
...
disable part files for object stores
2018-03-08 20:52:16 +01:00
rakekniven
1046fb5111
Update login.php
...
Fixed grammar issue.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#af/$/124614533?issue=yes
2018-03-08 20:08:11 +01:00
John Molakvoæ (skjnldsv)
23a1553539
Fixed api tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:52 +01:00
John Molakvoæ (skjnldsv)
f1478ea440
No ES6 :(
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:51 +01:00
John Molakvoæ (skjnldsv)
d435c91fda
fixup! Fixed sharing groups select and fixed search
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:51 +01:00
John Molakvoæ (skjnldsv)
6e0044b668
Fixed sharing groups select and fixed search
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:51 +01:00
Joas Schilling
51ec928623
Send the group ids to the server on user creation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:50 +01:00
Joas Schilling
1f9a5c0d7f
Remove resolved FIXME
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv)
720e64ba55
Fixed caldav tests and metadata 2
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv)
d80f13ef99
Fix Metadata tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv)
9440e9bb1e
Fixed Controller Test
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv)
e6a7a9f251
Fixed select2 workflow
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv)
ddcd37121f
Fix users loading on group click and group creation on select
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:49 +01:00
John Molakvoæ (skjnldsv)
00122fa027
Use group displayNames in users list
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:49 +01:00
Joas Schilling
cb2fbdd214
Fix group display name in the sidebar of the user management
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
Joas Schilling
db9b2398dd
Fix group displaynames in activity
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
Joas Schilling
0e2366233a
Start fixing Select2 options
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
Joas Schilling
82137f443d
Correctly return the group name
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:48 +01:00
Joas Schilling
aef86a5f5a
Show the displayname in the users group list
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:48 +01:00
Christoph Wurst
b9720703e8
Add CSRF token controller to retrieve the current CSRF token
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-03-08 16:48:50 +01:00
Joas Schilling
882096653e
Fix calculation if there are more results
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 16:22:16 +01:00
Daniel Calviño Sánchez
c1fa0f8b86
Add automatic handling of NoSuchElement exceptions
...
NoSuchElement exceptions are sometimes thrown instead of
StaleElementReference exceptions. This can happen when the Selenium2
driver for Mink performs an action on an element through the WebDriver
session instead of directly through the WebDriver element. In that case,
if the element with the given ID does not exist, a NoSuchElement
exception would be thrown instead of a StaleElementReference exception,
so those cases are handled like StaleElementReference exceptions.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-08 14:54:01 +01:00
Daniel Calviño Sánchez
deb2495f89
Add automatic handling of MoveTargetOutOfBounds exceptions
...
MoveTargetOutOfBounds exceptions are sometimes thrown instead of
ElementNotVisible exceptions. This can happen when the Selenium2 driver
for Mink moves the cursor on an element using the "moveto" method of the
Webdriver session, for example, before clicking on an element. In that
case, if the element is not visible, "moveto" would throw a
MoveTargetOutOfBounds exception instead of an ElementNotVisible
exception, so those cases are handled like ElementNotVisible exceptions.
Note that MoveTargetOutOfBounds exceptions could be thrown too if the
element was visible but "out of reach"; there is no problem in handling
those cases as if the element was not visible, as the exception will be
thrown again anyway once it is verified that the element is indeed
visible.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-08 14:53:15 +01:00
Joas Schilling
3d7ae4aa97
Add tests for finding own email and user results pagination
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 13:26:26 +01:00
Morris Jobke
cccf6f4d5f
Merge pull request #8221 from Cybso/8220_applyLdapUserFilter_on_members
...
Apply ldapUserFilter on members of group
2018-03-08 13:19:02 +01:00
Robin Appelman
f5ef9e02b2
emit pre-hooks earlier when not using part files
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-08 13:02:35 +01:00
Morris Jobke
a2db959f5c
Merge pull request #8593 from eneiluj/master
...
Allow public page access to apps with group restrictions
2018-03-08 11:27:52 +01:00
Roeland Jago Douma
3ad7daeda5
Add tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-08 11:05:18 +01:00
John Molakvoæ (skjnldsv)
cee5be6ff2
Fixed jsunit
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 10:31:33 +01:00
Roeland Jago Douma
340e8ef16c
Make SecurityMiddleware strict
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-08 10:11:47 +01:00
Morris Jobke
069e3f50a7
Merge pull request #8711 from nextcloud/objectstore-write-only-fopen
...
don't read existing file when overwriting using object store
2018-03-08 09:32:39 +01:00
Roeland Jago Douma
af55b03386
Merge pull request #8662 from nextcloud/better-debugging-unit-tests
...
Better debugging for "Your test case is not allowed to access the dat…
2018-03-07 21:53:34 +01:00
John Molakvoæ (skjnldsv)
3ef4131533
Fixed event propagation on safari
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 17:10:46 +01:00
Joas Schilling
1dd40b1f45
Single quotes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-07 16:50:18 +01:00
Joas Schilling
559978c50e
Suppress phan error
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-07 16:43:16 +01:00
John Molakvoæ (skjnldsv)
e1ec4514cc
Use label for better focus on external share
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:28:03 +01:00
John Molakvoæ (skjnldsv)
5dbd09f07c
Align radio & checkboxes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:17:54 +01:00
John Molakvoæ (skjnldsv)
446a3a9d5a
Fixed ext share style and use varable for popover height
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:12:06 +01:00
Julius Härtl
573b940761
Use cache prefix for theming as well
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Julius Härtl
95366bbd1f
Fix tests to use ICacheFactory
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Julius Härtl
63e261b444
Actually clear cache values for all base urls
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Julius Härtl
f652c28b21
Use JSCombiner from server container when searching for JS files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00