wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
47023 commits 157 branches 562 tags 714 MiB
Commit graph

47023 commits

This branch
This branch
All branches
Author SHA1 Message Date
Daniel Calviño Sánchez
e39db808fb Fix rendering of the sidebar in Files app 
When a view is rendered it should not be concerned with where it is
going to be placed in the document; in general this should be a
responsibility of the object using the view.

Moreover, when the details view is rendered it should simply prepare a
skeleton that includes the root elements provided by the plugins; those
elements will be updated by the plugins as needed when a file or a tab
is selected.

Finally, the details view should not be explicitly rendered. The
rendering removes the previous elements, but that is needed only when
the details view is in a dirty state, that is, when new plugins were
added since the last time that it was rendered. However, that dirty
state is internally handled, and the view is automatically rendered
again if needed when a file info is set.

Due to all that the details view is no longer explicitly rendered when
updating it with a different file. Also, as each file list has its own
details view, and each details view has its own element, but there can
be only one details view/sidebar element in the document, when the file
list updates the details view it also replaces the current one in the
document with its own details view if needed (that is, if it is not the
current one already).

Besides that, when the element of a details view is replaced with the
element of a different details view the old one should be detached from
the document, but never removed. Otherwise the event handlers would not
work when that element is attached again later (when changing to a
different section in the Files app and then going back to the previous
one).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-22 05:58:25 +01:00
Daniel Calviño Sánchez
1d1708688f Add acceptance tests for showing again the input field for tags 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-22 05:26:45 +01:00
Daniel Calviño Sánchez
57ffa9ea73 Add acceptance tests for opening and closing again the details view 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-22 05:26:01 +01:00
Daniel Calviño Sánchez
94645ed754 Add acceptance tests for marking a file as favorite in the details view 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-22 05:25:12 +01:00
Daniel Calviño Sánchez
139e2218d1 Add acceptance tests for switching to the comments of another file 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-22 05:20:26 +01:00
Nextcloud bot
f3fb6676e9
[tx-robot] updated from transifex 2018-11-22 01:12:20 +00:00
Roeland Jago Douma
8c9e78d8b1
Merge pull request #12570 from nextcloud/do-not-show-tab-headers-marked-as-hidden 
Do not show tab headers marked as hidden
 2018-11-21 22:34:41 +01:00
Jan-Christoph Borchardt
d94fce8d3a
Fix wording of client sessions 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-11-21 16:02:26 +01:00
Daniel Calviño Sánchez
7a57409f7d Do not show tab headers marked as hidden 
Tab headers that should not be shown are marked with the "hidden" CSS
class. The CSS rules set "display: none" for ".hidden" elements, but as
the rules for ".tabHeaders .tabHeader" are more specific than rules for
".hidden" the "display" property is overriden and ends being "flex".
Therefore, it is necessary to explicitly set a rule for ".tabHeaders
.tabHeader.hidden" elements.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-21 15:21:22 +01:00
Jan-Christoph Borchardt
f80a023431
Always give primary button a border for light primary colors 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-11-21 14:30:05 +01:00
Nextcloud bot
b7767a51f1
[tx-robot] updated from transifex 2018-11-21 01:12:15 +00:00
Roeland Jago Douma
b150d27edf
Merge pull request #12531 from nextcloud/bugfix/noid/hide-download-folders 
Allow to hide download option for folders shared by link
 2018-11-20 20:51:23 +01:00
Julius Härtl
78056a3bef
Fix whitespace and file action cleanup 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-11-20 19:46:49 +01:00
Roeland Jago Douma
fc99811d0a
Clear link to avoid downloads 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-11-20 19:46:49 +01:00
Roeland Jago Douma
61c869675d
Compile handlebars 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-11-20 19:46:49 +01:00
Julius Härtl
fb8aa31dbf
Allow to hide download option for folders shared by link 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-11-20 19:46:35 +01:00
John Molakvoæ (skjnldsv)
28afcaad03
Better header navigation display 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-20 18:39:54 +01:00
Jan-Christoph Borchardt
325396330c
Apply border to primary button if on log in page (and not in a dark container) or if in header, fix #12294 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-11-20 17:01:51 +01:00
Roeland Jago Douma
1bf742c462
Merge pull request #12544 from nextcloud/fix/better_update_share_handling 
Handle permission in update of share better
 2018-11-20 16:19:11 +01:00
Roeland Jago Douma
e73bfd5331
Merge pull request #12552 from nextcloud/fix/11146/respect_disabled_password_reset 
Respect the disabled setting for lost_password_link
 2018-11-20 15:52:32 +01:00
John Molakvoæ
ebc690bbe3
Merge pull request #12491 from nextcloud/share-menu-click-fix 
Fix share link password input
 2018-11-20 15:35:22 +01:00
John Molakvoæ (skjnldsv)
7a9ea03943
Fix share link password input 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-20 14:40:40 +01:00
Joas Schilling
b8fcf6e9b3
Allow empty strings in getAbsoluteURL 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-11-20 13:36:16 +01:00
Joas Schilling
2b18b9ae96
Update the URLGenerator test to current state of art 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-11-20 13:36:15 +01:00
Morris Jobke
a9de88e96e
Merge pull request #12350 from nextcloud/filepicker-sorting 
Enable sorting in file picker
 2018-11-20 13:34:51 +01:00
Roeland Jago Douma
43d6ae7476
Respect the disabled setting for lost_password_link 
Fixes #11146
As documented when it is set to disabled the user can't request a lost
password.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-11-20 13:28:40 +01:00
Morris Jobke
53418f2795
Merge pull request #12543 from nextcloud/fix/12498/bearer_tokens_are_apptokens 
Bearer tokens are app token
 2018-11-20 11:49:33 +01:00
Morris Jobke
cc6c30e769
Merge pull request #12494 from nextcloud/cache-notfound-id 
return the correct value when trying to get a non existing item from cache by id
 2018-11-20 09:51:18 +01:00
Morris Jobke
8e65f08617
Merge pull request #12500 from nextcloud/swift-object-not-found 
forward object not found error in swift as dav 404
 2018-11-20 09:49:57 +01:00
Roeland Jago Douma
a343a60a68
Handle permission in update of share better 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-11-20 09:42:01 +01:00
Morris Jobke
2be8930cdf
Merge pull request #12539 from nextcloud/fix-redirect-design 
Fix redirect page design details
 2018-11-20 09:34:15 +01:00
Roeland Jago Douma
c2beb36bfc
Bearer tokens are app token 
Fixes #12498

This means that we set that it is a proper app token once it is
validated. This will allow the 2FA middleware to just run the same
check.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-11-20 09:23:57 +01:00
Nextcloud bot
c9af398644
[tx-robot] updated from transifex 2018-11-20 01:12:39 +00:00
Jan-Christoph Borchardt
256f989a71
Fix CSS specificity preventing buttons displayed in pill style 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-11-19 21:56:38 +01:00
Jan-Christoph Borchardt
4c2dad9ec4
Fix header text color on redirect page 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-11-19 21:54:37 +01:00
Robin Appelman
aa6f7947ba
add test for non existing file by id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-11-19 17:37:59 +01:00
Morris Jobke
1d8f7e7806
Merge pull request #12525 from nextcloud/contrast-fix-updatenotifications 
Fix updatenotifications display, dependencies and csp
 2018-11-19 16:05:50 +01:00
Morris Jobke
cef8eadf2a
Add PHPDoc for thrown exception 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-19 15:34:07 +01:00
Morris Jobke
7ea7eb0b4a
Merge pull request #12495 from nextcloud/login-theming-primary-fix 
Fix login primary colour and feedback
 2018-11-19 15:26:40 +01:00
Morris Jobke
5af6289959
Merge pull request #12401 from pachulo/fix/11107/fix-php-mail-warning 
Fix the warning appearing in the admin section when mail_smtpmode is not configured
 2018-11-19 15:23:45 +01:00
Morris Jobke
802e4a79d1
JSUnit tests are not compatible with let/const yet 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-19 15:22:10 +01:00
Morris Jobke
85a491a6fb
Translate name for "(copy)" 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-19 13:57:27 +01:00
Ido Green
313aee91ca
Per the last comment on having only (copy) for the first one 
Signed-off-by: Ido Green <greenido@gmail.com>
 2018-11-19 13:57:23 +01:00
Ido Green
48d74482c1
Use the new naming per the comments on #9931 
More details here: https://github.com/nextcloud/server/issues/9931#issuecomment-402318120

Signed-off-by: Ido Green <greenido@gmail.com>
 2018-11-19 13:57:17 +01:00
Ido Green
c320f48599
cleaning after comments on issue 10825 
More: https://github.com/nextcloud/server/pull/10825#issuecomment-415800850

Signed-off-by: Ido Green <greenido@gmail.com>
 2018-11-19 13:57:13 +01:00
Ido Green
c794452689
fixing issue 9931 - copy a file to the same directory 
Signed-off-by: Ido Green <greenido@gmail.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-19 13:56:40 +01:00
John Molakvoæ (skjnldsv)
3b16a76ba0
Fix login primary colour and feedback 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-19 13:19:59 +01:00
Robin Appelman
35251928d5
forward object not found error in switch as dav 404 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2018-11-19 11:34:38 +01:00
Morris Jobke
8e4f0f9d17
Use the proper default values 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-11-19 10:57:51 +01:00
Morris Jobke
ea46c111a0
Merge pull request #12515 from nextcloud/papercut/12295/grid-view-lazy-loading 
Make number of file list entries depending on the width for grid view
 2018-11-19 10:52:54 +01:00