Commit graph

46839 commits

Author SHA1 Message Date
Morris Jobke
0999f07964
Merge pull request #12052 from nextcloud/bugfix/11594/fix-setup-check-trusted-proxies
Fix setup check trusted proxies
2018-10-29 23:38:37 +01:00
Morris Jobke
2d50478492
Merge pull request #12127 from nextcloud/fix/proper_folder_mimetype
A folder should get a folder mimetype
2018-10-29 23:28:39 +01:00
Roeland Jago Douma
90dc8fb42e
A folder should get a folder mimetype
If doing achunked upload the mimetype of the folder would otherwise be
guessed from the path. Which always returned application/octet-stream.

If an access control rule to block that is in place this means that all
chunked uploads fail hard in directories as the isCreatable on the
directory always fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-29 21:35:08 +01:00
Morris Jobke
963d968f06
Merge pull request #12113 from nextcloud/fileinfo-getextension
Add getExtension() to FileInfo
2018-10-29 17:23:27 +01:00
Morris Jobke
76c31857cb
Merge pull request #12107 from nextcloud/fix/12086/no-unintentional-empty-attributes
remove unneeded empty LDAP search attribute values
2018-10-29 17:00:14 +01:00
Roeland Jago Douma
3aae3c82a4
Merge pull request #12041 from nextcloud/gridfixes
Properly hide files when searching
2018-10-29 16:12:44 +01:00
John Molakvoæ
c05e8acdb1
Merge pull request #12019 from nextcloud/icons-svg-api-fixes
Move svg api endpoint
2018-10-29 15:45:45 +01:00
Robin Appelman
e5c3e4b76f
Add getExtension() to FileInfo
this is a fairly common operation so it makes sense to prevent having
to repeatedly implement it.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-29 15:24:02 +01:00
Roeland Jago Douma
4a642fc004
Merge pull request #12106 from nextcloud/bugfix/noid/federated-settings-logo
Fix logo path in personal federated sharing settings
2018-10-29 14:54:20 +01:00
Roeland Jago Douma
f36e42e098
Merge pull request #12100 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.23.1
Bump webpack from 4.22.0 to 4.23.1 in /settings
2018-10-29 14:53:11 +01:00
John Molakvoæ (skjnldsv)
c0477afb5d
Properly hide files when searching
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-29 14:51:29 +01:00
Roeland Jago Douma
4807e9079e
Merge pull request #12097 from nextcloud/dependabot/npm_and_yarn/settings/vue-infinite-loading-2.4.0
Bump vue-infinite-loading from 2.3.5 to 2.4.0 in /settings
2018-10-29 14:31:45 +01:00
Roeland Jago Douma
956bd19d58
Merge pull request #12104 from nextcloud/move-acceptance-tests-that-crash-the-php-built-in-server-to-apache
Move acceptance tests that crash the PHP built-in server to Apache
2018-10-29 14:28:42 +01:00
Arthur Schiwon
d47e1513bc
remove unneeded empty search attribute values, fixes #12086
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-29 13:21:02 +01:00
Julius Härtl
4dda244ce2
Fix logo path in personal federated sharing settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 13:18:39 +01:00
John Molakvoæ
c58b935bf5
Merge pull request #11993 from nextcloud/headings-standards
Headings standard
2018-10-29 13:15:55 +01:00
Julius Härtl
34a71f57fc
Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 13:06:55 +01:00
dependabot[bot]
91d33054bb
Bump webpack from 4.22.0 to 4.23.1 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 11:59:23 +00:00
Roeland Jago Douma
0ee7ffcde1
Merge pull request #12099 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.23.1
Bump webpack from 4.22.0 to 4.23.1 in /apps/oauth2
2018-10-29 12:57:27 +01:00
Daniel Calviño Sánchez
565556b277 Move acceptance tests that crash the PHP built-in server to Apache
The PHP built-in server can crash when certain actions are performed in
Nextcloud (but although the crash is triggered by Nextcloud it does not
seem to be a Nextcloud bug), which can lead to failures in the
acceptance tests that would have otherwise passed.

A crash of the PHP built-in server during an acceptance test can be
identified by the message "sh: 1: kill: No such process" in the
acceptance tests output; as the PHP built-in server crashed its process
does no longer exist when it is tried to be killed when the scenario
ends.

Although the crash has been observed in other tests too it is more
prevalent in the tests for tags and the theming app. In order to
reduce the false positives those tests are now run on Apache instead of
on the PHP built-in sever. However, the rest of tests are still run on
the PHP built-in server due to its lower resource consumption.

In order to run a feature or just a scenario using Apache it has to be
tagged with "@apache"; features or scenarios without that tag (the
default) will run on the PHP built-in server instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-29 12:38:42 +01:00
Daniel Calviño Sánchez
34f397fd22 Link the default Apache directory to the Nextcloud server in all runners
In order to run the acceptance tests in Apache "/var/www/html" has to be
linked to the root directory of the Nextcloud server. Before this was
automatically done when launching the acceptance tests through
"./run.sh", but an explicit command was needed when run in Drone. Now
the linking was moved from "run.sh" to "run-local.sh", so it is
automatically done when run through "./run.sh" and in Drone, including
when running the tests for an app instead of for the server.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-29 12:38:42 +01:00
Julius Härtl
4b7ef668a4
Adjust accessibility app color replacement
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 12:09:44 +01:00
Julius Härtl
aec0a6c096
Fix icon cacher url matching
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 12:09:30 +01:00
John Molakvoæ (skjnldsv)
5c74423902
Move svg api endpoint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-29 11:45:13 +01:00
dependabot[bot]
8c202f3af1
Bump webpack from 4.22.0 to 4.23.1 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 10:43:49 +00:00
John Molakvoæ
0c89dd2197
Merge pull request #12076 from trendzetter/patch-3
Add missing tag
2018-10-29 11:32:39 +01:00
Roeland Jago Douma
3aac778f9a
Merge pull request #12098 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.23.1
Bump webpack from 4.22.0 to 4.23.1 in /apps/updatenotification
2018-10-29 11:16:35 +01:00
dependabot[bot]
55f94695d0
Bump webpack from 4.22.0 to 4.23.1 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 08:22:25 +00:00
Roeland Jago Douma
972f4191f4
Merge pull request #12096 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.23.1
Bump webpack from 4.22.0 to 4.23.1 in /apps/accessibility
2018-10-29 09:19:35 +01:00
Daniel Calviño Sánchez
95dc2ad13c Extract acceptance tests for tags to their own feature file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-29 08:40:05 +01:00
dependabot[bot]
5b1aa559c0
Bump vue-infinite-loading from 2.3.5 to 2.4.0 in /settings
Bumps [vue-infinite-loading](https://github.com/PeachScript/vue-infinite-loading) from 2.3.5 to 2.4.0.
- [Release notes](https://github.com/PeachScript/vue-infinite-loading/releases)
- [Commits](https://github.com/PeachScript/vue-infinite-loading/compare/v2.3.5...v2.4.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 01:16:10 +00:00
Nextcloud bot
18fef12721
[tx-robot] updated from transifex 2018-10-29 01:13:07 +00:00
dependabot[bot]
0e750aa3c9
Bump webpack from 4.22.0 to 4.23.1 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-28 18:28:05 +00:00
Morris Jobke
8c7432fa6d
Merge pull request #12063 from nextcloud/bring-the-browser-window-of-an-actor-to-the-foreground-when-acting-as-him
Bring the browser window of an actor to the foreground when acting as him
2018-10-28 13:57:46 +01:00
John Molakvoæ (skjnldsv)
371cf29f0c
fixup! Cleanup
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-28 10:44:45 +01:00
Nextcloud bot
13abee2836
[tx-robot] updated from transifex 2018-10-28 00:12:49 +00:00
Bjoern Schiessle
85d9f06cb8
add global site selector as user back-end which doesn't support password confirmation
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-27 15:43:51 +02:00
Nextcloud bot
0092e3adec
[tx-robot] updated from transifex 2018-10-27 00:12:35 +00:00
trendzetter
56b0d3d234
Add missing tag
Add missing closing tag for span.

Signed-off-by: Joris Willems <joris.willems@gmail.com>
2018-10-26 21:22:44 +02:00
blizzz
6fcaa6fb9f
Merge pull request #12068 from stweil/lgtm
Fix off-by-one bugs
2018-10-26 18:06:02 +02:00
Arthur Schiwon
05f909dcf3
fixes wrong variable usage
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-26 18:03:41 +02:00
Stefan Weil
a226f65aa2 Fix off-by-one bugs
This fixes warnings from LGTM:

    Off-by-one index comparison against length may lead
    to out-of-bounds read.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-26 17:31:42 +02:00
Morris Jobke
31c3814b0a
Merge pull request #12038 from nextcloud/assemblystream_size
Implement the size of an assembly stream
2018-10-26 17:02:16 +02:00
Morris Jobke
50b7a68f02
Merge pull request #12044 from nextcloud/dependabot/composer/build/integration/sabre/dav-3.2.3
Update sabre/dav requirement from 3.2.2 to 3.2.3 in /build/integration
2018-10-26 14:22:53 +02:00
Daniel Calviño Sánchez
f844799d9b Move the browser window of an actor to the foreground when acting as him
Each time a new actor appears in a scenario the browser window of the
new actor is put in front of the browser windows of the previous actors.
Before, when acting again as a previous actor his browser window stayed
in the background; in most cases everything worked fine even if the
window was in the background, but due to a bug in the Firefox driver of
Selenium and/or maybe in Firefox itself when the window was in the
background it was not possible to set the value of an input field that
had a range selected.

Now, when acting again as a previous actor his browser window is brought
to the foreground. This prevents the bug from manifesting, but also
reflects better how a user would interact with the browser in real life.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-26 11:07:13 +02:00
Roeland Jago Douma
70e4884e02
Implement the size of an assembly stream
This will make it possible to act propely on moves of future files if we
need to know the size (like for max size virus scanning).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-26 10:43:11 +02:00
Morris Jobke
7aa76a82bc
Merge pull request #12053 from nextcloud/enhancement/10923/remove-unncessary-check
remove LDAP::hasPagedResultSupport() from PHP < 5.4 days
2018-10-26 10:28:47 +02:00
Nextcloud bot
aff53d6e34
[tx-robot] updated from transifex 2018-10-26 00:12:48 +00:00
Arthur Schiwon
bbe44108b5
only write when the displayname differs, but then announce it
refs #5212 and fixes #9112

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 23:41:12 +02:00
Morris Jobke
61c38885c7
Merge pull request #11940 from nextcloud/maintenance-design
Adjust design of maintenance mode page
2018-10-25 23:07:46 +02:00