Commit graph

46381 commits

Author SHA1 Message Date
Daniel Kesselberg
5cf8f4a407
Update logic for forwardedForHeadersWorking
As discussed in https://github.com/nextcloud/server/issues/11594 when discovering if
x-forwarded-for is working properly its not possible to use getRemoteAddr because
the "client ip" is returned. For this check the ip of the last hop would be required.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-25 23:01:37 +02:00
Arthur Schiwon
2048872f9e
functions that were checked for are present since PHP 5.4, supported is >=/
* so the check from older days is really not necessary anymore
* resolves #10923

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 22:50:42 +02:00
Daniel Kesselberg
986f4df2a5
Add REMOTE_ADDR to getHeader
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-25 22:26:49 +02:00
Jan-Christoph Borchardt
50b9dd66b7
Adjust design of maintenance mode page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-25 17:55:35 +02:00
dependabot[bot]
2793f174ac
Update sabre/dav requirement from 3.2.2 to 3.2.3 in /build/integration
Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/commits/3.2.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-25 15:52:24 +00:00
Morris Jobke
6ad7f32938
Merge pull request #12016 from nextcloud/wip/noid/icon-base64
Directly embed icons into the icon-vars css file
2018-10-25 16:04:23 +02:00
Morris Jobke
0a2476fcb3
Merge pull request #11988 from nextcloud/docs/jsdoc-build
JSdoc build fixes and move build script out of the root folder
2018-10-25 15:49:27 +02:00
Julius Härtl
b09f7ad822
Remove buildjsdocs.sh from files checker
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 14:33:52 +02:00
Morris Jobke
116268a2b5
Merge pull request #11893 from caugner/7837-filesize-format-with-locale
Formats file sizes using the user's locale
2018-10-25 14:05:20 +02:00
Morris Jobke
49c49d5848
Merge pull request #12039 from nextcloud/fix-javascript-unit-tests-for-versionmodel-js
Fix JavaScript unit tests for "versionmodel.js"
2018-10-25 14:03:19 +02:00
Daniel Calviño Sánchez
661756b02a Set error expected by the DAV client for a failed move
A revert triggers a move in the DAV client, and the DAV client expects a
DAV error message to be provided by the server in case of failure; if
no error message is given the client ends trying to get an attribute
from an undefined object and "crashes".

Besides that, if the revert fails the "done" callback of the promise
(the first parameter of "then") is never called, so a "fail" callback
should be used instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 13:07:06 +02:00
Daniel Calviño Sánchez
24abfd8869 Wait for the promise to be fulfilled before running the next test
In Jasmine 2.5 the "it" function takes an optional parameter that should
be called when the async work is completed (returning a promise was
introduced in Jasmine 2.7, so it is not supported yet in the tests). If
the parameter is not declared then the next test is executed without
waiting for the asynchronous work in the previous one to finish, which
could cause that asynchronous work to finish while a different test is
being run.

Note that if that happens the test could still work as expected if it
relied only in local variables. However, in the case of the successful
revert tests, the stubs being checked are not the ones created when that
test was initialized, but the ones created when the next test, the
failed revert test, was initialized and the previous variables were
replaced (although the model itself calls the proper stubs, as they are
set through parameters in function calls).

Besides all that, the checks in the failed revert test were never
executed due to a different problem which will be fixed in the next
commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 12:25:41 +02:00
Julius Härtl
d21ded67a7
Keep list of icons in a separate file for use in the accessibility app
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 12:16:10 +02:00
Julius Härtl
0b2ef7e608
Remove default which didn't work
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 11:58:00 +02:00
Julius Härtl
152fb08288
Properly track data urls as well
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 11:58:00 +02:00
Julius Härtl
845f1b67d5
Directly embed icons into the icon-vars css file
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 11:58:00 +02:00
Nextcloud bot
58fde16226
[tx-robot] updated from transifex 2018-10-25 00:13:01 +00:00
Morris Jobke
88904200e0
Merge pull request #11889 from stweil/lgtm
Remove replace call which does not replace anything
2018-10-24 23:55:55 +02:00
Morris Jobke
efee3b149d
Merge pull request #12022 from nextcloud/fix/11485/fix_chuncked_uploads
Allow chunked uploads even if your quota is not sufficient
2018-10-24 23:48:17 +02:00
Roeland Jago Douma
0fb070b5b4
Allow chunked uploads even if your quota is not sufficient
Fixes #11485

This allows uploads to shared folders.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-24 20:29:00 +02:00
Morris Jobke
410bd9d784
Merge pull request #12018 from nextcloud/improve-encrypt-all
Improve encrypt all / decrypt all
2018-10-24 18:27:03 +02:00
Bjoern Schiessle
d76a87f3b0
skip already decrypted files on decrypt all command
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-24 16:53:39 +02:00
Bjoern Schiessle
87657fffd8
skip already encrypted files on encrypt all command
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-24 16:53:39 +02:00
Julius Härtl
d14434fa2e
Adjust some jsdocs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 16:24:16 +02:00
Julius Härtl
5d888984a0
Fix jsdocs build on server repo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 15:41:08 +02:00
Morris Jobke
37782b1084
Merge pull request #11573 from nextcloud/gridview-table
Files grid view
2018-10-24 15:31:23 +02:00
Morris Jobke
2ec5d2a6de
Merge pull request #11533 from nextcloud/accessibility-cache-fixes
Added cache override to ensure an always up-to-date accessibility css
2018-10-24 15:04:29 +02:00
Stefan Weil
a13c80062d Remove replace call which does not replace anything
The original code replaced / by /.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-24 14:53:52 +02:00
Morris Jobke
df6e9109c8
Merge pull request #11396 from nextcloud/wellknown-webfinger
adding .well-known/webfinger
2018-10-24 14:51:15 +02:00
Morris Jobke
37718ddc0a
Merge pull request #11891 from stweil/scrutinizer
Migrate Scrutinizer to new PHP Analysis
2018-10-24 14:02:19 +02:00
Roeland Jago Douma
5cdc85cf66
Merge pull request #12013 from nextcloud/bugfix/noid/accountmanager
Fix small issues with IAccountManager API
2018-10-24 13:49:00 +02:00
Roeland Jago Douma
b3a0d87117
Merge pull request #10888 from nextcloud/bug/noid/fix-missing-quickaccess-favorite-folder-on-add
Bug/noid/fix missing quickaccess favorite folder on add
2018-10-24 13:45:40 +02:00
Julius Härtl
f47f5ad0ea
Allow property filters to be null
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 12:54:01 +02:00
Julius Härtl
86f29ffdbc
Register IAccountManager as a service
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 12:53:43 +02:00
Julius Härtl
3b3824c486
Use empty string instead of null
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 12:53:18 +02:00
Claas Augner
d5e142a336
OC.getCanonicalLocale: fix tests
Signed-off-by: Claas Augner <git@caugner.de>
2018-10-24 11:17:58 +02:00
Claas Augner
00b8be60f2
humanFileSize: use toLocaleString
humanFileSize: add test with locale
humanFileSize: use canonical locale
humanFileSize: skip test w/o toLocaleString support
humanFileSize: stub getCanonicalLocale
OC.getCanonicalLocale: cover undefined case
humanFileSize: fix getCanonicalLocale stub

Signed-off-by: Claas Augner <git@caugner.de>
2018-10-24 09:18:39 +02:00
Nextcloud bot
ded746f821
[tx-robot] updated from transifex 2018-10-24 00:12:31 +00:00
Roeland Jago Douma
b853102a8f
Merge pull request #11886 from nextcloud/feature/noid/principal_search_displayname
Principal property search for users and groups with {DAV:}display name
2018-10-23 21:26:31 +02:00
Roeland Jago Douma
41fbda00ed
Merge pull request #11928 from stweil/fix
Fix use of undeclared variable
2018-10-23 21:15:53 +02:00
Roeland Jago Douma
530e39b061
Merge pull request #11778 from nextcloud/versions-webui-dav
move versions webui over to the dav api
2018-10-23 20:21:05 +02:00
Roeland Jago Douma
97ad1ba381
Merge pull request #11985 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.9.4
Bump node-sass from 4.9.3 to 4.9.4 in /build
2018-10-23 20:06:19 +02:00
Morris Jobke
f18db1657c
Merge pull request #11906 from kevin147147/patch-5
make scroll navigation items full width
2018-10-23 19:54:37 +02:00
John Molakvoæ (skjnldsv)
ede6472e52
Fix FF performance and recals issues
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 18:07:15 +02:00
Morris Jobke
4ad27260a9
Merge pull request #11439 from nextcloud/trash-modular-api
Modular trashbin api
2018-10-23 17:11:16 +02:00
Morris Jobke
e0f9257be9
Merge pull request #11847 from iPaat/Fix/DeleteCookiesThroughClearSiteData
Remove cookies from Clear-Site-Data Header
2018-10-23 17:04:45 +02:00
John Molakvoæ (skjnldsv)
8013dab044
Allow focus on input with keyboard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 17:00:47 +02:00
Nextcloud bot
a9fb21f9fc
[tx-robot] updated from transifex 2018-10-23 14:54:28 +00:00
John Molakvoæ (skjnldsv)
cf57df6e73
Restore table head
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:46:45 +02:00
John Molakvoæ (skjnldsv)
b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00