wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
23334 commits 157 branches 562 tags 714 MiB
Commit graph

3016 commits

Author SHA1 Message Date
Lukas Reschke
ceaa193df2 Merge pull request #14273 from owncloud/require-at-least-apcu-4-0-6 
Use APCu only if available in version 4.0.6 and higher
 2015-02-18 01:07:54 +01:00
Morris Jobke
5d7d2adcbf Merge pull request #14207 from owncloud/propfind-optimize 
Optimize quota calculation for propfind
 2015-02-18 00:18:47 +01:00
Victor Dubiniuk
090db867d5 Add mapping for a broken varchar type. Fixes #14247 2015-02-17 23:22:57 +03:00
Robin Appelman
e672f8cc8f Use appmanager in OC_App::enable/disable 2015-02-17 15:05:29 +01:00
Robin Appelman
04628cf368 better name for getAppsEnabledForUser 2015-02-17 15:05:29 +01:00
Robin Appelman
434835b326 also set user in UserSession when doing OC_User::setUserId 2015-02-17 15:05:29 +01:00
Robin Appelman
409453bc60 better user group caching 2015-02-17 15:05:29 +01:00
Robin Appelman
5c68c81d00 Update cache when enabling/disabling apps 2015-02-17 15:05:25 +01:00
Lukas Reschke
b701bbd8c5 Use APCu only if available in version 4.0.6 and higher 
APCu before 4.0.6 is unbelievable buggy and tend to segfault the PHP process (i.e. the whole webserver)

This potentially fixes https://github.com/owncloud/core/issues/14175

Requires a backport to stable8
 2015-02-17 13:28:02 +01:00
Christian Seiler
535757bc42 DAV authentication: also use Owncloud's internal user for short-circuit 
It still works otherwise, but without this, the performance optimization
of #13416 is defeated in these situations.
 2015-02-16 23:47:39 +01:00
Christian Seiler
1377ebc7e9 DAV authentication: use Owncloud's internal user instead of HTTP-supplied one 
Fixes: #14048, #14104, calendar#712
 2015-02-16 23:34:49 +01:00
Lukas Reschke
cebf9f6a5a Incorporate review changes 2015-02-16 22:13:03 +01:00
Lukas Reschke
992164446c Add blackmagic due to cyclic dependency 🙈 2015-02-16 22:13:01 +01:00
Lukas Reschke
9f91d64918 Make scrutinizer happy 2015-02-16 22:13:00 +01:00
Lukas Reschke
886bda5f81 Refactor OC_Request into TrustedDomainHelper and IRequest 
This changeset removes the static class `OC_Request` and moves the functions either into `IRequest` which is accessible via `\OC::$server::->getRequest()` or into a separated `TrustedDomainHelper` class for some helper methods which should not be publicly exposed.

This changes only internal methods and nothing on the public API. Some public functions in `util.php` have been deprecated though in favour of the new non-static functions.

Unfortunately some part of this code uses things like `__DIR__` and thus is not completely unit-testable. Where tests where possible they ahve been added though.

Fixes https://github.com/owncloud/core/issues/13976 which was requested in https://github.com/owncloud/core/pull/13973#issuecomment-73492969
 2015-02-16 22:13:00 +01:00
Victor Dubiniuk
bdfc9b57bd Skip primary index if the table has one 2015-02-16 20:30:28 +01:00
Jörn Friedrich Dreyer
87db136508 add debug log for memcache instantiation 2015-02-16 18:05:43 +01:00
Morris Jobke
5a5d6bf4db Merge pull request #14128 from owncloud/drop-unused-methods 
Remove unused function and correct PHPDoc
 2015-02-16 17:37:36 +01:00
Thomas Müller
9271059195 Merge pull request #13750 from owncloud/enhanced-code-checker 
Implement php code checker to detect usage of not allowed private ...
 2015-02-16 16:55:57 +01:00
Joas Schilling
8eb804b1f6 Merge pull request #13269 from owncloud/issue/13211-cache-array-implementation 
Add an array implementation of cache and use it if we are not debugging
 2015-02-16 15:35:20 +01:00
Robin Appelman
23ab25e93a Use the app manager from oc_app 2015-02-16 15:16:13 +01:00
Robin Appelman
2b58e8489f Add getInstalledApps and getAppsForUser to the app manager 2015-02-16 15:15:35 +01:00
Thomas Müller
9c47ab91f2 Merge pull request #14194 from owncloud/url-encode-logout-attribute 
URLEncode logout attribute
 2015-02-16 15:04:20 +01:00
Joas Schilling
8848b5f067 Add an array implementation of cache and use it if we are not debugging 2015-02-16 14:55:50 +01:00
Lukas Reschke
c6705ab574 Merge pull request #13890 from owncloud/add-no-referrer 
Add `rel="noreferrer"` where possible and switch to HTTPS
 2015-02-16 14:36:44 +01:00
Lukas Reschke
7e45f5d27b Remove unused function and correct PHPDoc 2015-02-16 13:46:45 +01:00
Lukas Reschke
8791f1992e Add noreferrer to footer URI 2015-02-16 13:37:54 +01:00
Thomas Müller
78febb2ee5 Merge pull request #14201 from owncloud/propagator-dont-decrease-mtime 
Dont lower the mtime of a folder when propagating changes
 2015-02-16 11:32:17 +01:00
Lukas Reschke
b20174bdad Allow AppFramework applications to specify a custom CSP header 
This change allows AppFramework applications to specify a custom CSP header for example when the default policy is too strict. Furthermore this allows us to partially migrate away from CSS and allowed eval() in our JavaScript components.

Legacy ownCloud components will still use the previous policy. Application developers can use this as following in their controllers:
```php
$response = new TemplateResponse('activity', 'list', []);
$cspHelper = new ContentSecurityPolicyHelper();
$cspHelper->addAllowedScriptDomain('www.owncloud.org');
$response->addHeader('Content-Security-Policy', $cspHelper->getPolicy());
return $response;
```

Fixes https://github.com/owncloud/core/issues/11857 which is a pre-requisite for https://github.com/owncloud/core/issues/13458 and https://github.com/owncloud/core/issues/11925
 2015-02-16 11:00:41 +01:00
Thomas Müller
d5ca5c7bcc Merge pull request #14138 from owncloud/fix-image-flip-php53 
Don't flip image in PHP 5.4
 2015-02-16 10:26:56 +01:00
Robin Appelman
9abaa0cc61 pass fileinfo to getStorageInfo 2015-02-13 17:59:58 +01:00
Robin Appelman
fb2a3284df Cache quota info for directories 2015-02-13 17:50:53 +01:00
Robin Appelman
134243d3e5 Dont lower the mtime of a folder when propagating changes 2015-02-13 14:30:05 +01:00
Lukas Reschke
276bfe5f33 Merge pull request #14197 from owncloud/ensure-that-passed-file-path-is-always-a-string 
Ensure that passed argument is always a string
 2015-02-13 13:30:54 +01:00
Lukas Reschke
95860d8113 Merge pull request #14086 from hlop/master 
App install behind a Proxy
 2015-02-13 12:56:01 +01:00
Lukas Reschke
9904b30070 Ensure that passed argument is always a string 
Some code paths called the `normalizePath` functionality with types other than a string which resulted in unexpected behaviour.

Thus the function is now manually casting the type to a string and I corrected the usage in list.php as well.
 2015-02-13 12:49:34 +01:00
Lukas Reschke
025110821f URLEncode logout attribute 
Otherwise logout can fail if the requesttoken contains a +
 2015-02-13 12:08:23 +01:00
Joas Schilling
6c349c00bb Order methods to by grouped by their task 2015-02-13 11:55:06 +01:00
Joas Schilling
be63e18b0a Check whether filter is valid, before doing stuff for it 2015-02-13 11:50:55 +01:00
Joas Schilling
c02de748e5 Cache some values from the extensions 2015-02-13 11:36:34 +01:00
Lukas Reschke
8e8acad550 Merge pull request #14145 from owncloud/no-whitespace-from-themes-master 
catch any whitespaces which might get written to the output buffer while...
 2015-02-12 17:23:28 +01:00
Thomas Müller
fc7f279d90 catch any whitespaces which might get written to the output buffer while loading a theme 2015-02-12 16:42:17 +01:00
Lukas Reschke
2f80be45b0 Remove internal annotation 
PHPStorm complained about those functions being declared as Internal. I doubt that this is actually the case since they are even in the public API.
 2015-02-12 16:35:47 +01:00
Björn Schießle
780024e252 Merge pull request #14071 from owncloud/add_timeout_for_post_requests 
add timeout to curl request
 2015-02-12 11:38:35 +01:00
Morris Jobke
f4182d2dc9 Merge pull request #10993 from owncloud/scanner-reuse-fileid 
Reuse known fileids and cache data in the scanner
 2015-02-12 10:53:00 +01:00
Bjoern Schiessle
4155252379 add timeout to curl request 2015-02-12 10:51:39 +01:00
Morris Jobke
a496c34aea Check if imageflip is available 
* imageflip() isn't available in PHP < 5.5
* fixes #14130
 2015-02-12 10:21:20 +01:00
Lukas Reschke
86139fcce8 Deprecate OC_JSON and OCP\JSON 
This deprecates – but not removes – those two classes and all functions in it. There is no reason that new developments should use those methods as with the AppFramework there is a replacement that allows testable code.

With the `@deprecated` annotation IDEs like PHPStorm will point out to the developer that a functionality is deprecated and that there is a better suited replacement.
 2015-02-12 00:56:13 +01:00
Thomas Müller
9ecb36e81f integrate code checker in the installer 2015-02-11 23:37:51 +01:00
Thomas Müller
99a97649f2 Merge pull request #14097 from yanntech/fix/utf8-check 
in some case charset can be in lower case.
 2015-02-11 18:04:54 +01:00
Vincent Petry
fbbb9fe0fd Merge pull request #13979 from owncloud/group-share-collition-wrong-type-in-post-hook 
Do not overwrite the shareType so the post hook is still correct
 2015-02-11 15:23:13 +01:00
Robin Appelman
9df18ffe75 only read permissions once 2015-02-11 13:11:31 +01:00
Robin Appelman
9bbfeada6b Only try to scan the children of directories 2015-02-11 13:11:31 +01:00
Robin Appelman
dc6468c2aa Cast mtimes and size to int 2015-02-11 13:11:28 +01:00
Robin Appelman
4242dd0d9d Reuse cache data of existing files during scan 2015-02-11 13:08:28 +01:00
Yann VERRY
1fcea6f1bd in some case charset can be in lower case. 
Add strtoupper() in UTF-8 check to avoid error message
 2015-02-11 11:59:33 +01:00
Witali Rott
531c89a610 App install behind a Proxy 2015-02-11 07:47:50 +01:00
Thomas Müller
45dcca2fcb Merge pull request #13861 from owncloud/remove-disabled-files-repair-step 
Revert "enabled disabled files app in repair step"
 2015-02-10 22:46:53 +01:00
Morris Jobke
11283c57d9 Merge pull request #11056 from AdamWill/9885-opcode 
add function to invalidate one opcache file, use it if possible #9885
 2015-02-10 17:21:15 +01:00
Thomas Müller
d74662df7d implement php code checker to detect usage of not allowed private APIs - including console command to check local code to be used by developers 2015-02-10 11:51:24 +01:00
Morris Jobke
1bb6de7c1b Merge pull request #13425 from owncloud/phpdoc_cleanup 
Cleanup of PHPDoc return types
 2015-02-10 01:14:00 +01:00
Morris Jobke
068f6107c6 Merge pull request #13842 from owncloud/is_file_2_is_readable 
check if cache files are readable
 2015-02-09 23:45:32 +01:00
Lukas Reschke
74de345c7f Merge pull request #13511 from owncloud/naturalsort_speeeeeed 
NaturalSort performance improvements
 2015-02-09 18:39:52 +01:00
Vincent Petry
c4d9ae8af4 Merge pull request #13928 from owncloud/prevent_ghost_files_master 
prevent creation of ghost directories
 2015-02-09 18:15:45 +01:00
Vincent Petry
5296767393 Merge pull request #13921 from owncloud/ocs-af 
Add a controller and reponse for ocs
 2015-02-09 18:11:47 +01:00
Vincent Petry
605e2357a1 Merge pull request #13852 from owncloud/cache-app-versions 
Cache app versions
 2015-02-09 18:03:19 +01:00
Vincent Petry
c7fcd42edb Merge pull request #13870 from owncloud/drop-oc-preferences-2 
drop OC\Preferences
 2015-02-09 17:49:05 +01:00
Vincent Petry
b7b8c0c2e5 Merge pull request #13869 from owncloud/drop-oc-preferences 
drop OC_Preferences
 2015-02-09 17:48:36 +01:00
Lukas Reschke
47c7eb4e70 Merge pull request #13973 from owncloud/enhancement/security/13366 
Respect `mod_unique_id` and refactor `OC_Request::getRequestId`
 2015-02-09 17:35:19 +01:00
Robin McCorkell
a79757bc37 Store FileInfo::getType() result for future use 2015-02-09 16:34:11 +00:00
Robin McCorkell
44c330aa5d Performance improvements for NaturalSort 
A combination of using isset() instead of count() or strlen(), caching the
chunkify function, and replacing is_numeric() with some comparisons
 2015-02-09 16:32:43 +00:00
Vincent Petry
5d8f1a1de3 Merge pull request #13854 from owncloud/avatar-exists 
Add a better way to check if an avatar exists for the user
 2015-02-09 17:06:24 +01:00
Joas Schilling
31b93ac19a Do not overwrite the shareType so the post hook is still correct 2015-02-09 12:59:29 +01:00
Robin Appelman
45e3cbefc9 Check directory handle before we use it 2015-02-09 12:36:18 +01:00
Lukas Reschke
770fa761b8 Respect mod_unique_id and refactor OC_Request::getRequestId 
When `mod_unique_id` is enabled the ID generated by it will be used for logging. This allows for correlation of the Apache logs and the ownCloud logs.

Testplan:

- [ ] When `mod_unique_id` is enabled the request ID equals the one generated by `mod_unique_id`.
- [ ] When `mod_unique_id` is not available the request ID is a 20 character long random string
- [ ] The generated Id is stable over the lifespan of one request

Changeset looks a little bit larger since I had to adjust every unit test using the HTTP\Request class for proper DI.

Fixes https://github.com/owncloud/core/issues/13366
 2015-02-09 11:53:11 +01:00
Lukas Reschke
0e604aa875 Merge pull request #13948 from owncloud/cache-move-transaction 
Use transactions when renaming directory contents
 2015-02-08 19:08:52 +01:00
Morris Jobke
90556cb70b Merge pull request #12283 from oparoz/sfnt-fonts 
Updated the media type of some font types
 2015-02-07 13:33:49 +01:00
Morris Jobke
11ded92a73 Merge pull request #13830 from owncloud/fix-redirect-404 
Don't encode url unecessary twice
 2015-02-07 13:24:47 +01:00
Robin Appelman
6c00521e8b Use transactions when renaming directory contents 2015-02-06 15:20:53 +01:00
Thomas Müller
bc56fef619 Merge pull request #13932 from owncloud/revert-sabredav-etag-master 
Revert "adding OC-ETag header"
 2015-02-06 12:05:32 +01:00
Lukas Reschke
4d91fa4c93 Normalize before processing 2015-02-06 15:03:29 +01:00
Vincent Petry
8210200770 Revert "adding OC-ETag header" 
This reverts commit 96a931929e.
 2015-02-05 20:43:37 +01:00
Bjoern Schiessle
1448f281b7 for password protected link shares the password is stored in shareWith, so we need to set this manually to null for the hooks 2015-02-05 17:23:59 +01:00
Bernhard Posselt
fdc64e370c add a controller and reponse for ocs 2015-02-05 14:02:17 +01:00
Robin Appelman
adf9a4e4eb Dont bother updating the cache when working with part files 2015-02-05 13:59:50 +01:00
Robin Appelman
842d0e227c Dont update the cache after fopen 2015-02-05 13:47:32 +01:00
Björn Schießle
486f49ed72 Merge pull request #13881 from owncloud/upload_to_root_of_mountpoint 
detect root of mountpoint also if the trailing slash is missed
 2015-02-04 14:44:02 +01:00
Bjoern Schiessle
21c45925fe detect root of mountpoint also if the trailing slash is missed 2015-02-04 12:47:04 +01:00
Morris Jobke
4df7c0a1ed drop OC\Preferences 2015-02-04 00:31:09 +01:00
Morris Jobke
909a53e087 drop OC_Preferences 2015-02-04 00:06:29 +01:00
Morris Jobke
b168c191bc Revert "enabled disabled files app in repair step" 
This reverts commit d70160c607.
 2015-02-03 17:06:57 +01:00
Thomas Müller
23c6a0cf99 Merge pull request #13843 from owncloud/fix-files-disabled 
Fix disabled files app
 2015-02-03 16:13:15 +01:00
Robin Appelman
6f118d7f8d clear app version cache on upgrade 2015-02-03 15:23:51 +01:00
Robin Appelman
c644ed89a7 Add a better way to check if an avatar exists for the user 2015-02-03 14:54:06 +01:00
Robin Appelman
70fd3a267f Cache app versions 2015-02-03 14:13:44 +01:00
Morris Jobke
d70160c607 enabled disabled files app in repair step 2015-02-03 14:03:43 +01:00
Thomas Müller
9e222ec841 Merge pull request #13791 from owncloud/extstorage-fixdavexceptions 
Fix DAV exceptions, some will still return false now
 2015-02-03 13:31:32 +01:00
Jörn Friedrich Dreyer
86935fab17 readd is_file 2015-02-03 10:13:25 +01:00
Morris Jobke
a7eedf0149 Disallow disabling of files app 2015-02-03 00:39:01 +01:00
Arthur Schiwon
ded8cc47cf 🐫case 2015-02-02 23:47:59 +01:00
Jörn Friedrich Dreyer
2d8f57a1ea check if cache files are readable 2015-02-02 23:19:54 +01:00
Lukas Reschke
2bd1c17345 Don't encode url unecessary twice 
The URL was previously encoded twice which leads to getting redirected to a 404 page when the password has been entered incorrect at least once.

Testplan:

- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin` redirects to the admin page when providing the correct credentials
- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin` redirects to the admin page when providing the invalid credentials and then providing valid ones.
- [ ] Logging in as admin then going to the admin page and clearing the cookies and refreshing will show the login and when repeating the above test steps you're redirected correctly.

Fixes https://github.com/owncloud/core/issues/9804
 2015-02-02 15:09:59 +01:00
Thomas Müller
92bc1b44d5 Merge pull request #13822 from owncloud/include-core-version-in-js-version-tag 
include core version into js/css version tag
 2015-02-02 15:02:11 +01:00
Joas Schilling
a575dcf78f Use insertIfNotExists() and reload mimetypes after inserting one 2015-02-02 13:20:16 +01:00
Thomas Müller
24daee836a include core version into js/css version tag - fixes #13702 2015-02-02 13:02:11 +01:00
Thomas Müller
82b271855c add libs which have no version number 2015-02-02 10:49:46 +01:00
Morris Jobke
e7900ba255 Merge pull request #13508 from owncloud/failed-delete-cache 
Dont remove a file from cache if the delete operation failed
 2015-01-30 14:08:44 +01:00
Vincent Petry
5ade2854ee Fix DAV exceptions, some will still return false now 
Since the Storage interface isn't ready to work directly with exceptions
like Forbidden and NotFound, the DAV storage has been adapted to still
return false when expected.
 2015-01-30 12:02:23 +01:00
Vincent Petry
790622e9fd Merge pull request #13772 from owncloud/closecursor-allconfig 
Close cursor after checking for existing config values
 2015-01-29 19:31:21 +01:00
Bernhard Posselt
37e8969d34 ignore cursorclosing 2015-01-29 19:16:28 +01:00
Morris Jobke
b1d8d88df8 Merge pull request #13760 from owncloud/create_enc_key_for_remote_shares 
make sure that we always create a public share key for remote shares
 2015-01-29 17:54:04 +01:00
Robin Appelman
ce0aa02aac Dont do a cache rename if we cant delete the source file 2015-01-29 15:52:40 +01:00
Robin Appelman
2124540d1d Dont remove a file from cache if the delete operation failed 2015-01-29 15:39:56 +01:00
Lukas Reschke
65ec950b27 Merge pull request #13757 from owncloud/issue/13686-scroll-to-file-when-using-searchotherplaces 
Scroll to file in folder, when using "search in other places" link
 2015-01-29 15:36:25 +01:00
Björn Schießle
2c1bacadca Merge pull request #13762 from owncloud/ignore_trailing_slash 
ignore trailing slash for remote URL
 2015-01-29 15:00:44 +01:00
Morris Jobke
acf0582029 Merge pull request #13752 from owncloud/closecursor1 
Close cursor early in calculateFolderSize
 2015-01-29 14:23:16 +01:00
Bjoern Schiessle
c78e3c4a7f make sure that we always create a public share key for remote shares 2015-01-29 14:23:14 +01:00
Bjoern Schiessle
82de50d5b9 remove trailing slash 2015-01-29 14:03:09 +01:00
Robin Appelman
05035ef4af Fix webdav put for single file webdav shares 2015-01-29 12:47:12 +01:00
Robin Appelman
ddee63fa00 Fix resolving paths for views rooted in a file 2015-01-29 12:47:11 +01:00
Joas Schilling
54303484eb Scroll to file in folder, when using "search in other places" link 2015-01-29 12:21:20 +01:00
Robin Appelman
41382ef7fc Merge pull request #13667 from owncloud/rename-always-update-cache 
Update the cache when renaming even if we dont emit hooks
 2015-01-28 17:15:11 +01:00
Robin Appelman
8c9f1a982c Update the cache when renaming even if we dont emit hooks 2015-01-28 13:44:39 +01:00
Lukas Reschke
20199dd168 Reference module with .c 
Fixes https://github.com/owncloud/core/issues/13657
 2015-01-28 13:15:32 +01:00
Morris Jobke
1efb1fee11 Merge pull request #13700 from owncloud/dav-objecttree-required-a-collection 
let init() take a ICollection or an INode - fixes PHP message
 2015-01-28 01:14:47 +01:00
Morris Jobke
752b94d363 Merge pull request #13717 from owncloud/storage-donotwrapnullstorage 
Prevent wrapping null storage
 2015-01-28 01:00:20 +01:00
Morris Jobke
87b39e8f03 Merge pull request #13525 from owncloud/s2s-fixscanfileforbrokenstorage 
Catch storage exception in scanner for remote shares
 2015-01-28 00:31:37 +01:00
Vincent Petry
6d8985b671 Prevent wrapping null storage 
Can happen when trying to instantiate external storages that have
incomplete config, where the constructor throws an exception (the
exception is caught in createStorage())
 2015-01-27 17:40:08 +01:00
Bernhard Posselt
3fa6e0f4dc Merge pull request #13718 from owncloud/use-proper-namespace 
Use proper namespace
 2015-01-27 17:39:35 +01:00
Lukas Reschke
bedf358b40 Use proper namespace 
IAppManager lives in OCP\App and not in OCP.

Fixes https://github.com/owncloud/core/issues/13710
 2015-01-27 17:34:25 +01:00
Vincent Petry
acec40fe5a Merge pull request #13561 from owncloud/trash-finaldeletewhencrossstoragefix 
Call final unlink in trash wrapper's storage
 2015-01-27 17:05:38 +01:00
Morris Jobke
4d90fd933f Merge pull request #13699 from owncloud/check-if-file-exists 
Use `file_exists` to verify that config file exists
 2015-01-27 14:16:40 +01:00
Lukas Reschke
9771ead7dd Merge pull request #13701 from owncloud/disable-appcode-checker 
disable the app code checker - some previous shipped apps cannot be inst...
 2015-01-27 11:53:03 +01:00
Thomas Müller
b7cf4d551e let init() take an INode - fixes PHP message 2015-01-27 11:31:37 +01:00
Thomas Müller
956de27e94 Merge pull request #13676 from owncloud/fix-node-iface 
Fix node interface
 2015-01-27 09:34:59 +01:00
Thomas Müller
9a75304b02 disable the app code checker - some previous shipped apps cannot be installed from the appstore now 👊 2015-01-27 09:27:38 +01:00
Thomas Müller
f248ee013b Merge pull request #13694 from owncloud/little-bit-more-descriptive-htaccess-error 
Make error more descriptive
 2015-01-27 09:15:57 +01:00
Lukas Reschke
17f2cfbb9c Use file_exists to verify that config file exists 
There might be the case that `fopen($file, 'r')` returns false and thus ownCloud might believe that the config file is empty and thus potentially leading to an overwrite of the config file.

This changeset introduces `file_exists` again which was used in ownCloud 5 where no such problems where reported and should not be affected by such problems.

Ref https://github.com/owncloud/core/issues/12785#issuecomment-71548720
 2015-01-27 00:50:14 +01:00
Lukas Reschke
d8559dc78f Make error more descriptive 
Ref https://github.com/owncloud/core/issues/13693#issuecomment-71546767
 2015-01-26 23:00:15 +01:00
Bjoern Schiessle
5ba19ba7fc certificate manager should always use a \OC\Files\View otherwise we will get problems for different primary storages 2015-01-26 16:58:52 +01:00
Bjoern Schiessle
67da1f7e5a certificate manager only needs the user-id, no need to pass on the complete user object 2015-01-26 16:58:52 +01:00
Bernhard Posselt
b8769802df fix node interface 2015-01-26 15:58:41 +01:00
Vincent Petry
87ce64c24e Replace OC_Log::ERROR with OCP\Util::ERROR 2015-01-26 15:51:31 +01:00
Vincent Petry
f6e644b43f Catch storage exception in scanner for remote shares 
Whenever an exception occurs during scan of a remote share, the share is
checked for availability. If the storage is gone, it will be removed
automatically.

Also, getDirectoryContent() will now skip unavailable storages.
 2015-01-26 13:59:49 +01:00
Thomas Müller
5da4071c45 Merge pull request #13621 from owncloud/system-config-multiset 
Add a method to set/unset multiple config values with one write
 2015-01-26 13:36:22 +01:00
Thomas Müller
9ad9d7bfbb naming fixes while reviewing 2015-01-26 12:59:25 +01:00
Olivier Paroz
7fbf1a20d7 Updated the media type of some font types 
TTF and TTF have now the same media type
Official since 2013 and supported by Firefox and Chrome
https://www.iana.org/assignments/media-types/application/font-sfnt

Introducing support for Type1 fonts
 2015-01-24 01:49:13 +01:00
Clark Tomlinson
f8b1fde2c0 Merge pull request #13626 from owncloud/check-for-hhvm 
Don't check for `always_populate_raw_post_data` on HHVM
 2015-01-23 10:28:47 -05:00
Robin Appelman
87a1b2bdc4 Preserve mtime when doing cross storage move 2015-01-23 15:11:27 +01:00
Vincent Petry
8fa3e7a6bf Do not retrieve shares through group if user has no group 2015-01-23 15:11:06 +01:00
Joas Schilling
039397bd31 Use setConfigs() instead of calling setConfig() multiple times 2015-01-23 14:52:21 +01:00
Lukas Reschke
30a5758a95 Don't check for always_populate_raw_post_data on HHVM 
HHVM seems to have problems with this at the moment (even setting those values in the php.ini of HHVM doesn't have helped much) and thus the unit test execution failed.

So it's better if we disable this check for now for HHVM.
 2015-01-23 13:54:34 +01:00
Robin Appelman
960ff4f136 Apply wrappers to existing mounts before registering it 2015-01-23 13:48:35 +01:00
Vincent Petry
5fb8a4715d removeStorageWrapper to unregister a storage wrapper 2015-01-23 12:20:54 +01:00
Joas Schilling
c61e9f3912 Add a method to set/unset multiple config values in one call 
This reduces the number of file writes we do for config.php and therefor
hopefully helps lowering the chances for empty config.php files
 2015-01-23 11:00:53 +01:00
Morris Jobke
7e4afa3f25 Merge pull request #13593 from owncloud/add-check-for-raw-post-data 
Add check for `HTTP_RAW_POST_DATA` setting for >= 5.6
 2015-01-22 23:59:52 +01:00
Morris Jobke
254a1fa12a Merge pull request #13314 from owncloud/login-hook-logout 
Return false if the login is canceled in a hook
 2015-01-22 23:34:19 +01:00
Thomas Müller
5776bfec05 Merge pull request #13449 from owncloud/image_preview_limit 
add config-option for an image's maximum filesize when generating previews
 2015-01-22 23:02:38 +01:00
Georg Ehrke
3af8bde949 add config-option for an image's maximum filesize when generating previews 2015-01-22 20:21:37 +01:00
Georg Ehrke
6b33481652 remove insane debug-log from OC_Image 2015-01-22 20:17:25 +01:00
Thomas Müller
8f06bf7bc6 Merge pull request #13598 from owncloud/fix-undefined-offset 
Fix undefined offset 1 for wrong user mail address
 2015-01-22 17:16:23 +01:00
Vincent Petry
6fb553e92c Do not call wrapStorage if storate with same name added twice 2015-01-22 16:24:24 +01:00
Morris Jobke
3d42ecea37 Fix undefined offset 1 for wrong user mail address 
* fixes Undefined offset: 1 at lib/private/mail.php#143
 2015-01-22 16:23:50 +01:00
Thomas Müller
f4a9164660 Merge pull request #13600 from owncloud/server-warning 
Get rid of log warning when using servercontainer
 2015-01-22 16:03:54 +01:00
Bernhard Posselt
9df297324f get rid of log warning when using servercontainer 2015-01-22 15:33:09 +01:00
Morris Jobke
55c28608c9 translate error messages 2015-01-22 14:52:47 +01:00
Robin Appelman
8eda661761 Throw an exception when login is canceled by an app 2015-01-22 14:13:17 +01:00
Robin Appelman
8a9acc5083 Allow custom error messages for the login page 2015-01-22 14:13:02 +01:00
Lukas Reschke
bb80cf4eca Add check for HTTP_RAW_POST_DATA setting for >= 5.6 
PHP 5.6 otherwise throws notices for perfectly valid code which results in broken endpoints.

Fixes https://github.com/owncloud/core/issues/13592
 2015-01-22 13:50:38 +01:00
Morris Jobke
b5b491d1bb Merge pull request #13509 from owncloud/share-deletechildrenwhenunsharefromgroup 
Fix reshare permission change to not impair other deletion code
 2015-01-22 10:40:29 +01:00
Vincent Petry
9f137ac259 Fix reshare permission change to not impair other deletion code 
A recent change that prevents reshare permission changes to delete group
share children had the side-effect of also preventing group share
children deletion when it needed to be done.

This fix adds an extra flag to isolate the "reshare permission change"
deletion case and keep the other ones as they were before, not only to
fix the regression but also fix other potential regressions in code that
uses this method.

Also updated the comment because now Helper::delete() is no longer
limited to reshares but also applies to group share children.
 2015-01-22 10:12:47 +01:00
Thomas Müller
c13bf8d820 Merge pull request #13552 from owncloud/request-uri-double-slash 
Remove duplicated slashes from the requested url
 2015-01-21 21:56:09 +01:00
Joas Schilling
d4657aa592 Set the debugoutput channel to error_log instead of echoing it 2015-01-21 15:32:31 +01:00
Robin Appelman
04075eba6b Remove duplicated slashes from the requested url 2015-01-21 15:04:18 +01:00
Thomas Müller
84bb4cc2e9 Merge pull request #13499 from owncloud/issue/13451-redis-json-encode 
Issue/13451 redis json encode
 2015-01-20 14:53:33 +01:00
Joas Schilling
e25998df0f Json_(en|de)code values on redis to be able to cache arrays 2015-01-20 10:51:27 +01:00
Lukas Reschke
476579b9c6 Fix WebDAV auth for session authentication only 
\Sabre\DAV\Auth\Backend\AbstractBasic::authenticate was only calling \OC_Connector_Sabre_Auth::validateUserPass when the response of \Sabre\HTTP\BasicAuth::getUserPass was not null.

However, there is a case where the value can be null and the user could be authenticated anyways: The authentication via ownCloud web-interface and then accessing WebDAV resources. This was not possible anymore with this patch because it never reached the code path in this scenario.

This patchs allows authenticating with a session without isDavAuthenticated value stored (this is for ugly WebDAV clients that send the cookie in any case) and thus the functionality should work again.

To test this go to the admin settings and test if the WebDAV check works fine. Furthermore all the usual stuff (WebDAV / Shibboleth / etc...) needs testing as well.
 2015-01-20 10:03:14 +01:00
Morris Jobke
870bc429b2 Merge pull request #13416 from owncloud/reauthenticate-if-session-differs-from-basic-auth 
Prioritise Basic Auth header over Cookie
 2015-01-19 22:23:02 +01:00
Lukas Reschke
cbffaff7a0 Merge pull request #13480 from owncloud/mysql-autocommit 
set MySQL autocommit on connection setup
 2015-01-19 19:39:26 +01:00
Thomas Müller
baefefbbc8 set MySQL autocommit on connection setup 2015-01-19 17:20:49 +01:00
Vincent Petry
ef8d38ca27 Fix chunked query for tags + unit test 2015-01-19 17:05:44 +01:00
Lukas Reschke
730460c9fa Close session properly 2015-01-19 16:25:44 +01:00
Thomas Müller
65041440de check is mimetype is set - fixed #13452 2015-01-19 15:04:53 +01:00
Morris Jobke
a28d3b594b Fix exif orientation for flipped images 
fixes #13363

Links:
 * http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/
 * Example data: https://github.com/recurser/exif-orientation-examples
 2015-01-18 23:15:52 +01:00
Thomas Müller
d2d6472e39 Merge pull request #13423 from owncloud/share-fixfindshareforuserwithmultiplegroups 
Fix getItemSharedWithUser for groups
 2015-01-19 12:34:28 +01:00
Thomas Müller
4fcfedb03c Merge pull request #13438 from owncloud/cache-the-array 
Reuse the array key of mimetypes
 2015-01-19 08:40:25 +01:00
Lukas Reschke
309cc9a6ca Reuse the array key of mimetypes 
This function is called a lot of times and was really slow before due to not reusing the same array.

Previously when it was called 500'000 times it took about 2seconds, now we're down to 0.2 seconds on my local machine.

Ref https://github.com/owncloud/core/issues/13434
 2015-01-18 14:50:34 +01:00
Lukas Reschke
dfbc405a45 Prioritise Basic Auth header over Cookie 
There are a lot of clients that support multiple WebDAV accounts in the same application. However, they resent all the cookies they received from one of the accounts also to the other one. In the case of ownCloud this means that we will always show the user from the session and not the user that is specified in the basic authentication header.

This patch adds a workaround the following way:

1. If the user authenticates via the Sabre Auth Connector add a hint to the session that this was authorized via Basic Auth (this is to prevent logout CSRF)
2. If the request contains this hint and the username specified in the basic auth header differs from the one in the session relogin the user using basic auth

Fixes https://github.com/owncloud/core/issues/11400 and https://github.com/owncloud/core/issues/13245 and probably some other issues as well.

This requires proper testing also considering LDAP / Shibboleth and whatever instances.
 2015-01-17 13:29:07 +01:00
Lukas Reschke
744cf713f7 Merge pull request #13319 from owncloud/replace-line-breaks-in-app-description 
replace line breaks in the app description by spaces - fixes #13315
 2015-01-17 01:03:41 +01:00
Robin McCorkell
2b99fc76ec Cleanup of PHPDoc return types 2015-01-16 20:30:43 +00:00
Vincent Petry
40931a8b0d Fix getItemSharedWithUser for groups 
Fixed SQL query for whenever a user has more than one group.
Added missing $owner where clause for group lookup.
Added unit tests for the group cases.
 2015-01-16 18:11:13 +01:00
Morris Jobke
0f0204ee35 Merge pull request #13160 from owncloud/extstorage-ocbackendnopartfile 
Disable part files for OC ext storage backend + s2s backend
 2015-01-16 13:38:59 +01:00
Lukas Reschke
a1e92d61b3 Fix PHPDoc 2015-01-15 22:50:42 +01:00
Robin Appelman
2248e465af Remove children from the cache in one query 2015-01-15 17:26:12 +01:00
Bernhard Posselt
bb0c88a577 always set url parameters when they are available in the app dispatch 
prefer url parameters passed into the main method. If they are not present, use the containers urlParameters

add space
 2015-01-15 15:22:52 +01:00
Thomas Müller
337c43ce92 Merge pull request #13317 from owncloud/partfile-fileinfo 
Return valid fileinfo objects for part files
 2015-01-14 22:39:19 +01:00
Morris Jobke
64d7463ca3 Merge pull request #13344 from owncloud/issue/13334-cleanup-tags-repairstep 
Add a repair step to clean up orphan tags and tag entries
 2015-01-14 20:43:23 +01:00
Morris Jobke
455ad005a0 Merge pull request #13350 from owncloud/autoload-translations 
Autoload app's js translations
 2015-01-14 18:12:05 +01:00
Joas Schilling
a22068cce3 Add a repair step to clean up orphan tags and tag entries 2015-01-14 16:49:25 +01:00
Bernhard Posselt
6737dd111d ignore core 2015-01-14 15:27:37 +01:00