wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
38108 commits 157 branches 562 tags 714 MiB
Commit graph

3926 commits

Author SHA1 Message Date
Lukas Reschke
e2e4677501 Merge pull request #2911 from nextcloud/rebrand-to-nextcloud-server-crawler 
Rebrand to "Nextcloud" and add 100% coverage
 2017-01-02 15:32:09 +01:00
Lukas Reschke
746fc3d3bf
Add 100% coverage for response.php 
While already at https://github.com/nextcloud/server/pull/2911 I thought I can as well finish that one as well...

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-01-02 15:16:35 +01:00
Lukas Reschke
5679f04cb1
Rebrand to "Nextcloud" and add 100% coverage 
Noticed while debugging https://github.com/nextcloud/server/issues/2910

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-01-02 14:51:16 +01:00
Robin Appelman
3243a6032a
adjust test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2017-01-02 14:17:20 +01:00
Robin Appelman
ac2542f0f0
add ci support for s3 object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2017-01-02 14:17:19 +01:00
Roeland Jago Douma
15efd3b38d Merge pull request #2892 from nextcloud/usercontroller_tests 
Adds user controller tests
 2016-12-30 14:58:52 +01:00
Roeland Jago Douma
31a3e9847f
Adds user controller tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-30 13:26:26 +01:00
Roeland Jago Douma
b5a23c9754
User command enable/disable tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-30 13:17:41 +01:00
Roeland Jago Douma
a7d9b7c876
Add Group Command tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-29 11:48:57 +01:00
Robin Appelman
c4358ff9fd
split db logic from settings manager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-12-28 18:59:24 +01:00
Robin Appelman
75747c5d2f Merge pull request #2854 from nextcloud/2fa-redirect-url 
Set redirect_url on 2FA challenge page
 2016-12-28 16:28:08 +01:00
Lukas Reschke
f237c582ba Merge pull request #2845 from nextcloud/deleteuser-gethomeearly 
Get user home folder before deletion
 2016-12-27 13:45:28 +01:00
Christoph Wurst
eff904473d
Set redirect_url on 2FA challenge page 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-12-23 20:53:26 +01:00
Lukas Reschke
c5cc0d87a8 Merge pull request #2833 from nextcloud/downstream-26750 
Introduce group display name support (#26750)
 2016-12-23 13:57:59 +01:00
Vincent Petry
7ca6561469
Remove legacy home tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-23 12:50:31 +01:00
Vincent Petry
4744dce4df
Nuke the legacy storage fallback from orbit 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-23 12:49:46 +01:00
Vincent Petry
91cd57e55b
Get user home folder before deletion 
After the deletion getHome() will fail because the user doesn't exist
any more, so we need to fetch that value earlier.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-23 12:42:31 +01:00
Arthur Schiwon
91a1e5fd9d
fix more tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2016-12-22 21:21:16 +01:00
Thomas Müller
b62b82c2de
Fix reporting of risky tests 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2016-12-22 18:39:40 +01:00
Vincent Petry
453f3beffa
Adding group display name support 2016-12-22 18:34:45 +01:00
Morris Jobke
bb8b647bd6 Merge pull request #2633 from nextcloud/2fa-activities 
two-factor activities
 2016-12-22 14:47:15 +01:00
Thomas Müller
aa8755bd4b
Add navigation via info.xml (#26785) 
* Read navigation information from info.xml

* Load files navigation elements from info.xml

* Add comment about ignoring the exception

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-22 12:34:41 +01:00
Björn Schießle
3453f4e97c Merge pull request #2761 from nextcloud/dont-resolve-shares-if-public-sharing-is-disabled 
Don't resolve public share token if public sharing is disabled
 2016-12-22 11:57:05 +01:00
Morris Jobke
998f235474 Merge pull request #2563 from nextcloud/fix-password-reset 
fix password reset if encryption is enabled
 2016-12-22 11:18:04 +01:00
Roeland Jago Douma
065f2fbcc6
Extend APCu test with int CAS 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-21 21:06:41 +01:00
Lukas Reschke
091bf07385 Merge pull request #2724 from nextcloud/fix-23591 
[downstream] Report failures for SignApp and SignCore
 2016-12-21 13:03:13 +01:00
Lukas Reschke
0d138c8591 Merge pull request #2784 from nextcloud/2fa_command_tests 
Add tests for 2FA commands
 2016-12-21 12:32:36 +01:00
Morris Jobke
4c315082e1 Merge pull request #2769 from nextcloud/improve_user_user_coverage 
Improve OC\User\User coverage
 2016-12-20 16:50:44 +01:00
Roeland Jago Douma
09caadac05
Add tests for 2FA commands 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-20 16:36:58 +01:00
Christoph Wurst
88b7d033df fix 2fa activities tests 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-12-20 15:23:36 +01:00
Roeland Jago Douma
7b4265ab59
Improve OC\User\User coverage 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-20 11:47:08 +01:00
Lukas Reschke
5983c68462
Don't resolve public share token if public sharing is disabled 
Otherwise disabling sharing does prevent access to the view controllers but one can still access the shares using the public preview route or the public WebDAV endpoint.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-20 08:52:46 +01:00
Vincent Petry
252eddadd9
Remove obsolete RepairLegacyStorages repair step 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-19 17:45:46 +01:00
Lukas Reschke
3eb3e437c8
Add proper tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-19 15:35:31 +01:00
Victor Dubiniuk
e536313451
Update tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-16 17:51:03 +01:00
Roeland Jago Douma
245501fb0c
Clear appstore cache on version upgrade 
* Add version to cached json
* Compare version
* Updated calls
* Updated tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-15 22:04:03 +01:00
Roeland Jago Douma
67f65677a1 Merge pull request #2665 from nextcloud/remove-db-class-and-interface 
Remove IDb interface which was deprecated for 3 years already
 2016-12-14 19:05:41 +01:00
Joas Schilling
bc3da3a8f5
Remove IDb interface which was deprecated for 3 years already 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-12-14 11:42:16 +01:00
Joas Schilling
77b6b7b23e
Use the mocked config version 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-12-14 10:45:27 +01:00
Joas Schilling
a7aa7de6c2
Add a unit test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-12-13 13:54:18 +01:00
Lukas Reschke
32bf8ec826
Don't use cached informations for app version 
When installing an app from the appstore the `\OC_App::getAppVersion` code is triggered twice:

- First when the downloader tries to compare the current version to the new version on the appstore to check if there is a newer version. This protects against downgrade attacks and is implemented in `\OC\Installer::downloadApp`.
- Second, when the app is actually installed the current version is written to the database. (`\OC\Installer::installApp`)

This fails however when the version is actually cached. Because in step 1 the cached version will be set to "0" and then be reused in the second step.

While this is probably not the cleanest version I assume this is an approach that is least invasive. Feedback and suggestions welcome :)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-09 18:01:45 +01:00
Bjoern Schiessle
16bbd3fd7c
fix password reset if encryption is enabled 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-12-08 12:08:05 +01:00
Joas Schilling
924358ef96
Save the timezone on login again 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-12-08 10:45:24 +01:00
Morris Jobke
7aa510b2f0
Document updater channel & check for correct PHP version in updater 
* see https://github.com/nextcloud/updater/issues/53

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2016-12-06 00:19:13 +01:00
Morris Jobke
aac3024878 Merge pull request #2505 from nextcloud/sudo-mode-provisioning-api 
Require sudo mode on the provisioning API
 2016-12-05 22:29:29 +01:00
Roeland Jago Douma
e368a745aa
Set last-login-check on basic auth 
Else the last-login-check fails hard because the session value is not
set and thus defaults to 0.

* Started with tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-12-05 20:57:15 +01:00
Christoph Wurst
0478db6506 Merge pull request #2484 from nextcloud/fix-wrong-update-of-email-address 
make sure that we only update the email address if it really changed
 2016-12-05 17:14:23 +01:00
Morris Jobke
1253d1008a Merge pull request #2411 from nextcloud/fix-encryption-home-storage 
check if the file should really be encrypted before we update the file cache
 2016-12-05 15:38:12 +01:00
Bjoern Schiessle
f25ad2e404
make sure that we only update the email address if it really changed 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-12-02 18:07:08 +01:00
Robin Appelman
1a379b0fdc
update test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-12-02 18:04:21 +01:00
Lukas Reschke
2ca29f709b
Add tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-12-01 18:52:32 +01:00
Morris Jobke
01a62dee30
Language 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2016-11-30 15:20:04 +01:00
Morris Jobke
62ec31eb7b Merge pull request #2152 from nextcloud/preview_cleanupjob 
Adds background job to cleanup all previews.
 2016-11-30 10:39:21 +01:00
Bjoern Schiessle
0f8fe77b3a
check if the file should really be encrypted before we update the file cache 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-29 20:34:45 +01:00
Morris Jobke
d86b29b42b Merge pull request #2066 from nextcloud/fix-redirect-double-encoding 
do not double encode the redirect url
 2016-11-29 17:21:43 +01:00
Lukas Reschke
3950ce9223 Merge pull request #2351 from nextcloud/remember-session-default 
do not remember session tokens by default
 2016-11-28 14:05:04 +01:00
Lukas Reschke
0cc771ce19 Merge pull request #2353 from nextcloud/renew-session-token-remember 
copy remember-me value when renewing a session token
 2016-11-28 14:04:13 +01:00
Christoph Wurst
6543182d13 fix parameter order 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-11-28 10:00:53 +01:00
Christoph Wurst
ad610ae772 Merge pull request #2327 from nextcloud/exclude-pre-releases 
Exclude pre-release versions as per SemVer
 2016-11-28 09:55:24 +01:00
Christoph Wurst
2183a1f3e6 copy remember-me value when renewing a session token 
On renew, a session token is duplicated. For some reason we did
not copy over the remember-me attribute value. Hence, the new token
was deleted too early in the background job and remember-me did
not work properly.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-11-27 14:19:57 +01:00
Christoph Wurst
9b808c4014 do not remember session tokens by default 
We have to respect the value of the remember-me checkbox. Due to an error
in the source code the default value for the session token was to remember
it.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-11-27 14:03:28 +01:00
Morris Jobke
64fb0fb3dd Merge pull request #2276 from nextcloud/update-email-address 
Update email address
 2016-11-25 11:40:20 +01:00
Lukas Reschke
29402e2c0a
Exclude pre-release versions as per SemVer 
As SemVer can be used apps could define a release like "10.0.0-alpha". This is something that we don't support at the moment in the server and we should filter all prereleases.

Ref https://github.com/nextcloud/server/pull/2307#issuecomment-262911588

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-25 11:32:46 +01:00
Bjoern Schiessle
0de685c562
bring back setEmailAddress for the user management 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-25 10:26:48 +01:00
Bjoern Schiessle
3fc75073b8
update accounts table if email address or display name changes from outside 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-25 10:26:47 +01:00
Roeland Jago Douma
72f9920a58
Add Identityproof tests 
* Add tests for Key
* Add tests for Manager
* Add tests for Signer
* Removed URLGenerator from Signer

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-24 21:50:19 +01:00
Lukas Reschke
6a4c0cf237
Loop for newest version in appstore response 
The current implementation when fetching apps from the appstore is to assume that the first element is the newest version, this is now always applicable and leads to the fact that for some apps (e.g. nextant) the newest version is not delivered. This can be easily tested by comparing the version of the downloaded Nextant version.

This change will loop over all releases delivered by the appstore and chooses the newest compatible one. While not the cleanest solution, it does its job.

Most of the code are actually unit tests. Whereas I have copied the whole original response from the appstore and also have performed the transformation. So that's why the diff looks so huge.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-24 14:29:57 +01:00
Bjoern Schiessle
546989959c
update email address correctly 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-23 20:19:31 +01:00
Lukas Reschke
a05b8b7953
Harden cookies more appropriate 
This adds the __Host- prefix to the same-site cookies. This is a small but yet nice security hardening.

See https://googlechrome.github.io/samples/cookie-prefixes/ for the implications.

Fixes https://github.com/nextcloud/server/issues/1412

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-23 12:53:44 +01:00
Roeland Jago Douma
df215625f1 Merge pull request #1972 from nextcloud/invalid-files-from-scanner 
Make sure we don't scan files that can not be accessed
 2016-11-22 12:55:54 +01:00
Robin Appelman
cd24010fa4 Merge pull request #2214 from nextcloud/remove-logging 
remove old logging section
 2016-11-21 17:17:02 +01:00
Robin Appelman
0048b3aa2e
update tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-21 15:59:08 +01:00
Lukas Reschke
d001dbd259
Adjust unit tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-21 11:30:03 +01:00
Lukas Reschke
8bf4111368
Fix changing display names for subadmins 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-21 11:30:00 +01:00
Lukas Reschke
fb91bf6a5b
Add a signer class for signing 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-21 11:30:00 +01:00
Bjoern Schiessle
a32d6e481f
fix unit tests 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-21 11:30:00 +01:00
Bjoern Schiessle
b23a4ca96b
push public user data to the lookup server 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-21 11:29:59 +01:00
Bjoern Schiessle
c5e61947a9
remove old test class 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-21 11:29:59 +01:00
Bjoern Schiessle
08e6541a88
fix unit tests 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-21 11:29:58 +01:00
Björn Schießle
de1f3f05fd
allow to change display names in the user settings again 
keep display name and email address in sync with the accounts table

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-21 11:29:54 +01:00
Björn Schießle
40b99734d3
introduce accounts table and keep it up-to-date with the data added to the personal settings 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-21 11:29:41 +01:00
Joas Schilling
558f169671
Move the validation into one place only 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-21 09:23:37 +01:00
Joas Schilling
4652d203e3
Make sure we don't scan files that can not be accessed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-21 09:23:32 +01:00
Roeland Jago Douma
78a318d388
Add test if repair step is already done 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-19 20:26:53 +01:00
Roeland Jago Douma
ccb05dbb17
Adds background job to cleanup all previews. 
* A repair step that inserts a background job for each user
* Each background job will delete for 15 seconds if it takes longer we
reschedule. This is done so instances that don't use the system cron
won't time out.
* Added tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-19 20:14:44 +01:00
Lukas Reschke
8ec2e34576 Merge pull request #1602 from nextcloud/ignore-mod-env 
Add system config htaccess.IgnoreFrontController for prettyURLs w/o mod_env
 2016-11-18 21:42:56 +01:00
Morris Jobke
46768e71d9 Merge pull request #2076 from nextcloud/log_preview_access 
Dispatch event on preview request
 2016-11-18 20:45:29 +01:00
Morris Jobke
332eaec4c0 Merge pull request #1447 from nextcloud/password-confirmation-for-some-actions 
Password confirmation for some actions
 2016-11-18 15:42:30 +01:00
Robin Appelman
8b9ad46ba3 Merge pull request #768 from nextcloud/s3-objectstore 
Add S3 objectstore backend
 2016-11-18 14:55:07 +01:00
Joas Schilling
b2d9c20aac
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-18 12:10:51 +01:00
Morris Jobke
d3900fc0d5 Merge pull request #2177 from nextcloud/appmanager-getapppath 
Expose getAppPath to public API
 2016-11-17 22:39:34 +01:00
Julius Haertl
caacb6c261
Expose getAppPath to public API 
Signed-off-by: Julius Haertl <jus@bitgrid.net>
 2016-11-17 19:24:24 +01:00
Morris Jobke
bba32cf4b7 Merge pull request #2163 from nextcloud/app-password-scope-warngings 
fix warnings when updating app password
 2016-11-17 17:52:23 +01:00
Felix Epp
1614b310ef Add system config htaccess.IgnoreFrontController for prettyURLs w/o mod_env 
Added the system config which sets all conditions to true that query the
FrontControllerActive mod_env variable.

Signed-off-by: Felix A. Epp <work@felixepp.de>
 2016-11-16 22:28:49 +01:00
Roeland Jago Douma
74c68d8761
Add OCSControllerTests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-16 19:49:51 +01:00
Robin Appelman
d2dee32756
fix warnings when updating app password 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 19:14:36 +01:00
Robin Appelman
4ac5fdcf11
add tests for FileInfo::isMounted 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:30:37 +01:00
Robin Appelman
e4d1cf0f6d
add tests for http/output 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:30:37 +01:00
Robin Appelman
eefd059716
add amazon s3 objectstore backend 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:30:36 +01:00
Robin Appelman
64e896cc0d
split testing of objectstoragestorage and objectstore implementations 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:30:36 +01:00
Robin Appelman
e633f2f8df
add test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:24:33 +01:00
Robin Appelman
e77432783b
Add test for setting up fake fs 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:24:32 +01:00
Roeland Jago Douma
311531ecce
Adds tests for the AuthSettingsController 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-16 15:24:31 +01:00
Roeland Jago Douma
59d6003f89
Adds NullCache ans NullStorage tests for Lockdown 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-16 15:24:31 +01:00
Roeland Jago Douma
e5bc80b31d
Adds TokenProvider and Mapper tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-16 15:24:31 +01:00
Robin Appelman
91851c37be
add tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:24:30 +01:00
Robin Appelman
4c3d18a9fc
explicit types 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:24:29 +01:00
Robin Appelman
a4ea20a259
cast to int 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:24:29 +01:00
Robin Appelman
bb65d3b03d
update tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-16 15:24:29 +01:00
Joas Schilling
8725302307
Fix InfoParser empty tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-16 09:25:45 +01:00
Joas Schilling
b8958ee937
Fix activity manager tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-16 09:25:45 +01:00
Roeland Jago Douma
28babd319b Merge pull request #2137 from nextcloud/make-sure-tests-run-on-phpunit-4-again 
Add a magic wrapper to allow phpunit4 to run the code again
 2016-11-15 21:48:55 +01:00
Lukas Reschke
b775d935f2
Endpoint is now 11.0.0 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-15 15:10:17 +01:00
Lukas Reschke
5fd428413b
Adjust previous fallbacks 
11.0 is 11 and not 9.2 anymore

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-15 15:07:58 +01:00
Joas Schilling
e76ef9aaa8
Add a magic wrapper from hell to allow phpunit4 to run the code again 
Remove this once phpunit 5 is the lowest supported version, by reverting:
https://github.com/nextcloud/server/pull/2137

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-15 14:49:14 +01:00
Roeland Jago Douma
b7e13b43fb Merge pull request #2114 from nextcloud/downstream-26498 
make object prefix configurable
 2016-11-14 17:07:00 +01:00
Jörn Friedrich Dreyer
4a9361905d
make object prefix configurable 2016-11-14 15:10:56 +01:00
Thomas Müller
506ccdbd8d
Introduce an event for first time login based on the last login time stamp 
Use firstLogin event to trigger creation of default calendar and default address book

Delay login of admin user after setup so that firstLogin event can properly be processed for the admin

Fixing tests ...

Skeleton files are not copied over -> only 3 cache entries are remaining

Use updateLastLoginTimestamp to properly setup lastLogin value for a test user
 2016-11-14 14:50:10 +01:00
Morris Jobke
16a110e803 Merge pull request #2067 from nextcloud/fileinfo-lazy-substorages 
only query substorages to calculate the final mtime/size/etag when we need it
 2016-11-14 11:39:02 +01:00
Lukas Reschke
7cb0df28e2
Prevent downgrade attacks for apps 
We should verify the app versions when installing a new update, otherwise this could result in downgrade attacks when an attacker just copies the old signature.

Plus it prevents the case that in case of a bug in the appstore actually an older version gets installed.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-11 18:53:26 +01:00
Roeland Jago Douma
99ada40df4
Dispatch event on preview request 
Fixes: #73

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-10 14:28:09 +01:00
Robin Appelman
cbcdf69dc2
only query substorages to calculate the final mtime/size/etag lazily 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-10 13:59:22 +01:00
Christoph Wurst
0ebffa4a5f do not double encode the redirect url 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-11-09 16:14:46 +01:00
Morris Jobke
eadccc239a Merge pull request #2052 from nextcloud/ros-definitions-as-php-class 
Use a php class for the definitions to avoid loading problems
 2016-11-09 13:53:54 +01:00
Lukas Reschke
9305094b8b
Add test and adjust PHP function arguments 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-09 10:49:57 +01:00
Joas Schilling
92e5fb4053
Add tests for validity of the definitions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-09 10:08:29 +01:00
Joas Schilling
706b5c3fb6
Use a php class for the definitions to avoid loading problems 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-09 08:52:07 +01:00
Roeland Jago Douma
b6562cb386
Generate js codecov coverage 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-09 08:03:29 +01:00
Morris Jobke
05cf1dab4c Merge pull request #2053 from nextcloud/make-sure-we-can-backup-the-command-bus 
Make sure the database is not replaced while we make a backup of the …
 2016-11-08 20:37:22 +01:00
Joas Schilling
4393e8003b
Make sure the database is not replaced while we make a backup of the service 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-08 16:32:41 +01:00
Christoph Wurst
9e5e120ef9
refactor share permission logic into own method to reuse it for the share tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-11-07 14:58:45 +01:00
Roeland Jago Douma
95a8964cc8
Add settings PersonalController 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-06 14:05:49 +01:00
Roeland Jago Douma
04ece69a33
Cleanup OC_Group usage a bit 
This is deprecated internal stuff. Should not be used anymore.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-04 20:55:47 +01:00
Morris Jobke
ac61f64190 Merge pull request #1109 from nextcloud/add-more-secrets-to-password-reset-link 
Use mail for encrypting the password reset token as well
 2016-11-03 22:11:43 +01:00
Lukas Reschke
c0bbae28f0 Merge pull request #1741 from nextcloud/new_preview 
Improve previews
 2016-11-03 21:07:16 +01:00
Roeland Jago Douma
dca9184a12
Fix tests 
* Tests fixed and controller coverage to 100%

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-03 19:08:56 +01:00
Lukas Reschke
6d686c213b
[WIP] Use mail for encrypting the password reset token as well 2016-11-03 14:27:26 +01:00
Roeland Jago Douma
7ba7949dc1 Merge pull request #1994 from nextcloud/proper-cron-hints 
Show a hint for system based cron user name
 2016-11-03 14:11:37 +01:00
Roeland Jago Douma
9e6b26dcd0
Add cache 1 day cache to preview endpoint 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-03 14:00:33 +01:00
Roeland Jago Douma
55af6b45f7
More tests 
* PreviewController test
* PublicPreview test
* Versions Preview test
* Trash Preview test

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-03 14:00:33 +01:00
Roeland Jago Douma
87855aa97b
Added genertor helper & tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-03 14:00:33 +01:00
Roeland Jago Douma
2164085f22
Fix urlgenerator test 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-03 14:00:33 +01:00
Lukas Reschke
b33ceb6fdd Merge pull request #1915 from nextcloud/downstream-26398 
Add using casing check/fix for initMountPoints
 2016-11-03 12:14:28 +01:00
Morris Jobke
0741346385
Show a hint for system based cron user name 
* makes it easier to setup cron job
* gives hints for PHP documentation
* disables the cron setting if requirements not met
* fixes #1989

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2016-11-03 10:38:00 +01:00
Lukas Reschke
6920e609c0
Adjust tests and DI for Share.php 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-02 23:26:49 +01:00
Lukas Reschke
68cebef64c
DI for root.php 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-02 23:16:51 +01:00
Morris Jobke
39573e602d Merge pull request #1978 from nextcloud/remove-send-mail-option 
Remove send mail option
 2016-11-02 22:36:05 +01:00
Morris Jobke
178d7f5bfa Merge pull request #1988 from nextcloud/silly-but-effective-test 
Add test for "languageCodes.php"
 2016-11-02 22:30:52 +01:00
Vincent Petry
889e0a574b
Fix mock warning in some FS tests (#26464) 2016-11-02 22:21:47 +01:00
Vincent Petry
f737426eca
Add using casing check/fix for initMountPoints 2016-11-02 22:21:46 +01:00
Lukas Reschke
c1feae1684 Merge pull request #1981 from nextcloud/multibucket-num-buckets 
Allow setting a maximun number of buckets for multibucket
 2016-11-02 22:05:57 +01:00
Lukas Reschke
8d4bda7de6
Add test for "languageCodesTest.php" 
Arguably not the most awesome test but increases coverage and is an easy gain.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-02 21:53:54 +01:00
Robin Appelman
049bcae29e
Allow setting a maximun number of buckets for multibucket 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-11-02 21:31:24 +01:00
Lukas Reschke
a8b7df9cc1
Add tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-02 21:10:51 +01:00
Joas Schilling
2c4035e806
Inject config and logger 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-11-02 20:30:37 +01:00
Morris Jobke
e6b52ef4cd Merge pull request #1347 from nextcloud/bring-back-remember-me 
fix remember me login
 2016-11-02 18:32:38 +01:00
Bjoern Schiessle
f556c58c22
remove 'send mail notification' option from sharing, replaced by send-by-mail feature 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-02 18:30:38 +01:00
Michael Grosser
e81d04cd8d Merge pull request #1940 from nextcloud/new-appstore 
Use new appstore API
 2016-11-02 17:00:24 +00:00
Lukas Reschke
9d6e01ef40
Add missing tests and fix PHPDoc 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-11-02 13:39:17 +01:00
Christoph Wurst
6f86e468d4
inject ISecureRandom into user session and use injected config too 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-11-02 13:39:16 +01:00
Christoph Wurst
d907666232
bring back remember-me 
* try to reuse the old session token for remember me login
* decrypt/encrypt token password and set the session id accordingly
* create remember-me cookies only if checkbox is checked and 2fa solved
* adjust db token cleanup to store remembered tokens longer
* adjust unit tests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2016-11-02 13:39:16 +01:00
Roeland Jago Douma
370123b8b0 Merge pull request #1966 from nextcloud/fix-csrf-token-generation 
Fix CSRF token generation / validation
 2016-11-02 12:09:30 +01:00
Leon Klingele
e5d78a3523
Fix CSRF token generation / validation 
Operate on raw bytes instead of base64-encoded strings.
Issue was introduced in a977465

Signed-off-by: Leon Klingele <git@leonklingele.de>
 2016-11-02 10:38:05 +01:00
Bjoern Schiessle
318160647a
add method to check if a share provider for a given type is loaded 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2016-11-01 19:54:39 +01:00
Roeland Jago Douma
7e2159e9bb
Add defaultShareProvider & federatedshareprovider tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-01 13:52:37 +01:00
Roeland Jago Douma
d2110ebb0b
Add Manager unit tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-11-01 12:35:50 +01:00
Lukas Reschke
0eeef26a8e
Add tests for installer method 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-31 19:39:35 +01:00
Lukas Reschke
a68595742b
Proxy images through usercontent.apps.nextcloud.com 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-31 17:17:47 +01:00
Lukas Reschke
8acb54aa0b
Add update support 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-31 17:17:47 +01:00
Lukas Reschke
89fc4358ba
Use substr and explode instead of a regex 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-31 17:17:45 +01:00
Lukas Reschke
8d83e239f3
Fix tests 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-31 17:17:45 +01:00
Lukas Reschke
32cf661215
Use new appstore API 
This change introduces the new appstore API in Nextcloud.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-31 17:17:44 +01:00
Robin Appelman
3692769b0a
Add getShareTypesInFolder to optimize folder listening 
Signed-off-by: Robin Appelman <icewind@owncloud.com>
 2016-10-31 15:55:40 +01:00
Roeland Jago Douma
83e7cfd13a
Fix more tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-28 22:16:28 +02:00
Roeland Jago Douma
f722640a32
Proper DI of config 
* Fixed comments

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-28 10:13:35 +02:00
Jörn Friedrich Dreyer
f8352fcb8d
introduce callForSeenUsers and countSeenUsers (#26361) 
* introduce callForSeenUsers and countSeenUsers

* add tests

* oracle should support not null on clob

* since 9.2.0
 2016-10-28 08:44:05 +02:00
Morris Jobke
d4969abc9d Merge pull request #1800 from nextcloud/nextcloud-rich-object-strings 
Nextcloud rich object strings
 2016-10-27 15:30:58 +02:00
Roeland Jago Douma
b7046d390f
Remove internal share mail function 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-26 20:52:41 +02:00
Roeland Jago Douma
b98dfaccd9 Merge pull request #1920 from nextcloud/legacy-pages-should-also-receive-the-nonce 
Add nonce also to legacy CSP
 2016-10-26 16:41:34 +02:00
Morris Jobke
cde7f535bd Merge pull request #1738 from nextcloud/comments-provide-displaynames-with-mentions 
comment mentions: show displayname not uid
 2016-10-26 14:02:49 +02:00
Joas Schilling
c20ab0049f
Identify Chromium as Chrome 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-26 12:07:10 +02:00
Roeland Jago Douma
e351ba56f1
Move browserSupportsCspV3 to CSPNonceManager 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-25 22:03:10 +02:00
Morris Jobke
097a9ec8b0 Merge pull request #1878 from nextcloud/downstream-25936 
Adjust unit tests to upstream
 2016-10-25 17:59:01 +02:00
Morris Jobke
89574367bc Merge pull request #1871 from nextcloud/use-csp-nonces 
Use CSP nonces
 2016-10-25 14:46:00 +02:00
Lukas Reschke
740ff9108b Merge pull request #1884 from nextcloud/downstream-26292 
Fix logClientIn for non-existing users (#26292)
 2016-10-25 11:24:13 +02:00
Joas Schilling
890f752a6b Merge pull request #1452 from nextcloud/appconfig-endpoint 
Appconfig endpoint
 2016-10-25 10:57:48 +02:00
Roeland Jago Douma
593d52fe91
Fix and cleanup SessionTest 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-25 09:34:27 +02:00
Vincent Petry
6d1e858aa4
Fix logClientIn for non-existing users (#26292) 
The check for two factor enforcement would return true for non-existing
users. This fix makes it return false in order to be able to perform
the regular login which will then fail and return false.

This prevents throwing PasswordLoginForbidden for non-existing users.
 2016-10-25 09:34:27 +02:00
Lukas Reschke
38b3ac8213
Add ContentSecurityPolicyNonceManager 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-24 16:35:31 +02:00
Thomas Müller
03ec052b4e
App dependencies are now analysed on app enable as well - not only on app install. 2016-10-24 15:59:46 +02:00
Thomas Müller
0c637c8d73
[9.2] Add missing unit tests (#25936) 
* Adjust unit test execution after folder rename

* Adjust login controller tests to match current behavior

* Fix broken unit tests
 2016-10-24 14:25:52 +02:00
Lukas Reschke
9e6634814e
Add support for CSP nonces 
CSP nonces are a feature available with CSP v2. Basically instead of saying "JS resources from the same domain are ok to be served" we now say "Ressources from everywhere are allowed as long as they add a `nonce` attribute to the script tag with the right nonce.

At the moment the nonce is basically just a `<?php p(base64_encode($_['requesttoken'])) ?>`, we have to decode the requesttoken since `:` is not an allowed value in the nonce. So if somebody does on their own include JS files (instead of using the `addScript` public API, they now must also include that attribute.)

IE does currently not implement CSP v2, thus there is a whitelist included that delivers the new CSP v2 policy to newer browsers. Check http://caniuse.com/#feat=contentsecuritypolicy2 for the current browser support list. An alternative approach would be to just add `'unsafe-inline'` as well as `'unsafe-inline'` is ignored by CSPv2 when a nonce is set. But this would make this security feature unusable at all in IE. Not worth it at the moment IMO.

Implementing this offers the following advantages:

1. **Security:** As we host resources from the same domain by design we don't have to worry about 'self' anymore being in the whitelist
2. **Performance:** We can move oc.js again to inline JS. This makes the loading way quicker as we don't have to load on every load of a new web page a blocking dynamically non-cached JavaScript file.

If you want to toy with CSP see also https://csp-evaluator.withgoogle.com/

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-24 12:27:50 +02:00
Roeland Jago Douma
ab91fa2660 Merge pull request #1820 from nextcloud/4byte-filenames 
Allow 4byte unicode filenames on supported platforms
 2016-10-24 10:38:25 +02:00
Roeland Jago Douma
7998689bc9
Added method to DB and fix test 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-24 09:45:04 +02:00
Roeland Jago Douma
eaf152efeb
Fix DateTime comparisson 
Datetime now returns microseconds. But if the database doesn't store
those comparing them for equality most likely fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-21 13:43:39 +02:00
Joas Schilling
0b1fb180a5
Make AppConfig part of the public API 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-21 09:09:23 +02:00
Morris Jobke
2799b0a821 Merge pull request #1835 from nextcloud/downstream-24948 
Move OC\Files\Storage\Shared to the right namespace
 2016-10-20 23:48:15 +02:00
Vincent Petry
9e9fef46d9
Get rid of very old oc:// stream wrapper (#26381) 2016-10-20 20:46:30 +02:00
Morris Jobke
c7ba73e6f4 Merge pull request #1824 from nextcloud/downstream-26423 
Ensure $commands being an array
 2016-10-20 20:43:26 +02:00
Vincent Petry
fca8bd44ab
Fix shared storage namespace in DecryptAll class 2016-10-20 20:36:50 +02:00
Joas Schilling
246bb9f33d
Move OC\Files\Storage\Shared to the right namespace 2016-10-20 20:27:44 +02:00
Thomas Müller
ef842ef20a
Ensure $commands being an array - fixes #26073 2016-10-20 15:40:27 +02:00
Morris Jobke
7836a8d8c7
use short array syntax 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2016-10-20 15:40:22 +02:00
Joas Schilling
9f2d9895a5
Restore all services when a tests failed/finished for better testcase isolation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-20 15:19:41 +02:00
Joas Schilling
122edcd0c1
Make sure all tests use the TestCase method to overwrite services 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-20 15:19:41 +02:00
Arthur Schiwon
e5ce61b174
add missing methods to test fake manager 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2016-10-20 14:32:32 +02:00
Joas Schilling
b35d2fd8f2
Allow rich object subjects for Notifications 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-20 12:14:59 +02:00
Joas Schilling
2098648850
Add Rich Object Definitions and a validator 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-20 12:14:51 +02:00
Arthur Schiwon
5d98ab83e9
resolve displayname via manager and registerable resolvers 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2016-10-19 00:34:00 +02:00
Arthur Schiwon
fea3e20a80
move mention extraction to (I)Comment and report mentions via DAV 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2016-10-19 00:33:55 +02:00
Joas Schilling
303e073724
Do not skip when mysql uses utf8mb4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-19 00:15:01 +02:00
Joas Schilling
43b7b143f4
Fix test of repair step 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-19 00:15:01 +02:00
Joas Schilling
17a2723948
Fix the test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-19 00:15:01 +02:00
Thomas Müller
9c3f066dab
Adding docker based unit test execution for mysql utf8mb4 2016-10-19 00:15:01 +02:00
Morris Jobke
296a3274cf
only disable unicode test on mysql 2016-10-19 00:15:01 +02:00
Morris Jobke
972e560e72
Adding tests for 4 byte unicode characters 
* success on SQLite and Postgres
* failure on MySQL due to the limited charset that only supports up to 3 bytes
 2016-10-19 00:15:01 +02:00
Joas Schilling
656e3f7a24
Check the mimetype before reading the content and catch exception 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-18 16:22:20 +02:00
Morris Jobke
96f8f209b9 Merge pull request #1449 from nextcloud/comments-user-mention 
Notifications for simple @-mentioning in comments
 2016-10-17 09:30:47 +02:00
Lukas Reschke
62e19dfa80 Merge pull request #1441 from nextcloud/getby-id-less-queries 
optimize Folder::getById to use less queries
 2016-10-14 15:18:23 +02:00
Christoph Wurst
53eb0f7f42 Merge pull request #1037 from nextcloud/no-double-token-update 
dont update the auth token twice
 2016-10-14 14:53:17 +02:00
Arthur Schiwon
1bcd2ca8e3
emit pre-update event for comments 
* notifications can be cleaned up, no polluted DB
* updating comments will re-notify users or remove notifications, depending on the message

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2016-10-12 18:06:22 +02:00
Robin Appelman
0d842e0550
optimize Folder::getById to use less queries 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-10-12 16:12:28 +02:00
Roeland Jago Douma
7eba1d806b
Add tests for commands in info.xml 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-11 19:48:31 +02:00
Thomas Müller
c5ca71ee82
[9.2] Register commands in info.xml (#26248) 
* Use DI to load console commands from the apps - class name to be defined in the info.xml

* Load commands from info.xml

* Fix unit test

* Allow Di magic for IMountManager

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-11 19:48:26 +02:00
Thomas Müller
b1641cc113
Fix QueryBuilderTests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-11 12:30:46 +02:00
Robin Appelman
90db361827
Add test to ensure token times are updated 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-10-11 11:06:24 +02:00
Robin Appelman
25ed6714c7
dont update the auth token twice 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2016-10-11 11:05:25 +02:00
Roeland Jago Douma
3c173378e8
Fix typehint 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-10 22:13:51 +02:00
Thomas Müller
2806a4bca7
Cleanup test case 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-10 22:13:47 +02:00
Christoph Wurst
a0cb809342 Merge pull request #1660 from nextcloud/add-notification-icon-to-api 
Add an icon to the notification API
 2016-10-10 09:32:34 +02:00
Morris Jobke
195fc041da Merge pull request #1663 from nextcloud/dont-reparse-info-xml 
Dont reparse info xml + cache AppInfo XML
 2016-10-10 09:22:43 +02:00
Christoph Wurst
ce9e33bd3c Merge pull request #1656 from nextcloud/appinfo-check-class-existance 
Make sure all the jobs, command, provides and migrations are valid
 2016-10-10 09:04:27 +02:00
Lukas Reschke
0245dd7221
Simplify isSubDirectory check 
Shaves off another 9ms per request as can be seen at https://blackfire.io/profiles/compare/dd54cef3-e58d-4a22-b8f4-c7c4b70697be/graph

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-07 21:56:43 +02:00
Lukas Reschke
0c2b17c80f
Cache AppInfo in Memory Cache if configured 
This saves around 20ms on a bare-bone instance, on bigger ones more (depending on the number of installed apps).

See https://blackfire.io/profiles/compare/fc326ad3-100d-49b8-8ea9-8343240f53f3/graph

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-07 21:29:23 +02:00
Thomas Müller
67d3574bdf
Don't parse info.xml but reuse already cached app infos - fixes #25603 (#25968) 
* Don't parse info.xml but reuse already cached app infos - fixes #25603

* Use === in InfoParser. Fixes test

* InfoParser should not depend on UrlGenerator - fixes issue with session being closed too early
 2016-10-07 20:58:22 +02:00
Arthur Schiwon
e1073cf442
Notificacations for simple @-mentioning in comments 
(WIP) notify user when mentioned in comments

Fix doc, and create absolute URL for as notification link.

PSR-4 compatibility changes

also move notification creation to comments app

Do not notify yourself

unit test for controller and application

smaller fixes

- translatable app name
- remove doubles in mention array
- micro perf optimization
- display name: special label for deleted users, keep user id for users that could not be fetched from userManager

Comment Notification-Listener Unit Test

fix email adresses

remove notification when triggering comment was deleted

add and adjust tests

add missing @license tags

simplify NotificationsController registration

appinfo simplification, php docs

make string easier to translate

adjust test

replace dispatcher-based listeners with a registration method and interface

safer to not pass optional data parameter to setSubject for marking as processed. ID and mention suffices

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

update comment

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2016-10-07 17:11:19 +02:00
Joas Schilling
c77933ca22
Add an icon to the notification API 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-07 17:00:24 +02:00
Joas Schilling
c02a50a432
Make sure all the jobs, command, provides and migrations are valid 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-07 14:25:18 +02:00
Morris Jobke
c4b2639585 Merge pull request #1514 from nextcloud/integration-tests-orphaned-shares 
Integration tests orphaned shares + Prefilter inaccessible shares
 2016-10-06 22:58:56 +02:00
Joas Schilling
a0b34dfd2f Merge pull request #1629 from nextcloud/cleanup-settings-application 
Cleanup settings Application class
 2016-10-06 16:57:39 +02:00
Joas Schilling
ed30b1f645
Use our base class everywhere 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-06 14:11:04 +02:00
Joas Schilling
b130a0ee09
phpunit min version is 4.8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-06 14:07:32 +02:00
Joas Schilling
ccc29a3da2
Fix tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-06 14:05:52 +02:00
Vincent Petry
626daabb56
Prefilter inaccessible shares in DefaultShareProvider::getSharedWith() 
The DefaultShareProvider now does a DB-level check to find out whether
file_source is accessible at all (deleted file) or whether it's in the
trashbin of a home storage.

One small corner case where the home storage id is in md5 form cannot
be covered properly with this approach.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-06 13:57:58 +02:00
Morris Jobke
c84dc6aa1c Properly catch password policy hint for personal page password changes 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2016-10-06 10:55:33 +02:00
Lukas Reschke
ea9b1cc340 Merge pull request #1306 from nextcloud/simplefs 
Introducing AppData
 2016-10-06 09:25:15 +02:00
Joas Schilling
4db5b2a2c6
Use magic DI as much as possible 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-05 16:36:49 +02:00
Joas Schilling
3395977d8f
Add a test for all the controllers and the middleware 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-05 15:25:41 +02:00
Lukas Reschke
815616fb2c Merge pull request #1624 from nextcloud/exclude_coverage_dirs 
Exclude tests and composer dir from coverage
 2016-10-05 14:49:13 +02:00
Lukas Reschke
a1f5364d7f
Generate coverage for quick DB tests 
This adds the "QUICKDB" group which excludes some tests that abuse unit tests as integration tests as displayed in https://github.com/nextcloud/server/issues/1626

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2016-10-05 13:55:44 +02:00