Commit graph

45 commits

Author SHA1 Message Date
Vincent Petry
955635c7aa Add explicit delete permission to link shares
Link shares always allowed deletion, however internally the permissions
were stored as 7 which lacked delete permissions. This created an
inconsistency in the Webdav permissions.

This fix makes sure we include delete permissions in the share
permissions, which now become 15.

In case a client is still passing 7 for legacy reasons, it gets
converted automatically to 15.
2016-06-24 09:48:48 +02:00
Stefan Weil
f7c41fa4e6 Fix typo (found by codespell) (#25073)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-06-13 08:23:33 +02:00
Sergio Bertolin
661ab1a8c5
Modified expected output according to rullzer 2016-05-02 09:31:22 +02:00
Sergio Bertolín
271ba6da63
Added integration tests directly in the code PR 2016-05-02 09:31:22 +02:00
Roeland Jago Douma
27c9d8a690
Not logged in is original calculated target 2016-04-30 10:40:45 +02:00
Lukas Reschke
e2946f7b80 Merge pull request #24030 from owncloud/integration-tests-improved-resharing
Added test case for QA-94
2016-04-16 23:28:28 +02:00
Sergio Bertolin
5b34dcc099 Added test case for QA-94 2016-04-15 13:12:34 +00:00
Roeland Jago Douma
0cebb16e7c
Move share-permissions property namespace
Fixes https://github.com/owncloud/core/issues/23741
2016-04-15 10:22:18 +02:00
Roeland Douma
411fac892a On mount make sure multiple shares with same target map to unique ones (#23937)
Scenario:
user0 shares a folder 'foo' with user2
user1 shares a folder 'foo' with user2
user2 logs in

Before: show only the 'foo' from user1

After: show both.

* Added intergration tests
2016-04-14 11:50:27 +02:00
Björn Schießle
499d131a09
always return the complete permissions the file was shared with 2016-04-12 17:56:56 +02:00
Roeland Jago Douma
8c0ef4c4bd Add sharePermissions webdav property
This property can be queries by the clients so they know the max
permissions they can use to share a file with. This will improve the UX.

The oc:permissions proptery is not enough since mountpoints have
different permissions (delete + move by default).

By making it a new property the clients can just request it. On older
servers it will just return a 404 for that property (and thus they know
they have to fall back to their hacky work arounds). But if the property
is returned the client can show proper info.

* unit tests
* intergration test
2016-03-31 20:12:34 +02:00
Roeland Jago Douma
ca2a24d286 Add intergration tests 2016-03-10 20:12:58 +01:00
Roeland Jago Douma
0dd0adf69f Intergration tests 2016-03-01 08:29:15 +01:00
Roeland Jago Douma
8924b0a0dc Check correct permissions when resharing
Fixes #22675

Since we only get a share id we do not know the path for the sharer.
Now if we edit a share we start searching for shares for that user of
that node. And deduce the permissions that way.

* Intergration test added
* Fix unit tests
2016-02-29 19:30:14 +01:00
Roeland Jago Douma
b116e80c56 Relax rootfolder check
* Updated unit tests
* Added intergration test
2016-02-26 16:05:32 +01:00
Roeland Jago Douma
8213d5df4f Do not allow sharing of the root folder
Sharing of the users root folder should not be allowed as it is very
weird UX. Also many of our clients have no proper way of displaying
this.

Added unit test

Also added intergration tests to make sure we won't allow it in the
future.
2016-02-25 20:40:30 +01:00
Morris Jobke
45e247594a Add a test that reproduces #20686
* user with a quota of 0 gets a file shared and can't update this file
  because the wrong quota is used to verify if the update is allowed
2016-02-23 14:50:24 +01:00
Roeland Jago Douma
b50edf3222 Add intergration test 2016-02-05 10:54:32 +01:00
Roeland Jago Douma
d8114d6ce6 Add intergration test 2016-01-29 15:36:37 +01:00
Roeland Jago Douma
247b2ee0aa Add intergration test for shared_with me and group shares 2016-01-21 15:56:44 +01:00
Roeland Jago Douma
01aa03341a Renable intergration test 2016-01-21 15:56:44 +01:00
Roeland Jago Douma
e081c86691 Fix integration tests 2016-01-13 22:15:19 +01:00
Roeland Jago Douma
114f6115c3 Skip one intergration test until we have fixed the getshares
The new sharing code handles things differently so there is no way for
create shares to handle this all properly.
2016-01-06 14:53:43 +01:00
Sergio Bertolin
93f4524a91 Added check for /textfile0.txt 2015-12-10 08:10:23 +00:00
Sergio Bertolin
e72955c65d Added shared by multiple channels test
* Small changes plus check of the file using propfind
* Restaured line removed accidentally
2015-12-10 08:10:23 +00:00
Sergio Bertolin
2c6e0da8f5 Change from with of 2015-11-30 14:49:35 +00:00
Sergio Bertolin
52f6592991 Making propfinds, having depth in mind and checking it in gherkin description 2015-11-30 12:20:05 +00:00
Sergio Bertolin
b99bd7f4fc Added sabre dav in webdav, modified skeleton to have parent and child folders 2015-11-27 12:55:48 +00:00
Sergio Bertolin
094a1bc7cb Added test case about a user without a share requesting it 2015-11-26 13:19:49 +00:00
Sergio Bertolin
69a03c2e60 Added test case about trying to reshare a file with more permissions 2015-11-20 11:56:05 +00:00
Sergio Bertolin
a2938385f9 Making webdav path configurable 2015-11-20 11:26:52 +00:00
Sergio Bertolin
ee4a18a16c added test about resharing 2015-11-19 14:17:56 +00:00
Sergio Bertolin
81e0a3ea22 Added test and logic for deleting all group shares 2015-11-19 12:45:13 +00:00
Sergio Bertolin
630ba2fd09 Added test for shared_with_me parameter 2015-11-19 12:45:12 +00:00
Sergio Bertolin
a990e0ac1d Added some requirements for first test case 2015-11-19 12:45:12 +00:00
Sergio Bertolin
ce8435530b Modified test to PUT only 1 parameter with each update 2015-11-12 10:36:17 +00:00
Sergio Bertolin
eb6a13c231 Added a test including all the fields of the share update and checking output 2015-11-11 17:29:38 +00:00
Sergio Bertolin
7aeda7c99a Added a test and logic for checking answer of public shares 2015-11-11 14:21:10 +00:00
Sergio Bertolin
7aa6e9b643 Added test to get info of a specific share id
Check fields of the share response

Added missing fields to check if their values are numbers
2015-11-10 16:25:34 +01:00
Sergio Bertolin
e34872141e Added tests about getting shares of a file and a test for deleting a user from a group which doesn't exist 2015-11-06 11:57:02 +01:00
Sergio Bertolin
1a51d4c4c7 Added changes in the verification of sharing get responses 2015-11-05 09:10:46 +00:00
Sergio Bertolin
3b7690f842 added test for deleting a share 2015-11-04 13:42:14 +00:00
Sergio Bertolin
0593381522 Added general function to create shares in preconditions. 2015-11-04 12:16:00 +00:00
Thomas Müller
fcc2a0c830 Upgrade behat to 3.0.x and use @BeforeScenario and @AfterScenario to clean up users 2015-10-29 17:10:52 +01:00
Sergio Bertolin
d11b69bfb9 added sharing feature file
added logic necessary for preconditions and postconditions of sharing tests

Added sharing by link tests and sharing with group

Added test which reproduces issue 19950 (adding expiration date)

refactored given and then statements to be preconditions and not operations
2015-10-29 17:10:49 +01:00