wbrawner/server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
46860 commits 157 branches 562 tags 714 MiB
Commit graph

4034 commits

Author SHA1 Message Date
Daniel Calviño Sánchez
52cada951b Check "note", "label" and "hide download" too in update share tests 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-11-02 01:56:07 +01:00
Jan-Christoph Borchardt
9dea41f8fe Fix wording, sort 'Add another link' to bottom so it does not confuse 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-11-01 21:33:10 +01:00
Jan-Christoph Borchardt
7bfb32230a Use primary color for share link icon background instead of bland grey 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-11-01 21:33:10 +01:00
John Molakvoæ (skjnldsv)
206d6126b6 Fix note display 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-01 21:30:45 +01:00
John Molakvoæ (skjnldsv)
106ed07d6a Copy link outside menu 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-01 21:30:45 +01:00
John Molakvoæ (skjnldsv)
1bd6d39b39 Migrate link shares to array 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-11-01 21:29:40 +01:00
Bjoern Schiessle
feb9f72e8b adjust unit tests 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-11-01 04:27:25 +01:00
Bjoern Schiessle
5e90711600 allow to update lables for public link shares 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-11-01 02:18:55 +01:00
Bjoern Schiessle
f377a61f90 allow to add labels to shares 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-11-01 02:15:07 +01:00
Bjoern Schiessle
d0411b2369
allow to create multiple link shares via share api 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
 2018-10-31 06:55:52 +01:00
Roeland Jago Douma
41ff001b77
Merge pull request #11899 from nextcloud/enhancement/noid/sharing-consolidation 
Sharing user consolidation
 2018-10-30 19:27:05 +01:00
Daniel Calviño Sánchez
bfb2a914d2 Honour "hide download" in the public share page 
When the "hide download" property of a share is set the public share
page will not show the download button nor the menu with the download,
direct link and "Add to your Nextcloud" actions; the "downloadURL"
hidden field will not be included either in the generated HTML.

Despite that, note that the "downloadURL" parameter is still set and
passed to the template, as this could be needed anyway to generate
previews (for example, of audio files).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-10-30 15:18:55 +01:00
Roeland Jago Douma
c237a3f003 Expose hide download to public page 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-30 15:18:55 +01:00
Roeland Jago Douma
abbb946bbb Propegate hide download state in share provider 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-30 15:18:55 +01:00
Julius Härtl
ffc32222f1
Styling papercuts 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-10-30 14:43:34 +01:00
Julius Härtl
192324e4de
Make dropdown height 6 1/2 entries 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-10-30 10:19:35 +01:00
Julius Härtl
5059605c99
Increase max-width of the share autocompletion suggestions 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-10-30 10:19:34 +01:00
Julius Härtl
3e11515b9c
Merge contacts and add type of result to the UI 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-10-30 10:19:34 +01:00
Julius Härtl
6dde7e1183
Improve share select list 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-10-30 10:19:32 +01:00
Nextcloud bot
9f99232865
[tx-robot] updated from transifex 2018-10-30 01:12:54 +00:00
Nextcloud bot
18fef12721
[tx-robot] updated from transifex 2018-10-29 01:13:07 +00:00
Nextcloud bot
0092e3adec
[tx-robot] updated from transifex 2018-10-27 00:12:35 +00:00
Morris Jobke
37782b1084
Merge pull request #11573 from nextcloud/gridview-table 
Files grid view
 2018-10-24 15:31:23 +02:00
Nextcloud bot
a9fb21f9fc
[tx-robot] updated from transifex 2018-10-23 14:54:28 +00:00
John Molakvoæ (skjnldsv)
b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-10-23 16:44:20 +02:00
Morris Jobke
9b092fd4bd
Merge pull request #11967 from nextcloud/fix-opening-a-section-again-in-the-files-app 
Fix opening a section again in the Files app
 2018-10-23 15:29:55 +02:00
John Molakvoæ (skjnldsv)
bf6a1650ce
Use preview-x & preview-y on public pages 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-10-23 08:59:34 +02:00
John Molakvoæ (skjnldsv)
ec05e5d048
Fix public background override 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-10-23 08:54:09 +02:00
John Molakvoæ (skjnldsv)
e0dde083d0
Public fixes, request & default to grid 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-10-23 08:43:02 +02:00
Joas Schilling
3febeb6ca7
Use lax CSP when the share is a talk share 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-10-22 10:57:55 +02:00
Daniel Calviño Sánchez
0426ba6de5 Remove event handler no longer needed 
The custom handler for "URL changed" events were added to reload the
file list whenever the sections for favorites and shares were opened;
this was used to fix the problem of not reloading the file lists when
opening them for a second time. However, besides that the handlers were
not really necessary, and as the root of the bug was fixed in the
previous commit those handlers are now removed.

The file list for tags uses the handler for a different purpose, though,
so that one was kept.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-10-21 20:21:59 +02:00
Daniel Calviño Sánchez
449349e901 Fix opening a section again in the Files app 
When a section is open in the Files app a "show" event is triggered.
File list objects handle that event by reloading themselves, but only
if the file list was shown at least once. However, the file list objects
of plugins are created when the "show" event is triggered for the first
time for their section; as the file list objects register their handler
for the "show" event when they are created they never handle the first
triggered "show" event, as the handler is set while that event is being
already handled. Therefore, from the point of view of the handler, the
second time that a "show" event was triggered it was seen as if the file
list was shown for the first time, and thus it was not reloaded. Now the
"shown" property is explicitly set for those file lists that are created
while handling a "show" event, which causes them to be reloaded as
expected when opening their section again.

Note that it is not possible to just reload the file list whenever it is
shown; the file list is reloaded also when the directory changes, and
this can happen when the web page is initially loaded and the URL is
parsed. In that case, if file lists were reloaded when shown for the
first time then it could be reloaded twice, one with the default
parameters due to the "show" event and another one with the proper
parameters once the URL was parsed, and the files that appeard in the
list would depend on which response from the server was received the
last.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-10-21 20:21:19 +02:00
Roeland Jago Douma
f544c9fec9
Merge pull request #11927 from stweil/clean 
Remove duplicate condition
 2018-10-19 21:15:04 +02:00
Stefan Weil
81c0f2a9a7
Remove duplicate condition 
This fixes a warning from LGTM:

    Operands additionnalShares and additionnalShares are identical.

Fix also the typo in the parameter name.
 2018-10-19 20:19:08 +02:00
Stefan Weil
c5d3febf37
Add missing variable declarations 
This fixes errors from LGTM like the following one:

    Variable i is used like a local variable,
    but is missing a declaration.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
 2018-10-19 20:17:55 +02:00
Roeland Jago Douma
97717ae3a7
Merge pull request #11905 from nextcloud/design/noid/tab-icons 
Add icon to file sidebar tabs
 2018-10-19 16:53:56 +02:00
Stefan Weil
2ad38200fb Add missing semicolons 
This fixes some recommendations from LGTM:

    Avoid automated semicolon insertion (90% of all statements
    in the enclosing function have an explicit semicolon).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
 2018-10-19 11:24:24 +02:00
Julius Härtl
45804b5bef
Add icon to file sidebar tabs 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2018-10-18 15:54:17 +02:00
Jan-Christoph Borchardt
39ff82f707
Use grid view in other file views too 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-10-18 13:44:05 +02:00
blizzz
2634ceb35b
Merge pull request #11862 from nextcloud/bugfix/ensure_cache_it_init 
Double check for failed cache with a shared storage
 2018-10-17 13:12:57 +02:00
Morris Jobke
b88ab75c3a
Merge pull request #11870 from nextcloud/fix/noid/proper-column-name-escaping 
Properly quote column name in "createFunction" call
 2018-10-16 17:02:26 +02:00
Morris Jobke
b458ed9c82
Properly escape column name in "createFunction" call 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-10-16 15:24:02 +02:00
Roeland Jago Douma
1bc388e507
Double check for failed cache with a shared storage 
When obtaining the SourceRootInfo we can call init. If this fails the
cache is set to a failed cache and the storage to a failed storage.
However we did not check for this. Which means that if the storage was
invalid it would fail later on.

Now we will properly error out.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-16 10:57:37 +02:00
Roeland Jago Douma
bee5bbbf0e
Move files_drop to compiled handlebars 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-16 08:27:06 +02:00
Nextcloud bot
7c26bbbd82
[tx-robot] updated from transifex 2018-10-10 00:13:11 +00:00
Morris Jobke
ab3599155f
Merge pull request #11716 from nextcloud/bugfix/noid/use-numeric-placeholders-for-rtl-translations 
Use numeric placeholders if there are multiple, so that RTL languages…
 2018-10-09 16:31:52 +02:00
Joas Schilling
ea21aa3f7a
Use numeric placeholders if there are multiple, so that RTL languages can operate better 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-10-09 14:32:14 +02:00
Christoph Wurst
9af69ca2a5
Fix usage of deprecated OC.webroot 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2018-10-09 13:53:59 +02:00
Nextcloud bot
d07c5db947
[tx-robot] updated from transifex 2018-10-09 00:12:27 +00:00
Christoph Wurst
dccb3ab5b2
Remove deprecated SVG helpers for old IEs 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2018-10-08 16:33:41 +02:00
Nextcloud bot
4c47ec005f
[tx-robot] updated from transifex 2018-10-07 00:12:21 +00:00
Nextcloud bot
d9fe68ed12
[tx-robot] updated from transifex 2018-10-05 00:12:56 +00:00
Roeland Jago Douma
13b1cd5cb8
Allow userId to be null 
Fixes #10852

A quick hack. Still ensures some type safety however now also accepts
null. Else we'd need to add a whole new layer of middlewares.

This can only happen when a guest user wants to access a controller that
requries the user_id.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-04 13:04:58 +02:00
Roeland Jago Douma
b10cddebe5
Move sharetabview to compiled handlebars 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-04 09:53:44 +02:00
Marin Treselj
a92e8b4c18
Merge pull request #11538 from nextcloud/heading-bold 
Set headings to Semibold for better information architecture
 2018-10-03 10:09:57 +02:00
Jan-Christoph Borchardt
2665965918
Fix header overflow, fix more apps menu, fix #11552 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-10-02 20:16:20 +02:00
Jan-Christoph Borchardt
5829fcd685
Change heading weights from Light to Semibold for better information architecture 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-10-01 23:48:11 +02:00
Roeland Jago Douma
335efcc43b
Move to 1 template file for files 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-10-01 17:15:07 +02:00
Jan-Christoph Borchardt
b9806f7012
Ellipsize long filenames and sharee names in public share page header 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
 2018-10-01 11:49:16 +02:00
Nextcloud bot
dafd708075
[tx-robot] updated from transifex 2018-09-30 00:12:06 +00:00
Nextcloud bot
73aabbd3c0
[tx-robot] updated from transifex 2018-09-29 00:12:16 +00:00
Roeland Jago Douma
ae1250f422
Compile filesummary handlebars 
Fixes #11030
For https://github.com/orgs/nextcloud/projects/18

This template is now compiled so this no longer has to happen in the
browser. Another step towards a stricter CSP.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-09-27 20:16:08 +02:00
Nextcloud bot
2ace0df82a
[tx-robot] updated from transifex 2018-09-27 00:12:26 +00:00
Arthur Schiwon
c526cdf8ab
do not explode when getting permissions from a FailedStorage 
for instance if a user of an external user backend is not available
currently, the whole Files UI would be frozen.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-09-26 10:48:37 +02:00
Nextcloud bot
2f45045c96
[tx-robot] updated from transifex 2018-09-26 00:12:23 +00:00
Nextcloud bot
bdb01064e2
[tx-robot] updated from transifex 2018-09-25 00:12:07 +00:00
Nextcloud bot
cce9f25d86
[tx-robot] updated from transifex 2018-09-23 00:12:30 +00:00
Nextcloud bot
bd89af478e
[tx-robot] updated from transifex 2018-09-22 00:12:06 +00:00
Nextcloud bot
0211e17e3f
[tx-robot] updated from transifex 2018-09-21 00:12:08 +00:00
Joas Schilling
06141b2b8a
Merge pull request #11041 from nextcloud/fix/noid/get_permission_of_storage_for_shares 
Check the permission of the underlying storage
 2018-09-19 12:15:40 +02:00
Nextcloud bot
2a51572cc4
[tx-robot] updated from transifex 2018-09-17 00:12:30 +00:00
Nextcloud bot
40bb45225a
[tx-robot] updated from transifex 2018-09-16 00:12:29 +00:00
Nextcloud bot
6112adfe06
[tx-robot] updated from transifex 2018-09-14 00:12:27 +00:00
Nextcloud bot
10351cb9da
[tx-robot] updated from transifex 2018-09-13 00:12:08 +00:00
Nextcloud bot
039145c4d1
[tx-robot] updated from transifex 2018-09-12 00:12:12 +00:00
Nextcloud bot
13166feed3
[tx-robot] updated from transifex 2018-09-09 00:13:09 +00:00
Nextcloud bot
3653a2c889
[tx-robot] updated from transifex 2018-09-08 00:12:33 +00:00
Roeland Jago Douma
a2725c31e4
Update test now that we check permissions properly 
Now that we actually check thepermissions properly we have to update the
tests.

* We checked an invalid path
* We checked from wrong permissions (files never have CREATE permissions
for example)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-09-06 17:10:21 +02:00
Roeland Jago Douma
e7b1c9adc7
Properly check share permissions 
isCreatable only works on folders
isUpdatable if the file is not there but it is a part file also has to
be checked on the folder

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-09-06 17:10:21 +02:00
Roeland Jago Douma
870ebec4ac
Fix shared cache 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-09-06 17:10:21 +02:00
Roeland Jago Douma
d7931b82ae
Check the permission of the underlying storage 
Else shares might expose more permissions than the storage actually
providers.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-09-06 17:10:21 +02:00
Nextcloud bot
3a08f71981
[tx-robot] updated from transifex 2018-09-06 00:12:53 +00:00
Joas Schilling
47cc5e5895
Update version requirements and versions of shipped apps 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-09-05 14:27:06 +02:00
Nextcloud bot
2a22615879
[tx-robot] updated from transifex 2018-08-31 00:12:09 +00:00
Nextcloud bot
4da9a15b32
[tx-robot] updated from transifex 2018-08-30 00:12:07 +00:00
Nextcloud bot
8b47f45afa
[tx-robot] updated from transifex 2018-08-27 00:12:14 +00:00
Nextcloud bot
d8147cbba7
[tx-robot] updated from transifex 2018-08-26 00:12:33 +00:00
Nextcloud bot
d644cafae7
[tx-robot] updated from transifex 2018-08-25 00:12:33 +00:00
Morris Jobke
8761856a71
Merge pull request #10838 from nextcloud/header-fixes-and-public-note 
Header fixes and public note
 2018-08-24 22:21:55 +02:00
John Molakvoæ (skjnldsv)
719f9288b9
Tests fixes 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-08-24 20:31:29 +02:00
Roeland Jago Douma
79a88ed458
Fix tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-08-24 18:20:04 +02:00
Daniel Calviño Sánchez
5c07f9c2ec
Add rooms in the default candidate types to look for when sharing 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2018-08-24 18:06:46 +02:00
Morris Jobke
e8817ed3ea
Merge pull request #10724 from nextcloud/large-share-count-performance 
Improve performance when dealing with large numbers of shares
 2018-08-24 17:10:17 +02:00
John Molakvoæ (skjnldsv)
ac2c925231
Fix mobile view and add public share note view 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-08-24 16:45:40 +02:00
John Molakvoæ (skjnldsv)
3cb52b868a
Fix header calculation and better public design 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2018-08-24 15:45:39 +02:00
Nextcloud bot
503fbc953e
[tx-robot] updated from transifex 2018-08-24 00:12:20 +00:00
Morris Jobke
2219d35207
Merge pull request #10815 from nextcloud/fix/noid/missingreturnval 
returning of $tr is expected, otherwise ending up in a JS error
 2018-08-23 14:53:00 +02:00
Nextcloud bot
c0f48a7b40
[tx-robot] updated from transifex 2018-08-23 00:12:59 +00:00
Arthur Schiwon
78f61b2ade
returning of $tr is expected, otherwise ending up in a JS error 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2018-08-23 00:28:03 +02:00
Nextcloud bot
be3438ca97
[tx-robot] updated from transifex 2018-08-21 00:12:16 +00:00