0be9de5df5
Files app: - removed file list template, now rendering list from JSON response - FileList.addFile/addDir is now FileList.add() and takes a JS map with all required arguments instead of having a long number of function arguments - added unit tests for many FileList operations - fixed newfile.php, newfolder.php and rename.php to return the file's full JSON on success - removed obsolete/unused undo code - removed download_url / loading options, now using Files.getDownloadUrl() for that - server side now uses Helper::getFileInfo() to prepare file JSON response - previews are now client-side only Breadcrumbs are now JS only: - Added BreadCrumb class to handle breadcrumb rendering and events - Added unit test for BreadCrumb class - Moved all relevant JS functions to the BreadCrumb class Public page now uses ajax to load the file list: - Added Helper class in sharing app to make it easier to authenticate and retrieve the file's real path - Added ajax/list.php to retrieve the file list - Fixed FileActions and FileList to work with the ajax list Core: - Fixed file picker dialog to use the same list format as files app
248 lines
8.7 KiB
JavaScript
248 lines
8.7 KiB
JavaScript
/**
|
|
* ownCloud
|
|
*
|
|
* @author Vincent Petry
|
|
* @copyright 2014 Vincent Petry <pvince81@owncloud.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
|
|
* License as published by the Free Software Foundation; either
|
|
* version 3 of the License, or any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public
|
|
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
/* global BreadCrumb */
|
|
describe('BreadCrumb tests', function() {
|
|
describe('Rendering', function() {
|
|
var bc;
|
|
beforeEach(function() {
|
|
bc = new BreadCrumb({
|
|
getCrumbUrl: function(part, index) {
|
|
// for testing purposes
|
|
return part.dir + '#' + index;
|
|
}
|
|
});
|
|
});
|
|
afterEach(function() {
|
|
bc = null;
|
|
});
|
|
it('Renders its own container', function() {
|
|
bc.render();
|
|
expect(bc.$el.hasClass('breadcrumb')).toEqual(true);
|
|
});
|
|
it('Renders root by default', function() {
|
|
var $crumbs;
|
|
bc.render();
|
|
$crumbs = bc.$el.find('.crumb');
|
|
expect($crumbs.length).toEqual(1);
|
|
expect($crumbs.eq(0).find('a').attr('href')).toEqual('/#0');
|
|
expect($crumbs.eq(0).find('img').length).toEqual(1);
|
|
expect($crumbs.eq(0).attr('data-dir')).toEqual('/');
|
|
});
|
|
it('Renders root when switching to root', function() {
|
|
var $crumbs;
|
|
bc.setDirectory('/somedir');
|
|
bc.setDirectory('/');
|
|
$crumbs = bc.$el.find('.crumb');
|
|
expect($crumbs.length).toEqual(1);
|
|
expect($crumbs.eq(0).attr('data-dir')).toEqual('/');
|
|
});
|
|
it('Renders last crumb with "last" class', function() {
|
|
bc.setDirectory('/abc/def');
|
|
expect(bc.$el.find('.crumb:last').hasClass('last')).toEqual(true);
|
|
});
|
|
it('Renders single path section', function() {
|
|
var $crumbs;
|
|
bc.setDirectory('/somedir');
|
|
$crumbs = bc.$el.find('.crumb');
|
|
expect($crumbs.length).toEqual(2);
|
|
expect($crumbs.eq(0).find('a').attr('href')).toEqual('/#0');
|
|
expect($crumbs.eq(0).find('img').length).toEqual(1);
|
|
expect($crumbs.eq(0).attr('data-dir')).toEqual('/');
|
|
expect($crumbs.eq(1).find('a').attr('href')).toEqual('/somedir#1');
|
|
expect($crumbs.eq(1).find('img').length).toEqual(0);
|
|
expect($crumbs.eq(1).attr('data-dir')).toEqual('/somedir');
|
|
});
|
|
it('Renders multiple path sections and special chars', function() {
|
|
var $crumbs;
|
|
bc.setDirectory('/somedir/with space/abc');
|
|
$crumbs = bc.$el.find('.crumb');
|
|
expect($crumbs.length).toEqual(4);
|
|
expect($crumbs.eq(0).find('a').attr('href')).toEqual('/#0');
|
|
expect($crumbs.eq(0).find('img').length).toEqual(1);
|
|
expect($crumbs.eq(0).attr('data-dir')).toEqual('/');
|
|
|
|
expect($crumbs.eq(1).find('a').attr('href')).toEqual('/somedir#1');
|
|
expect($crumbs.eq(1).find('img').length).toEqual(0);
|
|
expect($crumbs.eq(1).attr('data-dir')).toEqual('/somedir');
|
|
|
|
expect($crumbs.eq(2).find('a').attr('href')).toEqual('/somedir/with space#2');
|
|
expect($crumbs.eq(2).find('img').length).toEqual(0);
|
|
expect($crumbs.eq(2).attr('data-dir')).toEqual('/somedir/with space');
|
|
|
|
expect($crumbs.eq(3).find('a').attr('href')).toEqual('/somedir/with space/abc#3');
|
|
expect($crumbs.eq(3).find('img').length).toEqual(0);
|
|
expect($crumbs.eq(3).attr('data-dir')).toEqual('/somedir/with space/abc');
|
|
});
|
|
});
|
|
describe('Events', function() {
|
|
it('Calls onClick handler when clicking on a crumb', function() {
|
|
var handler = sinon.stub();
|
|
var bc = new BreadCrumb({
|
|
onClick: handler
|
|
});
|
|
bc.setDirectory('/one/two/three/four');
|
|
bc.$el.find('.crumb:eq(3)').click();
|
|
expect(handler.calledOnce).toEqual(true);
|
|
expect(handler.getCall(0).thisValue).toEqual(bc.$el.find('.crumb').get(3));
|
|
|
|
handler.reset();
|
|
bc.$el.find('.crumb:eq(0) a').click();
|
|
expect(handler.calledOnce).toEqual(true);
|
|
expect(handler.getCall(0).thisValue).toEqual(bc.$el.find('.crumb').get(0));
|
|
});
|
|
it('Calls onDrop handler when dropping on a crumb', function() {
|
|
var droppableStub = sinon.stub($.fn, 'droppable');
|
|
var handler = sinon.stub();
|
|
var bc = new BreadCrumb({
|
|
onDrop: handler
|
|
});
|
|
bc.setDirectory('/one/two/three/four');
|
|
expect(droppableStub.calledOnce).toEqual(true);
|
|
|
|
expect(droppableStub.getCall(0).args[0].drop).toBeDefined();
|
|
// simulate drop
|
|
droppableStub.getCall(0).args[0].drop({dummy: true});
|
|
|
|
expect(handler.calledOnce).toEqual(true);
|
|
expect(handler.getCall(0).args[0]).toEqual({dummy: true});
|
|
|
|
droppableStub.restore();
|
|
});
|
|
});
|
|
describe('Resizing', function() {
|
|
var bc, widthStub, dummyDir,
|
|
oldUpdateTotalWidth;
|
|
|
|
beforeEach(function() {
|
|
dummyDir = '/short name/longer name/looooooooooooonger/even longer long long long longer long/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/last one';
|
|
|
|
oldUpdateTotalWidth = BreadCrumb.prototype._updateTotalWidth;
|
|
BreadCrumb.prototype._updateTotalWidth = function() {
|
|
// need to set display:block for correct offsetWidth (no CSS loaded here)
|
|
$('div.crumb').css({
|
|
'display': 'block',
|
|
'float': 'left'
|
|
});
|
|
|
|
return oldUpdateTotalWidth.apply(this, arguments);
|
|
};
|
|
|
|
bc = new BreadCrumb();
|
|
widthStub = sinon.stub($.fn, 'width');
|
|
// append dummy navigation and controls
|
|
// as they are currently used for measurements
|
|
$('#testArea').append(
|
|
'<div id="navigation" style="width: 80px"></div>',
|
|
'<div id="controls"></div>'
|
|
);
|
|
|
|
// make sure we know the test screen width
|
|
$('#testArea').css('width', 1280);
|
|
|
|
// use test area as we need it for measurements
|
|
$('#controls').append(bc.$el);
|
|
$('#controls').append('<div class="actions"><div>Dummy action with a given width</div></div>');
|
|
});
|
|
afterEach(function() {
|
|
BreadCrumb.prototype._updateTotalWidth = oldUpdateTotalWidth;
|
|
widthStub.restore();
|
|
bc = null;
|
|
});
|
|
it('Hides breadcrumbs to fit window', function() {
|
|
var $crumbs;
|
|
|
|
widthStub.returns(500);
|
|
// triggers resize implicitly
|
|
bc.setDirectory(dummyDir);
|
|
$crumbs = bc.$el.find('.crumb');
|
|
|
|
// first one is always visible
|
|
expect($crumbs.eq(0).hasClass('hidden')).toEqual(false);
|
|
// second one has ellipsis
|
|
expect($crumbs.eq(1).hasClass('hidden')).toEqual(false);
|
|
expect($crumbs.eq(1).find('.ellipsis').length).toEqual(1);
|
|
// there is only one ellipsis in total
|
|
expect($crumbs.find('.ellipsis').length).toEqual(1);
|
|
// subsequent elements are hidden
|
|
expect($crumbs.eq(2).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(3).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(4).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(5).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(6).hasClass('hidden')).toEqual(false);
|
|
});
|
|
it('Updates ellipsis on window size increase', function() {
|
|
var $crumbs;
|
|
|
|
widthStub.returns(500);
|
|
// triggers resize implicitly
|
|
bc.setDirectory(dummyDir);
|
|
$crumbs = bc.$el.find('.crumb');
|
|
|
|
// simulate increase
|
|
$('#testArea').css('width', 1800);
|
|
bc.resize(1800);
|
|
|
|
// first one is always visible
|
|
expect($crumbs.eq(0).hasClass('hidden')).toEqual(false);
|
|
// second one has ellipsis
|
|
expect($crumbs.eq(1).hasClass('hidden')).toEqual(false);
|
|
expect($crumbs.eq(1).find('.ellipsis').length).toEqual(1);
|
|
// there is only one ellipsis in total
|
|
expect($crumbs.find('.ellipsis').length).toEqual(1);
|
|
// subsequent elements are hidden
|
|
expect($crumbs.eq(2).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(3).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(4).hasClass('hidden')).toEqual(true);
|
|
// the rest is visible
|
|
expect($crumbs.eq(5).hasClass('hidden')).toEqual(false);
|
|
expect($crumbs.eq(6).hasClass('hidden')).toEqual(false);
|
|
});
|
|
it('Updates ellipsis on window size decrease', function() {
|
|
var $crumbs;
|
|
|
|
$('#testArea').css('width', 2000);
|
|
widthStub.returns(2000);
|
|
// triggers resize implicitly
|
|
bc.setDirectory(dummyDir);
|
|
$crumbs = bc.$el.find('.crumb');
|
|
|
|
// simulate decrease
|
|
bc.resize(500);
|
|
$('#testArea').css('width', 500);
|
|
|
|
// first one is always visible
|
|
expect($crumbs.eq(0).hasClass('hidden')).toEqual(false);
|
|
// second one has ellipsis
|
|
expect($crumbs.eq(1).hasClass('hidden')).toEqual(false);
|
|
expect($crumbs.eq(1).find('.ellipsis').length).toEqual(1);
|
|
// there is only one ellipsis in total
|
|
expect($crumbs.find('.ellipsis').length).toEqual(1);
|
|
// subsequent elements are hidden
|
|
expect($crumbs.eq(2).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(3).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(4).hasClass('hidden')).toEqual(true);
|
|
// the rest is visible
|
|
expect($crumbs.eq(5).hasClass('hidden')).toEqual(true);
|
|
expect($crumbs.eq(6).hasClass('hidden')).toEqual(false);
|
|
});
|
|
});
|
|
});
|