ac939e8fd4
If an app requires a specific minor or path level server version, the version_compare prevented the installation as only the major version had been compared and that checks obviously returns `false`. Now the full version is used for comparison, making it possible to release apps for a specific minor or patch level version of Nextcloud. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
91 lines
2.6 KiB
PHP
91 lines
2.6 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @copyright 2018 Christoph Wurst <christoph@winzerhof-wurst.at>
|
|
*
|
|
* @author 2018 Christoph Wurst <christoph@winzerhof-wurst.at>
|
|
*
|
|
* @license GNU AGPL version 3 or any later version
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as
|
|
* published by the Free Software Foundation, either version 3 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
namespace Test\App;
|
|
|
|
use InvalidArgumentException;
|
|
use OC\App\CompareVersion;
|
|
use Test\TestCase;
|
|
|
|
class CompareVersionTest extends TestCase {
|
|
|
|
/** @var CompareVersion */
|
|
private $compare;
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
|
|
$this->compare = new CompareVersion();
|
|
}
|
|
|
|
public function comparisonData() {
|
|
return [
|
|
// Compatible versions
|
|
['13.0.0.3', '13.0.0', '>=', true],
|
|
['13.0.0.3', '13.0.0', '<=', true],
|
|
['13.0.0', '13.0.0', '>=', true],
|
|
['13.0.0', '13.0', '<=', true],
|
|
['13.0.0', '13', '>=', true],
|
|
['13.0.1', '13', '>=', true],
|
|
['13.0.1', '13', '<=', true],
|
|
// Incompatible major versions
|
|
['13.0.0.3', '13.0.0', '<', false],
|
|
['12.0.0', '13.0.0', '>=', false],
|
|
['12.0.0', '13.0', '>=', false],
|
|
['12.0.0', '13', '>=', false],
|
|
// Incompatible minor and patch versions
|
|
['13.0.0', '13.0.1', '>=', false],
|
|
['13.0.0', '13.1', '>=', false],
|
|
// Compatible minor and patch versions
|
|
['13.0.1', '13.0.0', '>=', true],
|
|
['13.2.0', '13.1', '>=', true],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider comparisonData
|
|
*/
|
|
public function testComparison(string $actualVersion, string $requiredVersion,
|
|
string $comparator, bool $expected) {
|
|
$isCompatible = $this->compare->isCompatible($actualVersion, $requiredVersion,
|
|
$comparator);
|
|
|
|
$this->assertEquals($expected, $isCompatible);
|
|
}
|
|
|
|
public function testInvalidServerVersion() {
|
|
$actualVersion = '13';
|
|
$this->expectException(InvalidArgumentException::class);
|
|
|
|
$this->compare->isCompatible($actualVersion, '13.0.0');
|
|
}
|
|
|
|
public function testInvalidRequiredVersion() {
|
|
$actualVersion = '13.0.0';
|
|
$this->expectException(InvalidArgumentException::class);
|
|
|
|
$this->compare->isCompatible($actualVersion, '13.0.0.9');
|
|
}
|
|
|
|
}
|