server/lib/private
Lukas Reschke 13e817e901 Throw exception on getPath if file does not exist
Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened.

This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs.

While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page.

I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.
2015-10-25 17:58:21 +01:00
..
activity update licence headers via script 2015-10-05 21:15:52 +02:00
app Merge pull request #19731 from owncloud/update-list-of-deprecated-methods 2015-10-14 16:34:55 +02:00
appframework Remove dependency on ICrypto + use XOR 2015-10-21 17:33:41 +02:00
archive
backgroundjob deduplicate @xenopathic 2015-10-06 09:52:19 +02:00
cache update licence headers via script 2015-10-05 21:15:52 +02:00
command
console adding occ upgrade text note 2015-10-14 12:16:17 +02:00
contacts
db update licence headers via script 2015-10-05 21:15:52 +02:00
diagnostics
encryption update licence headers via script 2015-10-05 21:15:52 +02:00
files Throw exception on getPath if file does not exist 2015-10-25 17:58:21 +01:00
group New \OC\SubAdmin class 2015-10-21 11:32:38 +02:00
hooks
http/client update licence headers via script 2015-10-05 21:15:52 +02:00
l10n update licence headers via script 2015-10-05 21:15:52 +02:00
legacy Legacy OC_SubAdmin is now just a wrapper 2015-10-21 11:32:38 +02:00
lock add phpdoc 2015-10-21 09:43:30 +02:00
log Expose syslog tag in the configuration 2015-10-22 17:42:55 +02:00
mail Setup sendmail transport 2015-10-08 16:48:18 +02:00
memcache deduplicate @xenopathic 2015-10-06 09:52:19 +02:00
notification Allow checking whether there are notifiers registered 2015-09-17 11:08:17 +02:00
ocs Merge pull request #18184 from owncloud/ocs-merge-headers 2015-10-21 10:36:37 +02:00
preview deduplicate @xenopathic 2015-10-06 09:52:19 +02:00
route deduplicate @xenopathic 2015-10-06 09:52:19 +02:00
search
security update licence headers via script 2015-10-05 21:15:52 +02:00
session Delete cookie instead of emptying value 2015-10-19 19:54:12 +02:00
setup [OCI setup] remove static logger/config calls 2015-10-20 08:53:57 +02:00
share detect object homestorage in share code 2015-10-16 21:41:51 +02:00
tagging
template
user Make sure that remote shares use the correct uid casing 2015-10-06 15:16:19 +02:00
activitymanager.php update licence headers via script 2015-10-05 21:15:52 +02:00
allconfig.php Move the filtering of sensitive data to the config class 2015-09-25 11:08:33 +02:00
api.php Merge pull request #18184 from owncloud/ocs-merge-headers 2015-10-21 10:36:37 +02:00
app.php deduplicate @xenopathic 2015-10-06 09:52:19 +02:00
appconfig.php update licence headers via script 2015-10-05 21:15:52 +02:00
apphelper.php
archive.php
avatar.php
avatarmanager.php
capabilitiesmanager.php
config.php
contactsmanager.php
databaseexception.php
databasesetupexception.php
datetimeformatter.php
datetimezone.php
db.php
defaults.php
eventsource.php update licence headers via script 2015-10-05 21:15:52 +02:00
filechunking.php work directly on storages when doing a chunked upload assembly 2015-09-14 20:35:33 +02:00
files.php The full name has to be tested if it's a dir - fixes #19854 2015-10-19 10:07:33 +02:00
forbiddenexception.php
group.php Add remark that $run is not supported anymore 2015-10-02 23:19:26 +02:00
helper.php update licence headers via script 2015-10-05 21:15:52 +02:00
hintexception.php
hook.php Throw exception on getPath if file does not exist 2015-10-25 17:58:21 +01:00
httphelper.php
image.php
installer.php an-app-is-identified-by-having-a-info.xml-app.php-should-not-be-mandatory 2015-10-16 17:25:22 +02:00
json.php Encode HTML tags in JSON 2015-09-03 00:44:46 +02:00
l10n.php update licence headers via script 2015-10-05 21:15:52 +02:00
largefilehelper.php
log.php update licence headers via script 2015-10-05 21:15:52 +02:00
naturalsort.php update licence headers via script 2015-10-05 21:15:52 +02:00
naturalsort_defaultcollator.php
navigationmanager.php
needsupdateexception.php
notsquareexception.php
ocs.php update licence headers via script 2015-10-05 21:15:52 +02:00
ocsclient.php Disable app store for EE by default 2015-10-08 14:52:52 +02:00
preview.php Add tests 2015-10-01 13:17:22 +02:00
previewmanager.php
repair.php Repair step to remove bogus expiration dates from non-link shares 2015-10-01 08:27:12 +02:00
repairexception.php
repairstep.php
response.php Add blob: scheme to default CSP policy 2015-09-29 14:27:35 +02:00
search.php
server.php Remove dependency on ICrypto + use XOR 2015-10-21 17:33:41 +02:00
servernotavailableexception.php
serviceunavailableexception.php
setup.php
streamer.php Only use zip64 when we have 64 bit php 2015-10-08 09:13:08 +02:00
subadmin.php New \OC\SubAdmin class 2015-10-21 11:32:38 +02:00
systemconfig.php Deduplicate constant 2015-09-25 13:17:23 +02:00
tagmanager.php
tags.php
template.php Merge pull request #19537 from owncloud/fix-white-page-of-death 2015-10-07 14:55:11 +02:00
templatelayout.php Always pass in ILogger 2015-10-09 14:08:22 +02:00
tempmanager.php deduplicate @xenopathic 2015-10-06 09:52:19 +02:00
updater.php Merge pull request #19918 from owncloud/send-begin-message 2015-10-21 14:52:19 +02:00
urlgenerator.php
user.php Add remark that $run is not supported anymore 2015-10-02 23:19:26 +02:00
util.php Remove dependency on ICrypto + use XOR 2015-10-21 17:33:41 +02:00