272a46ebe1
A backend can now specify generic authentication schemes that it
supports, instead of specifying the parameters for its authentication
method directly. This allows multiple authentication mechanisms to be
implemented for a single scheme, providing altered functionality.
This commit introduces the backend framework for this feature, and so at
this point the UI will be broken as the frontend does not specify the
required information.
Terminology:
- authentication scheme
Parameter interface for the authentication method. A backend
supporting the 'password' scheme accepts two parameters, 'user' and
'password'.
- authentication mechanism
Specific mechanism implementing a scheme. Basic mechanisms may
forward configuration options directly to the backend, more advanced
ones may lookup parameters or retrieve them from the session
New dropdown selector for external storage configurations to select the
authentication mechanism to be used.
Authentication mechanisms can have visibilities, just like backends.
The API was extended too to make it easier to add/remove visibilities.
In addition, the concept of 'allowed visibility' has been introduced, so
a backend/auth mechanism can force a maximum visibility level (e.g.
Local storage type) that cannot be overridden by configuration in the
web UI.
An authentication mechanism is a fully instantiated implementation. This
allows an implementation to have dependencies injected into it, e.g. an
\OCP\IDB for database operations.
When a StorageConfig is being prepared for mounting, the authentication
mechanism implementation has manipulateStorage() called,
which inserts the relevant authentication method options into the
storage ready for mounting.
100 lines
2.7 KiB
PHP
100 lines
2.7 KiB
PHP
<?php
|
|
/**
|
|
* @author Vincent Petry <pvince81@owncloud.com>
|
|
*
|
|
* @copyright Copyright (c) 2015, ownCloud, Inc.
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
namespace OCA\Files_external\Tests\Controller;
|
|
|
|
use \OCA\Files_external\Controller\UserStoragesController;
|
|
use \OCA\Files_external\Service\UserStoragesService;
|
|
use \OCP\AppFramework\Http;
|
|
use \OCA\Files_external\NotFoundException;
|
|
use \OCA\Files_External\Lib\StorageConfig;
|
|
use \OCA\Files_External\Service\BackendService;
|
|
|
|
class UserStoragesControllerTest extends StoragesControllerTest {
|
|
|
|
/**
|
|
* @var array
|
|
*/
|
|
private $oldAllowedBackends;
|
|
|
|
public function setUp() {
|
|
parent::setUp();
|
|
$this->service = $this->getMockBuilder('\OCA\Files_external\Service\UserStoragesService')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->controller = new UserStoragesController(
|
|
'files_external',
|
|
$this->getMock('\OCP\IRequest'),
|
|
$this->getMock('\OCP\IL10N'),
|
|
$this->service
|
|
);
|
|
}
|
|
|
|
public function testAddOrUpdateStorageDisallowedBackend() {
|
|
$backend = $this->getBackendMock();
|
|
$backend->method('isVisibleFor')
|
|
->with(BackendService::VISIBILITY_PERSONAL)
|
|
->willReturn(false);
|
|
$authMech = $this->getAuthMechMock();
|
|
|
|
$storageConfig = new StorageConfig(1);
|
|
$storageConfig->setMountPoint('mount');
|
|
$storageConfig->setBackend($backend);
|
|
$storageConfig->setAuthMechanism($authMech);
|
|
$storageConfig->setBackendOptions([]);
|
|
|
|
$this->service->expects($this->exactly(2))
|
|
->method('createStorage')
|
|
->will($this->returnValue($storageConfig));
|
|
$this->service->expects($this->never())
|
|
->method('addStorage');
|
|
$this->service->expects($this->never())
|
|
->method('updateStorage');
|
|
|
|
$response = $this->controller->create(
|
|
'mount',
|
|
'\OC\Files\Storage\SMB',
|
|
'\Auth\Mechanism',
|
|
array(),
|
|
[],
|
|
[],
|
|
[],
|
|
null
|
|
);
|
|
|
|
$this->assertEquals(Http::STATUS_UNPROCESSABLE_ENTITY, $response->getStatus());
|
|
|
|
$response = $this->controller->update(
|
|
1,
|
|
'mount',
|
|
'\OC\Files\Storage\SMB',
|
|
'\Auth\Mechanism',
|
|
array(),
|
|
[],
|
|
[],
|
|
[],
|
|
null
|
|
);
|
|
|
|
$this->assertEquals(Http::STATUS_UNPROCESSABLE_ENTITY, $response->getStatus());
|
|
}
|
|
|
|
}
|